You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Marshall Schor (JIRA)" <ji...@codehaus.org> on 2010/11/23 19:55:04 UTC

[jira] Created: (MASSEMBLY-532) Documentation has parts reversed for full include/exclude patterns in dependencySet

Documentation has parts reversed for full include/exclude patterns in dependencySet
-----------------------------------------------------------------------------------

                 Key: MASSEMBLY-532
                 URL: http://jira.codehaus.org/browse/MASSEMBLY-532
             Project: Maven 2.x Assembly Plugin
          Issue Type: Improvement
    Affects Versions: 2.2
            Reporter: Marshall Schor


The documentation says:

--------------------------
(website: http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html#class_dependencySet )

for includes and excludes:

(Many) When <include> subelements are present, they define a set of artifact coordinates to include. If none is present, then <includes> represents all valid values. Artifact coordinatess may be given in simple groupId:artifactId form, or they may be fully qualified in the form groupId:artifactId:type:version[:classifier]. Additionally, wildcards can be used, as in *:maven-*

--------------------------
The book:
http://www.sonatype.com/books/mvnref-book/reference/assemblies-sect-controlling-contents.html#assemblies-sect-fine-tune

says: 

groupId:artifactId:type[:classifier] - conflict id

The pattern allows you to specify a wider set of coordinates to create a more specific include/exclude pattern.

groupId:artifactId:type[:classifier]:version - full artifact identity

==========================
Trying this out, the book seems correct, while the website ordering gives a warning that nothing is found.  The difference is: the placement of "version" - the way that works is to put it at the end, not in the middle.

Another page on the website, http://maven.apache.org/plugins/maven-assembly-plugin/advanced-descriptor-topics.html#Advanced_Artifact-Matching_in_includes_and_excludes , also has the order for the version not at the end, which I think is wrong.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] (MASSEMBLY-532) Documentation has parts reversed for full include/exclude patterns in dependencySet

Posted by "Dennis Lundberg (JIRA)" <ji...@codehaus.org>.
     [ https://jira.codehaus.org/browse/MASSEMBLY-532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dennis Lundberg closed MASSEMBLY-532.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.4
         Assignee: Dennis Lundberg

Fixed in [r1402850|http://svn.apache.org/viewvc?view=revision&revision=1402850].
                
> Documentation has parts reversed for full include/exclude patterns in dependencySet
> -----------------------------------------------------------------------------------
>
>                 Key: MASSEMBLY-532
>                 URL: https://jira.codehaus.org/browse/MASSEMBLY-532
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.2
>            Reporter: Marshall Schor
>            Assignee: Dennis Lundberg
>             Fix For: 2.4
>
>
> The documentation says:
> --------------------------
> (website: http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html#class_dependencySet )
> for includes and excludes:
> (Many) When <include> subelements are present, they define a set of artifact coordinates to include. If none is present, then <includes> represents all valid values. Artifact coordinatess may be given in simple groupId:artifactId form, or they may be fully qualified in the form groupId:artifactId:type:version[:classifier]. Additionally, wildcards can be used, as in *:maven-*
> --------------------------
> The book:
> http://www.sonatype.com/books/mvnref-book/reference/assemblies-sect-controlling-contents.html#assemblies-sect-fine-tune
> says: 
> groupId:artifactId:type[:classifier] - conflict id
> The pattern allows you to specify a wider set of coordinates to create a more specific include/exclude pattern.
> groupId:artifactId:type[:classifier]:version - full artifact identity
> ==========================
> Trying this out, the book seems correct, while the website ordering gives a warning that nothing is found.  The difference is: the placement of "version" - the way that works is to put it at the end, not in the middle.
> Another page on the website, http://maven.apache.org/plugins/maven-assembly-plugin/advanced-descriptor-topics.html#Advanced_Artifact-Matching_in_includes_and_excludes , also has the order for the version not at the end, which I think is wrong.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (MASSEMBLY-532) Documentation has parts reversed for full include/exclude patterns in dependencySet

Posted by "Johan Erlands (JIRA)" <ji...@codehaus.org>.
    [ https://jira.codehaus.org/browse/MASSEMBLY-532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=277634#comment-277634 ] 

Johan Erlands commented on MASSEMBLY-532:
-----------------------------------------

I can verify that this documentation misstake should be fixed. I followed the documentation nothing got into the my assembly only a warning. Even with the -X flag I couldn't see that I made a configuration error it just said it was removed by a filter...

> Documentation has parts reversed for full include/exclude patterns in dependencySet
> -----------------------------------------------------------------------------------
>
>                 Key: MASSEMBLY-532
>                 URL: https://jira.codehaus.org/browse/MASSEMBLY-532
>             Project: Maven 2.x Assembly Plugin
>          Issue Type: Improvement
>    Affects Versions: 2.2
>            Reporter: Marshall Schor
>
> The documentation says:
> --------------------------
> (website: http://maven.apache.org/plugins/maven-assembly-plugin/assembly.html#class_dependencySet )
> for includes and excludes:
> (Many) When <include> subelements are present, they define a set of artifact coordinates to include. If none is present, then <includes> represents all valid values. Artifact coordinatess may be given in simple groupId:artifactId form, or they may be fully qualified in the form groupId:artifactId:type:version[:classifier]. Additionally, wildcards can be used, as in *:maven-*
> --------------------------
> The book:
> http://www.sonatype.com/books/mvnref-book/reference/assemblies-sect-controlling-contents.html#assemblies-sect-fine-tune
> says: 
> groupId:artifactId:type[:classifier] - conflict id
> The pattern allows you to specify a wider set of coordinates to create a more specific include/exclude pattern.
> groupId:artifactId:type[:classifier]:version - full artifact identity
> ==========================
> Trying this out, the book seems correct, while the website ordering gives a warning that nothing is found.  The difference is: the placement of "version" - the way that works is to put it at the end, not in the middle.
> Another page on the website, http://maven.apache.org/plugins/maven-assembly-plugin/advanced-descriptor-topics.html#Advanced_Artifact-Matching_in_includes_and_excludes , also has the order for the version not at the end, which I think is wrong.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira