You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Julian Foad <ju...@btopenworld.com> on 2008/09/08 14:42:59 UTC
Re: svn trunk r32962: FAIL (x86-macosx-gnu shared)
On Mon, 2008-09-08 at 04:39 +0200, buildbot@mobsol.be wrote:
> Full details are available at:
> http://www.mobsol.be/buildbot/x86-macosx-gnu%2520shared/builds/33
Lieven,
Your MacOSX build-bot is failing, I think, because the version of Python
is 2.3.5 but to run the tests it needs to be at least 2.4.
- Julian
> Subversion Buildbot
> http://www.mobsol.be/buildbot/
[...]
> Running all tests in commit_tests.py [27/58]...FAILURE
[...]
> Running all tests in log_tests.py [32/58]...FAILURE
[...]
> Running all tests in merge_tests.py [37/58]...FAILURE
> Running all tests in merge_authz_tests.py [38/58]...FAILURE
[...]
> Running all tests in blame_tests.py [44/58]...FAILURE
[...]
> At least one test FAILED, checking /Users/lgo/slavedir/osx10.4-gcc4.0.1-ia32/build/tests.log
> FAIL: commit_tests.py 28: commit deletion of out-of-date file or dir
> FAIL: blame_tests.py 10: test 'svn blame -g'
> FAIL: blame_tests.py 11: don't look for merged files out of range
> make[1]: *** [check] Error 1
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn trunk r32962: FAIL (x86-macosx-gnu shared)
Posted by Julian Foad <ju...@btopenworld.com>.
On Mon, 2008-09-08 at 22:26 +0200, Lieven Govaerts wrote:
> Julian Foad wrote:
> ..
> > I'll re-code that "svn_propset" test function I wrote to avoid
> > Python-2.4 features, unless you beat me to it. I think that single thing
> > accounts for the blame_tests and log_tests and merge_authz_tests
> > failures.
>
> Looks like a simple fix is this:
>
> local_paths = tuple([local_path(path) for path in paths])
>
> ... but my python-fu isn't good enough to decide if this is the most
> efficient solution.
I've just been reading up about generator expressions (which is the
Python-2.4 way I wrote it, without the square brackets), and came to the
same conclusion as you. So, committing... r32972.
Thanks for that, and I hope this (and 32971 which makes commit_tests 28
XFAIL over DAV) fix all the failures.
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn trunk r32962: FAIL (x86-macosx-gnu shared)
Posted by Lieven Govaerts <sv...@mobsol.be>.
Julian Foad wrote:
..
> I'll re-code that "svn_propset" test function I wrote to avoid
> Python-2.4 features, unless you beat me to it. I think that single thing
> accounts for the blame_tests and log_tests and merge_authz_tests
> failures.
Looks like a simple fix is this:
local_paths = tuple([local_path(path) for path in paths])
... but my python-fu isn't good enough to decide if this is the most
efficient solution.
Lieven
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn trunk r32962: FAIL (x86-macosx-gnu shared)
Posted by Julian Foad <ju...@btopenworld.com>.
On Mon, 2008-09-08 at 21:41 +0200, Lieven Govaerts wrote:
> Julian Foad wrote:
> > On Mon, 2008-09-08 at 04:39 +0200, buildbot@mobsol.be wrote:
> >> Full details are available at:
> >> http://www.mobsol.be/buildbot/x86-macosx-gnu%2520shared/builds/33
> >
> > Lieven,
> >
> > Your MacOSX build-bot is failing, I think, because the version of Python
> > is 2.3.5 but to run the tests it needs to be at least 2.4.
>
> Since when do we require python 2.4 for the test suite? INSTALL says
> python 2.2 and I can't remember there being a discussion about it after:
> http://svn.haxx.se/dev/archive-2007-10/0867.shtml
Oh... <looking.../> yes... it appears I fell down by trusting my memory,
and you speak the truth. My apologies.
> It does look like the blame tests are failing because of this, but I
> doubt it'll be difficult to fix - I'll have a look right away. The
> commit test 28 seems to be failing because of an incorrect error message.
I'll re-code that "svn_propset" test function I wrote to avoid
Python-2.4 features, unless you beat me to it. I think that single thing
accounts for the blame_tests and log_tests and merge_authz_tests
failures.
That commit_tests 28 failure looks like a result of my merging the
double-delete branch back to trunk in r32901. I hadn't paid it much
attention because it was only this build-bot reporting a failure, but
now I see that this is the only one running tests over HTTP. So I'll fix
this too (by making it XFail).
> If not necessary, I'd rather not upgrade the buildbot's python version.
That seems reasonable now. Maybe it would be good for build bots to run
the oldest version (of dependencies) that we claim to support!
- Julian
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn trunk r32962: FAIL (x86-macosx-gnu shared)
Posted by Lieven Govaerts <sv...@mobsol.be>.
Julian Foad wrote:
> On Mon, 2008-09-08 at 04:39 +0200, buildbot@mobsol.be wrote:
>> Full details are available at:
>> http://www.mobsol.be/buildbot/x86-macosx-gnu%2520shared/builds/33
>
> Lieven,
>
> Your MacOSX build-bot is failing, I think, because the version of Python
> is 2.3.5 but to run the tests it needs to be at least 2.4.
>
Since when do we require python 2.4 for the test suite? INSTALL says
python 2.2 and I can't remember there being a discussion about it after:
http://svn.haxx.se/dev/archive-2007-10/0867.shtml
It does look like the blame tests are failing because of this, but I
doubt it'll be difficult to fix - I'll have a look right away. The
commit test 28 seems to be failing because of an incorrect error message.
If not necessary, I'd rather not upgrade the buildbot's python version.
Lieven
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org