You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Tomás Fernández Löbbe <tf...@apache.org> on 2018/05/04 19:49:25 UTC
Review Request 66967: SolrCmdDistributor retries requestss from
leader to followers
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66967/
-----------------------------------------------------------
Review request for lucene.
Repository: lucene-solr
Description
-------
Still need to do some more testing. Won't be committing the log4j changes
Diffs
-----
solr/core/src/java/org/apache/solr/update/SolrCmdDistributor.java 08b397fbb2
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java d5e4194b15
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java 224bd4b6ba
solr/core/src/test-files/log4j2.xml 7d0ebf7a49
solr/core/src/test/org/apache/solr/update/MockStreamingSolrClients.java 72d39ff89b
solr/core/src/test/org/apache/solr/update/SolrCmdDistributorTest.java 1699b0d70d
Diff: https://reviews.apache.org/r/66967/diff/1/
Testing
-------
Thanks,
Tomás Fernández Löbbe
Re: Review Request 66967: SolrCmdDistributor retries requestss from
leader to followers
Posted by Tomás Fernández Löbbe <tf...@apache.org>.
> On May 4, 2018, 9:11 p.m., Varun Thacker wrote:
> > solr/core/src/test/org/apache/solr/update/MockStreamingSolrClients.java
> > Line 28 (original)
> > <https://reviews.apache.org/r/66967/diff/1/?file=2016949#file2016949line32>
> >
> > We can use @LogLevel("org.apache.solr.update.SolrCmdDistributor=DEBUG) for this test to make it easier to check manually if the retires are happening or not . This would avoid changing the log4j2.xml file
Thanks! I didn't know that existed.
- Tomás
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66967/#review202485
-----------------------------------------------------------
On May 4, 2018, 7:49 p.m., Tomás Fernández Löbbe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66967/
> -----------------------------------------------------------
>
> (Updated May 4, 2018, 7:49 p.m.)
>
>
> Review request for lucene.
>
>
> Repository: lucene-solr
>
>
> Description
> -------
>
> Still need to do some more testing. Won't be committing the log4j changes
>
>
> Diffs
> -----
>
> solr/core/src/java/org/apache/solr/update/SolrCmdDistributor.java 08b397fbb2
> solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java d5e4194b15
> solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java 224bd4b6ba
> solr/core/src/test-files/log4j2.xml 7d0ebf7a49
> solr/core/src/test/org/apache/solr/update/MockStreamingSolrClients.java 72d39ff89b
> solr/core/src/test/org/apache/solr/update/SolrCmdDistributorTest.java 1699b0d70d
>
>
> Diff: https://reviews.apache.org/r/66967/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tomás Fernández Löbbe
>
>
Re: Review Request 66967: SolrCmdDistributor retries requestss from
leader to followers
Posted by Varun Thacker <va...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66967/#review202485
-----------------------------------------------------------
solr/core/src/test/org/apache/solr/update/MockStreamingSolrClients.java
Line 28 (original)
<https://reviews.apache.org/r/66967/#comment284303>
We can use @LogLevel("org.apache.solr.update.SolrCmdDistributor=DEBUG) for this test to make it easier to check manually if the retires are happening or not . This would avoid changing the log4j2.xml file
- Varun Thacker
On May 4, 2018, 7:49 p.m., Tomás Fernández Löbbe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66967/
> -----------------------------------------------------------
>
> (Updated May 4, 2018, 7:49 p.m.)
>
>
> Review request for lucene.
>
>
> Repository: lucene-solr
>
>
> Description
> -------
>
> Still need to do some more testing. Won't be committing the log4j changes
>
>
> Diffs
> -----
>
> solr/core/src/java/org/apache/solr/update/SolrCmdDistributor.java 08b397fbb2
> solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java d5e4194b15
> solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java 224bd4b6ba
> solr/core/src/test-files/log4j2.xml 7d0ebf7a49
> solr/core/src/test/org/apache/solr/update/MockStreamingSolrClients.java 72d39ff89b
> solr/core/src/test/org/apache/solr/update/SolrCmdDistributorTest.java 1699b0d70d
>
>
> Diff: https://reviews.apache.org/r/66967/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Tomás Fernández Löbbe
>
>
Re: Review Request 66967: SolrCmdDistributor retries requestss from
leader to followers
Posted by Tomás Fernández Löbbe <tf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66967/
-----------------------------------------------------------
(Updated May 9, 2018, 4:33 a.m.)
Review request for lucene.
Changes
-------
Don't retry on DBQ
Repository: lucene-solr
Description
-------
SolrCmdDistributor retries requestss from leader to followers
Diffs (updated)
-----
solr/core/src/java/org/apache/solr/update/SolrCmdDistributor.java 08b397fbb2
solr/core/src/java/org/apache/solr/update/StreamingSolrClients.java 316aa455a1
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java d5e4194b15
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java 224bd4b6ba
solr/core/src/test/org/apache/solr/cloud/ChaosMonkeySafeLeaderTest.java 76c1984a0d
solr/core/src/test/org/apache/solr/update/MockStreamingSolrClients.java 72d39ff89b
solr/core/src/test/org/apache/solr/update/SolrCmdDistributorTest.java 1699b0d70d
Diff: https://reviews.apache.org/r/66967/diff/4/
Changes: https://reviews.apache.org/r/66967/diff/3-4/
Testing
-------
Thanks,
Tomás Fernández Löbbe
Re: Review Request 66967: SolrCmdDistributor retries requestss from
leader to followers
Posted by Tomás Fernández Löbbe <tf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66967/
-----------------------------------------------------------
(Updated May 8, 2018, 3:51 a.m.)
Review request for lucene.
Repository: lucene-solr
Description (updated)
-------
SolrCmdDistributor retries requestss from leader to followers
Diffs (updated)
-----
solr/core/src/java/org/apache/solr/update/SolrCmdDistributor.java 08b397fbb2
solr/core/src/java/org/apache/solr/update/StreamingSolrClients.java 316aa455a1
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java d5e4194b15
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java 224bd4b6ba
solr/core/src/test/org/apache/solr/cloud/ChaosMonkeySafeLeaderTest.java 76c1984a0d
solr/core/src/test/org/apache/solr/update/MockStreamingSolrClients.java 72d39ff89b
solr/core/src/test/org/apache/solr/update/SolrCmdDistributorTest.java 1699b0d70d
Diff: https://reviews.apache.org/r/66967/diff/3/
Changes: https://reviews.apache.org/r/66967/diff/2-3/
Testing
-------
Thanks,
Tomás Fernández Löbbe
Re: Review Request 66967: SolrCmdDistributor retries requestss from
leader to followers
Posted by Tomás Fernández Löbbe <tf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66967/
-----------------------------------------------------------
(Updated May 4, 2018, 10:04 p.m.)
Review request for lucene.
Changes
-------
Removed log4j change. Fixed bug that broke test
Repository: lucene-solr
Description
-------
Still need to do some more testing. Won't be committing the log4j changes
Diffs (updated)
-----
solr/core/src/java/org/apache/solr/update/SolrCmdDistributor.java 08b397fbb2
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java d5e4194b15
solr/core/src/java/org/apache/solr/update/processor/TimeRoutedAliasUpdateProcessor.java 224bd4b6ba
solr/core/src/test/org/apache/solr/update/MockStreamingSolrClients.java 72d39ff89b
solr/core/src/test/org/apache/solr/update/SolrCmdDistributorTest.java 1699b0d70d
Diff: https://reviews.apache.org/r/66967/diff/2/
Changes: https://reviews.apache.org/r/66967/diff/1-2/
Testing
-------
Thanks,
Tomás Fernández Löbbe