You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by gm...@apache.org on 2007/02/06 18:37:06 UTC

svn commit: r504212 - in /myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/imageloop: HtmlImageLoopRenderer.java ImageLoopItemsIterator.java

Author: gmuellan
Date: Tue Feb  6 09:37:03 2007
New Revision: 504212

URL: http://svn.apache.org/viewvc?view=rev&rev=504212
Log:
removed jdk1.5 compliant code, removed unnecessary inline variable

Modified:
    myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/imageloop/HtmlImageLoopRenderer.java
    myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/imageloop/ImageLoopItemsIterator.java

Modified: myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/imageloop/HtmlImageLoopRenderer.java
URL: http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/imageloop/HtmlImageLoopRenderer.java?view=diff&rev=504212&r1=504211&r2=504212
==============================================================================
--- myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/imageloop/HtmlImageLoopRenderer.java (original)
+++ myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/imageloop/HtmlImageLoopRenderer.java Tue Feb  6 09:37:03 2007
@@ -18,12 +18,8 @@
  */
 package org.apache.myfaces.custom.imageloop;
 
-import java.io.IOException;
-
-import javax.faces.component.UIComponent;
-import javax.faces.context.FacesContext;
-import javax.faces.context.ResponseWriter;
-
+import org.apache.myfaces.custom.dojo.DojoConfig;
+import org.apache.myfaces.custom.dojo.DojoUtils;
 import org.apache.myfaces.renderkit.html.util.AddResource;
 import org.apache.myfaces.renderkit.html.util.AddResourceFactory;
 import org.apache.myfaces.shared_tomahawk.renderkit.JSFAttr;
@@ -31,8 +27,10 @@
 import org.apache.myfaces.shared_tomahawk.renderkit.html.HTML;
 import org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRenderer;
 
-import org.apache.myfaces.custom.dojo.DojoConfig;
-import org.apache.myfaces.custom.dojo.DojoUtils;
+import javax.faces.component.UIComponent;
+import javax.faces.context.FacesContext;
+import javax.faces.context.ResponseWriter;
+import java.io.IOException;
 
 /**
  * HTML image loop renderer. 
@@ -41,8 +39,8 @@
  */
 public class HtmlImageLoopRenderer extends HtmlRenderer {
     
-    private static final Integer DEFAULT_DELAY = Integer.valueOf(1000);
-    private static final Integer DEFAULT_TRANSITION_TIME = Integer.valueOf(1000);
+    private static final Integer DEFAULT_DELAY = new Integer(1000);
+    private static final Integer DEFAULT_TRANSITION_TIME = new Integer(1000);
 
     /**
      * Add the javascript files needed by Dojo and the custom javascript for

Modified: myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/imageloop/ImageLoopItemsIterator.java
URL: http://svn.apache.org/viewvc/myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/imageloop/ImageLoopItemsIterator.java?view=diff&rev=504212&r1=504211&r2=504212
==============================================================================
--- myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/imageloop/ImageLoopItemsIterator.java (original)
+++ myfaces/tomahawk/trunk/sandbox/core/src/main/java/org/apache/myfaces/custom/imageloop/ImageLoopItemsIterator.java Tue Feb  6 09:37:03 2007
@@ -18,16 +18,15 @@
  */
 package org.apache.myfaces.custom.imageloop;
 
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.Iterator;
-import java.util.NoSuchElementException;
+import org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils;
 
 import javax.faces.component.UIComponent;
 import javax.faces.component.UIGraphic;
 import javax.faces.el.ValueBinding;
-
-import org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.Iterator;
+import java.util.NoSuchElementException;
 
 /**
  * Image items iterator.
@@ -67,8 +66,7 @@
                 UIGraphic uiGraphic = (UIGraphic) child;
                 // UIGraphic.getUrl() is an alias for UIGraphic.getValue()
                 String url = uiGraphic.getUrl();
-                GraphicItem item = new GraphicItem(url);
-                _nextItem = item;
+                _nextItem = new GraphicItem(url);
                 return true;
             }
             else if (child instanceof ImageLoopItems)