[GitHub] [arrow] save-buffer commented on a diff in pull request #13143: ARROW-16523: [C++] Part 1 of ExecPlan cleanup: Centralized Task Group

[GitBox <gi...@apache.org>]

save-buffer commented on code in PR #13143:
URL: https://github.com/apache/arrow/pull/13143#discussion_r918343203


##########
cpp/src/arrow/compute/exec/hash_join_node.cc:
##########
@@ -894,25 +898,42 @@ class HashJoinNode : public ExecNode {
     }
   }
 
-  Status PrepareToProduce() override {
+  Status Init() override {
+    RETURN_NOT_OK(ExecNode::Init());
     bool use_sync_execution = !(plan_->exec_context()->executor());
     // TODO(ARROW-15732)
     // Each side of join might have an IO thread being called from. Once this is fixed
     // we will change it back to just the CPU's thread pool capacity.
     size_t num_threads = (GetCpuThreadPoolCapacity() + io::GetIOThreadPoolCapacity() + 1);

Review Comment:
   Eventually, it will be `max_concurrency` when ARROW-15732 is fixed (since `max_concurrency` only returns GetCpuThreadPoolCapacity). 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org