You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/08/17 14:17:18 UTC

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #4963: Fix db migration down

ocket8888 commented on a change in pull request #4963:
URL: https://github.com/apache/trafficcontrol/pull/4963#discussion_r471509716



##########
File path: traffic_ops/app/db/migrations/20200811082611_add_server_ip_profile_trigger.sql
##########
@@ -114,11 +114,10 @@ EXECUTE PROCEDURE before_ip_address_table();
 
 -- +goose Down
 -- SQL section 'Down' is executed when this migration is rolled back
-DROP FUNCTION IF EXISTS before_server_table();
-DROP FUNCTION IF EXISTS before_ip_address_table();
-
 DROP TRIGGER IF EXISTS before_update_server_trigger ON server;
 DROP TRIGGER IF EXISTS before_create_server_trigger ON server;
 DROP TRIGGER IF EXISTS before_update_ip_address_trigger ON ip_address;
 DROP TRIGGER IF EXISTS before_create_ip_address_trigger ON ip_address;
 
+DROP FUNCTION IF EXISTS before_server_table();
+DROP FUNCTION IF EXISTS before_ip_address_table();

Review comment:
       Text files must end with a terminating newline.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org