You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Martin Grigorov <mg...@apache.org> on 2019/12/03 12:08:27 UTC
Re: FileUpload class still implements IClusterable
Hi Ernesto,
Yes, I think FileUpload should not be Serializable.
FileUploadField uses transient reference to the list of file uploads for
this reason:
https://github.com/apache/wicket/blob/ad6ecac7fdebefc25d310361f3a92aa481c36b1f/wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FileUploadField.java#L50
On Tue, Dec 3, 2019 at 10:56 AM Ernesto Reinaldo Barreiro <
reiern70@gmail.com> wrote:
> Hi,
>
> FileUpload still implements IClusterable but it contains a field of type
> FileItem: which is no longer Serializable. Should IClusterable be dropped?
>
> --
> Regards - Ernesto Reinaldo Barreiro
>
Re: FileUpload class still implements IClusterable
Posted by Ernesto Reinaldo Barreiro <re...@gmail.com>.
Done
On Tue, Dec 3, 2019 at 6:19 PM Martin Grigorov <mg...@apache.org> wrote:
> On Tue, Dec 3, 2019 at 3:42 PM Ernesto Reinaldo Barreiro <
> reiern70@gmail.com>
> wrote:
>
> > Hi Martin,
> >
> >
> > On Tue, Dec 3, 2019 at 3:09 PM Martin Grigorov <mg...@apache.org>
> > wrote:
> >
> > > Hi Ernesto,
> > >
> > > Yes, I think FileUpload should not be Serializable.
> > > FileUploadField uses transient reference to the list of file uploads
> for
> > > this reason:
> > >
> > >
> >
> https://github.com/apache/wicket/blob/ad6ecac7fdebefc25d310361f3a92aa481c36b1f/wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FileUploadField.java#L50
> >
> >
> > Yes I'm aware of this behaviour: I just fixed some related issue in our
> > project and while doing that I noticed mentioned problem? Shall I create
> an
> > issue for this or just a PR?
> >
>
> Issue + commit (you have the permissions).
> But maybe only in Wicket 9.x because otherwise Clirr plugin will complain
> that it is an API break.
>
>
> >
> > --
> > Regards - Ernesto Reinaldo Barreiro
> >
>
--
Regards - Ernesto Reinaldo Barreiro
Re: FileUpload class still implements IClusterable
Posted by Ernesto Reinaldo Barreiro <re...@gmail.com>.
Done
On Tue, Dec 3, 2019 at 6:19 PM Martin Grigorov <mg...@apache.org> wrote:
> On Tue, Dec 3, 2019 at 3:42 PM Ernesto Reinaldo Barreiro <
> reiern70@gmail.com>
> wrote:
>
> > Hi Martin,
> >
> >
> > On Tue, Dec 3, 2019 at 3:09 PM Martin Grigorov <mg...@apache.org>
> > wrote:
> >
> > > Hi Ernesto,
> > >
> > > Yes, I think FileUpload should not be Serializable.
> > > FileUploadField uses transient reference to the list of file uploads
> for
> > > this reason:
> > >
> > >
> >
> https://github.com/apache/wicket/blob/ad6ecac7fdebefc25d310361f3a92aa481c36b1f/wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FileUploadField.java#L50
> >
> >
> > Yes I'm aware of this behaviour: I just fixed some related issue in our
> > project and while doing that I noticed mentioned problem? Shall I create
> an
> > issue for this or just a PR?
> >
>
> Issue + commit (you have the permissions).
> But maybe only in Wicket 9.x because otherwise Clirr plugin will complain
> that it is an API break.
>
>
> >
> > --
> > Regards - Ernesto Reinaldo Barreiro
> >
>
--
Regards - Ernesto Reinaldo Barreiro
Re: FileUpload class still implements IClusterable
Posted by Martin Grigorov <mg...@apache.org>.
On Tue, Dec 3, 2019 at 3:42 PM Ernesto Reinaldo Barreiro <re...@gmail.com>
wrote:
> Hi Martin,
>
>
> On Tue, Dec 3, 2019 at 3:09 PM Martin Grigorov <mg...@apache.org>
> wrote:
>
> > Hi Ernesto,
> >
> > Yes, I think FileUpload should not be Serializable.
> > FileUploadField uses transient reference to the list of file uploads for
> > this reason:
> >
> >
> https://github.com/apache/wicket/blob/ad6ecac7fdebefc25d310361f3a92aa481c36b1f/wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FileUploadField.java#L50
>
>
> Yes I'm aware of this behaviour: I just fixed some related issue in our
> project and while doing that I noticed mentioned problem? Shall I create an
> issue for this or just a PR?
>
Issue + commit (you have the permissions).
But maybe only in Wicket 9.x because otherwise Clirr plugin will complain
that it is an API break.
>
> --
> Regards - Ernesto Reinaldo Barreiro
>
Re: FileUpload class still implements IClusterable
Posted by Martin Grigorov <mg...@apache.org>.
On Tue, Dec 3, 2019 at 3:42 PM Ernesto Reinaldo Barreiro <re...@gmail.com>
wrote:
> Hi Martin,
>
>
> On Tue, Dec 3, 2019 at 3:09 PM Martin Grigorov <mg...@apache.org>
> wrote:
>
> > Hi Ernesto,
> >
> > Yes, I think FileUpload should not be Serializable.
> > FileUploadField uses transient reference to the list of file uploads for
> > this reason:
> >
> >
> https://github.com/apache/wicket/blob/ad6ecac7fdebefc25d310361f3a92aa481c36b1f/wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FileUploadField.java#L50
>
>
> Yes I'm aware of this behaviour: I just fixed some related issue in our
> project and while doing that I noticed mentioned problem? Shall I create an
> issue for this or just a PR?
>
Issue + commit (you have the permissions).
But maybe only in Wicket 9.x because otherwise Clirr plugin will complain
that it is an API break.
>
> --
> Regards - Ernesto Reinaldo Barreiro
>
Re: FileUpload class still implements IClusterable
Posted by Ernesto Reinaldo Barreiro <re...@gmail.com>.
Hi Martin,
On Tue, Dec 3, 2019 at 3:09 PM Martin Grigorov <mg...@apache.org> wrote:
> Hi Ernesto,
>
> Yes, I think FileUpload should not be Serializable.
> FileUploadField uses transient reference to the list of file uploads for
> this reason:
>
> https://github.com/apache/wicket/blob/ad6ecac7fdebefc25d310361f3a92aa481c36b1f/wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FileUploadField.java#L50
Yes I'm aware of this behaviour: I just fixed some related issue in our
project and while doing that I noticed mentioned problem? Shall I create an
issue for this or just a PR?
--
Regards - Ernesto Reinaldo Barreiro
Re: FileUpload class still implements IClusterable
Posted by Ernesto Reinaldo Barreiro <re...@gmail.com>.
Hi Martin,
On Tue, Dec 3, 2019 at 3:09 PM Martin Grigorov <mg...@apache.org> wrote:
> Hi Ernesto,
>
> Yes, I think FileUpload should not be Serializable.
> FileUploadField uses transient reference to the list of file uploads for
> this reason:
>
> https://github.com/apache/wicket/blob/ad6ecac7fdebefc25d310361f3a92aa481c36b1f/wicket-core/src/main/java/org/apache/wicket/markup/html/form/upload/FileUploadField.java#L50
Yes I'm aware of this behaviour: I just fixed some related issue in our
project and while doing that I noticed mentioned problem? Shall I create an
issue for this or just a PR?
--
Regards - Ernesto Reinaldo Barreiro