You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2010/03/01 09:59:15 UTC

[Bug 6356] New: win32: SpamdForkScaling causes spamd to spawn endless number of childs

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6356

           Summary: win32: SpamdForkScaling causes spamd to spawn endless
                    number of childs
           Product: Spamassassin
           Version: 3.3.0
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: major
          Priority: P5
         Component: spamc/spamd
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: lemke@jam-software.com


Due an issue in SpamdForkScaling.pm spamd is running a loop and spawns childs
until reaching its maximum. At this point it hangs up and does not respond
anymore.

It seems as if this is a problem of the template used in unpack. Under win32
you have to use a signed integer template value like 'l' or 'i' to make it work
properly.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6356] [review] win32: SpamdForkScaling causes spamd to spawn endless number of childs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6356

Justin Mason <jm...@jmason.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5                          |P2
            Summary|win32: SpamdForkScaling     |[review] win32:
                   |causes spamd to spawn       |SpamdForkScaling causes
                   |endless number of childs    |spamd to spawn endless
                   |                            |number of childs
  Status Whiteboard|                            |needs 2 votes

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6356] win32: SpamdForkScaling causes spamd to spawn endless number of childs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6356

--- Comment #5 from Justin Mason <jm...@jmason.org> 2010-03-01 17:11:28 UTC ---
Created an attachment (id=4679)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4679)
use 'l' on all platforms

ok, I'm just going to switch it to use 'l' throughout, on UNIX platforms too. 
the protocol is entirely internal, so this is not visible to spamc clients, and
we can change it easily.  

I still think this is a serious perl bug on win32 though.  I recommend
reporting it on perl.org if possible.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6356] [review] win32: SpamdForkScaling causes spamd to spawn endless number of childs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6356

--- Comment #9 from Mark Martinec <Ma...@ijs.si> 2010-03-02 00:01:23 UTC ---
> ok, applied.
> Committed revision 917785.

Please apply to trunk as well.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6356] [review] win32: SpamdForkScaling causes spamd to spawn endless number of childs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6356

Justin Mason <jm...@jmason.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Justin Mason <jm...@jmason.org> 2010-03-01 23:15:30 UTC ---
ok, applied.

: 35...; svn commit -m "bug 6356: work around win32 perl bug with pack('N') by
switching to pack('l')"
Sending        lib/Mail/SpamAssassin/SpamdForkScaling.pm
Transmitting file data .
Committed revision 917785.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6356] win32: SpamdForkScaling causes spamd to spawn endless number of childs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6356

--- Comment #3 from Justin Mason <jm...@jmason.org> 2010-03-01 15:55:42 UTC ---
Is 'n' a viable option?

this is a pretty serious issue in win32 perl, btw, if pack() is broken.  Is
there a bug report on perl.org for it?

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6356] win32: SpamdForkScaling causes spamd to spawn endless number of childs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6356

--- Comment #1 from Daniel <le...@jam-software.com> 2010-03-01 09:27:59 UTC ---
Created an attachment (id=4678)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4678)
spamdforkscaling patch for win32 issues

Does solve an issue where spamd hanged up in a loop.
Tracked down to a problem with the use of unsigned template value in unpack
functions.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6356] win32: SpamdForkScaling causes spamd to spawn endless number of childs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6356

Justin Mason <jm...@jmason.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jm@jmason.org
   Target Milestone|Undefined                   |3.3.1

--- Comment #2 from Justin Mason <jm...@jmason.org> 2010-03-01 11:43:23 UTC ---
aiming at 3.3.1, but most likely this will slip to 3.3.2

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6356] win32: SpamdForkScaling causes spamd to spawn endless number of childs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6356

Daniel <le...@jam-software.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |lemke@jam-software.com

--- Comment #4 from Daniel <le...@jam-software.com> 2010-03-01 16:15:59 UTC ---
No, 'n' leads to the same issue.

The only thing I found on perl.org was this:
http://rt.perl.org/rt3/Public/Bug/Display.html?id=1729

But this whole concept is exceeding my perl knowledge, since I'm doing this
spamd win32 project it's the first time I really have contact with perl (and
open source ;)).

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6356] [review] win32: SpamdForkScaling causes spamd to spawn endless number of childs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6356

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|needs 1 votes               |can be committed

--- Comment #7 from Mark Martinec <Ma...@ijs.si> 2010-03-01 17:35:58 UTC ---
> ok, I'm just going to switch it to use 'l' throughout, on UNIX platforms too. 

+1

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6356] [review] win32: SpamdForkScaling causes spamd to spawn endless number of childs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6356

--- Comment #10 from Justin Mason <jm...@jmason.org> 2010-03-02 10:50:04 UTC ---
(In reply to comment #9)
> > ok, applied.
> > Committed revision 917785.
> 
> Please apply to trunk as well.

good catch, thanks.

Committed revision 917952.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6356] [review] win32: SpamdForkScaling causes spamd to spawn endless number of childs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6356

--- Comment #11 from Daniel <le...@jam-software.com> 2010-03-02 13:36:02 UTC ---
This doesn't seem to be a bug in pack or unpack since the pid of the child
processes is negative under windows.

Due this 'issue' the unsigned template 'N' converts the value in a large
positive integer value. I hope to figure out where this negative values come
from, this may be a more solid fix.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6356] [review] win32: SpamdForkScaling causes spamd to spawn endless number of childs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6356

--- Comment #12 from Justin Mason <jm...@jmason.org> 2010-03-02 13:54:42 UTC ---
(In reply to comment #11)
> This doesn't seem to be a bug in pack or unpack since the pid of the child
> processes is negative under windows.

ahhh, that explains it.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6356] [review] win32: SpamdForkScaling causes spamd to spawn endless number of childs

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6356

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kmcgrail@pccc.com
  Status Whiteboard|needs 2 votes               |needs 1 votes

--- Comment #6 from Kevin A. McGrail <km...@pccc.com> 2010-03-01 17:14:57 UTC ---
KAM +1

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.