You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/01/16 15:28:25 UTC
[GitHub] [pulsar-client-go] wolfstudy opened a new pull request #175: Fix
partition key not set in batch builder
wolfstudy opened a new pull request #175: Fix partition key not set in batch builder
URL: https://github.com/apache/pulsar-client-go/pull/175
Signed-off-by: xiaolong.ran <rx...@apache.org>
### Motivation
Currently, when we specify the `Key` for the message, the broker can not receive the partition key.
### Modifications
- set partition key in BatchBuilder
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy commented on a change in pull request
#175: Fix partition key not set in batch builder
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on a change in pull request #175: Fix partition key not set in batch builder
URL: https://github.com/apache/pulsar-client-go/pull/175#discussion_r367746342
##########
File path: pulsar/consumer_test.go
##########
@@ -280,7 +280,7 @@ func TestConsumerKeyShared(t *testing.T) {
defer producer.Close()
ctx := context.Background()
- for i := 0; i < 10; i++ {
+ for i := 0; i < 100; i++ {
Review comment:
Just to ensure that every consumer receives a message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] merlimat merged pull request #175: Fix partition
key not set in batch builder
Posted by GitBox <gi...@apache.org>.
merlimat merged pull request #175: Fix partition key not set in batch builder
URL: https://github.com/apache/pulsar-client-go/pull/175
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] wolfstudy commented on issue #175: Fix partition
key not set in batch builder
Posted by GitBox <gi...@apache.org>.
wolfstudy commented on issue #175: Fix partition key not set in batch builder
URL: https://github.com/apache/pulsar-client-go/pull/175#issuecomment-575206777
@sijie @merlimat @jiazhai PTAL thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [pulsar-client-go] cckellogg commented on a change in pull request
#175: Fix partition key not set in batch builder
Posted by GitBox <gi...@apache.org>.
cckellogg commented on a change in pull request #175: Fix partition key not set in batch builder
URL: https://github.com/apache/pulsar-client-go/pull/175#discussion_r367560045
##########
File path: pulsar/consumer_test.go
##########
@@ -280,7 +280,7 @@ func TestConsumerKeyShared(t *testing.T) {
defer producer.Close()
ctx := context.Background()
- for i := 0; i < 10; i++ {
+ for i := 0; i < 100; i++ {
Review comment:
What's the purpose of changing this from 10 -> 100?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services