You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/03/25 21:10:26 UTC
[GitHub] [hbase] ndimiduk opened a new pull request #1351: HBASE-24007 Get
`-PrunLargeTests` passing on JDK11
ndimiduk opened a new pull request #1351: HBASE-24007 Get `-PrunLargeTests` passing on JDK11
URL: https://github.com/apache/hbase/pull/1351
Minor tweaks required to get passing runs of `-PrunLargeTests`.
* Minimum Hadoop version is 3.2.0 due to [HADOOP-12760](https://issues.apache.org/jira/browse/HADOOP-12760).
* JDK11 looks like it consumes more memory than JDK8, so failures due to OOME see more common here. Bumping heap allocated to surefire forks allows better pass rate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1351: HBASE-24007 Get
`-PrunLargeTests` passing on JDK11
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on issue #1351: HBASE-24007 Get `-PrunLargeTests` passing on JDK11
URL: https://github.com/apache/hbase/pull/1351#issuecomment-606105322
Thanks @HorizonNet !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1351: HBASE-24007 Get
`-PrunLargeTests` passing on JDK11
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on issue #1351: HBASE-24007 Get `-PrunLargeTests` passing on JDK11
URL: https://github.com/apache/hbase/pull/1351#issuecomment-604133615
`TestVerifyBucketCacheFile` strikes again :'(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] jojochuang commented on issue #1351: HBASE-24007 Get
`-PrunLargeTests` passing on JDK11
Posted by GitBox <gi...@apache.org>.
jojochuang commented on issue #1351: HBASE-24007 Get `-PrunLargeTests` passing on JDK11
URL: https://github.com/apache/hbase/pull/1351#issuecomment-604095131
We've seen performance issue with JDK11 too. They took extra time to run that breaks our internal functional tests. Later we realized it's because JDK11 defaults to G1GC and thus the memory consumption is different/more
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1351: HBASE-24007 Get
`-PrunLargeTests` passing on JDK11
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on issue #1351: HBASE-24007 Get `-PrunLargeTests` passing on JDK11
URL: https://github.com/apache/hbase/pull/1351#issuecomment-605261246
I was asked offline: the dependency on HADOOP-12760 comes from `TestSaslFanOutOneBlockAsyncDFSOutput`, which has been on our flakey exclude list for a while.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1351: HBASE-24007 Get
`-PrunLargeTests` passing on JDK11
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1351: HBASE-24007 Get `-PrunLargeTests` passing on JDK11
URL: https://github.com/apache/hbase/pull/1351#issuecomment-604112045
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 9s | Docker mode activated. |
| -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 6m 29s | master passed |
| +1 :green_heart: | compile | 3m 33s | master passed |
| +1 :green_heart: | shadedjars | 5m 33s | branch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 47s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 53s | the patch passed |
| +1 :green_heart: | compile | 3m 29s | the patch passed |
| +1 :green_heart: | javac | 3m 29s | the patch passed |
| +1 :green_heart: | shadedjars | 5m 32s | patch has no errors when building our shaded downstream artifacts. |
| +1 :green_heart: | javadoc | 2m 47s | the patch passed |
||| _ Other Tests _ |
| -1 :x: | unit | 11m 55s | root in the patch failed. |
| | | 50m 32s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1351/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1351 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 225d91121d52 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 5e63509781 |
| Default Java | 1.8.0_232 |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1351/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1351/1/testReport/ |
| Max. process+thread count | 870 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1351/1/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1351: HBASE-24007 Get
`-PrunLargeTests` passing on JDK11
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1351: HBASE-24007 Get `-PrunLargeTests` passing on JDK11
URL: https://github.com/apache/hbase/pull/1351#issuecomment-604111333
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 40s | Docker mode activated. |
| -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck |
||| _ Prechecks _ |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 8m 58s | master passed |
| +1 :green_heart: | compile | 5m 8s | master passed |
| +1 :green_heart: | shadedjars | 7m 57s | branch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 24s | root in master failed. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 8m 27s | the patch passed |
| +1 :green_heart: | compile | 5m 17s | the patch passed |
| +1 :green_heart: | javac | 5m 17s | the patch passed |
| +1 :green_heart: | shadedjars | 7m 49s | patch has no errors when building our shaded downstream artifacts. |
| -0 :warning: | javadoc | 0m 21s | root in the patch failed. |
||| _ Other Tests _ |
| -0 :warning: | unit | 2m 8s | root in the patch failed. |
| | | 48m 27s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1351/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1351 |
| Optional Tests | javac javadoc unit shadedjars compile |
| uname | Linux 458afc272f14 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 5e63509781 |
| Default Java | 2020-01-14 |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1351/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-root.txt |
| javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1351/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-root.txt |
| unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1351/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-root.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1351/1/testReport/ |
| Max. process+thread count | 487 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1351/1/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1351: HBASE-24007 Get
`-PrunLargeTests` passing on JDK11
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on issue #1351: HBASE-24007 Get `-PrunLargeTests` passing on JDK11
URL: https://github.com/apache/hbase/pull/1351#issuecomment-605263035
Bump review request please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #1351: HBASE-24007 Get
`-PrunLargeTests` passing on JDK11
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #1351: HBASE-24007 Get `-PrunLargeTests` passing on JDK11
URL: https://github.com/apache/hbase/pull/1351#issuecomment-604100869
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 1m 17s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
||| _ master Compile Tests _ |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | xml | 0m 2s | The patch has no ill-formed XML file. |
| +1 :green_heart: | hadoopcheck | 12m 39s | Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2. |
||| _ Other Tests _ |
| +1 :green_heart: | asflicense | 0m 16s | The patch does not generate ASF License warnings. |
| | | 21m 33s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1351/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/1351 |
| Optional Tests | dupname asflicense hadoopcheck xml |
| uname | Linux be55078c58c4 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/hbase-personality.sh |
| git revision | master / 5e63509781 |
| Max. process+thread count | 63 (vs. ulimit of 10000) |
| modules | C: . U: . |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1351/1/console |
| versions | git=2.17.1 maven=2018-06-17T18:33:14Z) |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk merged pull request #1351: HBASE-24007 Get
`-PrunLargeTests` passing on JDK11
Posted by GitBox <gi...@apache.org>.
ndimiduk merged pull request #1351: HBASE-24007 Get `-PrunLargeTests` passing on JDK11
URL: https://github.com/apache/hbase/pull/1351
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] ndimiduk commented on issue #1351: HBASE-24007 Get
`-PrunLargeTests` passing on JDK11
Posted by GitBox <gi...@apache.org>.
ndimiduk commented on issue #1351: HBASE-24007 Get `-PrunLargeTests` passing on JDK11
URL: https://github.com/apache/hbase/pull/1351#issuecomment-604089905
Anyone know of a better way of managing the minimum hadoop version dependency? Some enforcer-plugin foo?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services