[GitHub] [arrow] kou commented on a change in pull request #12382: ARROW-15629: [GLib] Add garrow_string_array_builder_append_string_n()

[GitBox <gi...@apache.org>]

kou commented on a change in pull request #12382:
URL: https://github.com/apache/arrow/pull/12382#discussion_r803116686



##########
File path: c_glib/arrow-glib/array-builder.cpp
##########
@@ -3328,13 +3328,36 @@ gboolean
 garrow_string_array_builder_append_string(GArrowStringArrayBuilder *builder,
                                           const gchar *value,
                                           GError **error)
+{
+  return garrow_string_array_builder_append_string_n(builder,
+                                                     value,
+                                                     static_cast<gint32>(strlen(value)),
+                                                     error);
+}
+
+/**
+ * garrow_string_array_builder_append_string_n:

Review comment:
       Could you use `_len` suffix instead of `_n` suffix because GLib uses `_len` suffix for this case such as `g_string_append_len()` https://docs.gtk.org/glib/method.String.append_len.html ?
   
   ```suggestion
    * garrow_string_array_builder_append_string_len:
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org