[GitHub] [commons-vfs] garydgregory commented on a diff in pull request #284: Fix links in javadoc and documentations

[GitBox <gi...@apache.org>]

garydgregory commented on code in PR #284:
URL: https://github.com/apache/commons-vfs/pull/284#discussion_r934942727


##########
checkstyle.xml:
##########
@@ -26,25 +26,25 @@
   <property name="localeLanguage" value="en" />
 
   <!-- Checks that a package-info.java file exists for each package. -->
-  <!-- See http://checkstyle.sourceforge.net/config_javadoc.html -->
+  <!-- See https://checkstyle.org/config_javadoc.html -->
   <module name="JavadocPackage" />
 
   <!-- Checks whether files end with a new line. -->
-  <!-- See http://checkstyle.sf.net/config_misc.html#NewlineAtEndOfFile -->
+  <!-- See https://checkstyle.org/config_misc.html#NewlineAtEndOfFile -->
   <module name="NewlineAtEndOfFile" />
 
   <!-- Checks that property files contain the same keys. -->
-  <!-- See http://checkstyle.sf.net/config_misc.html#Translation -->
+  <!-- See https://checkstyle.org/config_misc.html#Translation -->
   <module name="Translation" />
 
   <!-- Checks for Tab characters -->
-  <!-- See http://checkstyle.sourceforge.net/config_whitespace.html#FileTabCharacter -->
+  <!-- See https://checkstyle.org/config_whitespace.html#FileTabCharacter -->
   <module name="FileTabCharacter">
     <property name="fileExtensions" value="java" />
   </module>
 
   <!-- Checks for white space at the end of the line -->
-  <!-- See http://checkstyle.sourceforge.net/config_regexp.html -->
+  <!-- See https://checkstyle.org/config_regexp.html -->

Review Comment:
   Probably https://checkstyle.org/config_regexp.html#RegexpSingleline ?



##########
src/site/xdoc/index.xml:
##########
@@ -148,9 +148,9 @@
             methods for provider interfaces (like <code>FileObject</code>). If you implement a VFS provider and use the
             corresponding <code>Abstract*</code> or <code>Default*</code> classes, there should be no need to modify
             the code or recompile the provider. The TarFileProvider is one known exception to compatibility with 2.0.
-            See the <a href="https://dist.apache.org/repos/dist/dev/commons/vfs/RELEASE-NOTES.txt">Release Notes</a> and the
-            <a href="commons-vfs2/clirr-report.html">Clirr Report</a> for details. VFS 2.1 adds a new read-only provider
-            for the Apache Hadoop (HDFS) File system.
+            See the <a href="https://gitbox.apache.org/repos/asf?p=commons-vfs.git;a=blob_plain;f=RELEASE-NOTES.txt;hb=HEAD">

Review Comment:
   -1: Please Use https://dist.apache.org/repos/dist/release/commons/vfs/RELEASE-NOTES.txt
   



##########
checkstyle.xml:
##########
@@ -68,7 +68,7 @@
   </module>
 
   <!-- Checks for Size Violations. -->
-  <!-- See http://checkstyle.sf.net/config_sizes.html -->
+  <!-- See https://checkstyle.org/config_sizes.html -->

Review Comment:
   https://checkstyle.org/config_sizes.html#LineLength



##########
checkstyle.xml:
##########
@@ -26,25 +26,25 @@
   <property name="localeLanguage" value="en" />
 
   <!-- Checks that a package-info.java file exists for each package. -->
-  <!-- See http://checkstyle.sourceforge.net/config_javadoc.html -->
+  <!-- See https://checkstyle.org/config_javadoc.html -->

Review Comment:
   Do you mean https://checkstyle.org/config_javadoc.html#JavadocPackage ?



##########
checkstyle.xml:
##########
@@ -100,7 +100,7 @@
     </module>
 
     <!-- Checks for Naming Conventions. -->
-    <!-- See http://checkstyle.sf.net/config_naming.html -->
+    <!-- See https://checkstyle.org/config_naming.html -->

Review Comment:
   https://checkstyle.org/config_naming.html#ConstantName ?



##########
checkstyle.xml:
##########
@@ -81,13 +81,13 @@
   <module name="TreeWalker">
 
     <!-- Checks for Javadoc comments. -->
-    <!-- See http://checkstyle.sf.net/config_javadoc.html -->
+    <!-- See https://checkstyle.org/config_javadoc.html -->

Review Comment:
   https://checkstyle.org/config_javadoc.html#JavadocMethod



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org