You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jay Guo <gu...@gmail.com> on 2017/03/15 03:27:09 UTC
Review Request 57631: Augmented a test to check
protobuf::stripAllocationInfo.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57631/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-7048
https://issues.apache.org/jira/browse/MESOS-7048
Repository: mesos
Description
-------
An unit test is augmented to check both injectAllocationInfo and
stripAllocationInfo.
Diffs
-----
src/tests/protobuf_utils_tests.cpp 2c32d56e41d12a26824aaf22ef78f8c0048acc00
Diff: https://reviews.apache.org/r/57631/diff/1/
Testing
-------
make check
Thanks,
Jay Guo
Re: Review Request 57631: Augmented a test to check
protobuf::stripAllocationInfo.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57631/#review169210
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On March 15, 2017, 3:27 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57631/
> -----------------------------------------------------------
>
> (Updated March 15, 2017, 3:27 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7048
> https://issues.apache.org/jira/browse/MESOS-7048
>
>
> Repository: mesos
>
>
> Description
> -------
>
> An unit test is augmented to check both injectAllocationInfo and
> stripAllocationInfo.
>
>
> Diffs
> -----
>
> src/tests/protobuf_utils_tests.cpp 2c32d56e41d12a26824aaf22ef78f8c0048acc00
>
>
> Diff: https://reviews.apache.org/r/57631/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jay Guo
>
>
Re: Review Request 57631: Augmented a test to check
protobuf::stripAllocationInfo.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57631/#review169014
-----------------------------------------------------------
Patch looks great!
Reviews applied: [57340, 57630, 57631]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 15, 2017, 3:27 a.m., Jay Guo wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57631/
> -----------------------------------------------------------
>
> (Updated March 15, 2017, 3:27 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-7048
> https://issues.apache.org/jira/browse/MESOS-7048
>
>
> Repository: mesos
>
>
> Description
> -------
>
> An unit test is augmented to check both injectAllocationInfo and
> stripAllocationInfo.
>
>
> Diffs
> -----
>
> src/tests/protobuf_utils_tests.cpp 2c32d56e41d12a26824aaf22ef78f8c0048acc00
>
>
> Diff: https://reviews.apache.org/r/57631/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jay Guo
>
>