You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by Igor Galić <i....@brainsware.org> on 2012/01/27 10:11:16 UTC
Re: svn commit: r1236540 - /trafficserver/traffic/trunk/lib/records/RecHttp.cc
----- Original Message -----
> Author: amc
> Date: Fri Jan 27 06:17:27 2012
> New Revision: 1236540
>
> URL: http://svn.apache.org/viewvc?rev=1236540&view=rev
> Log:
> TS-1077 Solaris fix.
>
> Modified:
> trafficserver/traffic/trunk/lib/records/RecHttp.cc
>
> Modified: trafficserver/traffic/trunk/lib/records/RecHttp.cc
> URL:
> http://svn.apache.org/viewvc/trafficserver/traffic/trunk/lib/records/RecHttp.cc?rev=1236540&r1=1236539&r2=1236540&view=diff
> ==============================================================================
> --- trafficserver/traffic/trunk/lib/records/RecHttp.cc (original)
> +++ trafficserver/traffic/trunk/lib/records/RecHttp.cc Fri Jan 27
> 06:17:27 2012
> @@ -122,7 +122,7 @@ HttpProxyPort::loadConfig(Vec<self>& ent
> if (-1 == sp) {
> // Default value, ignore.
> } else if (0 < sp && sp < 65536) {
> - char buff[6 + 1 + strlen(attr) + 1];
> + char* buff = static_cast<char*>(alloca(6 + 1 + strlen(attr) +
> 1));
https://cwiki.apache.org/confluence/display/TS/Coding+Style
shouldn't this be
char *buff = ...;
> sprintf(buff, "%d:%s", sp, attr);
> self::loadValue(entries, buff);
> } else {
>
>
>
--
Igor Galić
Tel: +43 (0) 664 886 22 883
Mail: i.galic@brainsware.org
URL: http://brainsware.org/
GPG: 6880 4155 74BD FD7C B515 2EA5 4B1D 9E08 A097 C9AE
Re: svn commit: r1236540 - /trafficserver/traffic/trunk/lib/records/RecHttp.cc
Posted by "Alan M. Carroll" <am...@network-geographics.com>.
Probably, although I see "char * buff" style quite a bit. That's going to be a hard one to overcome.
Friday, January 27, 2012, 3:11:16 AM, you wrote:
>> + char* buff = static_cast<char*>(alloca(6 + 1 + strlen(attr) +
>> 1));
> https://cwiki.apache.org/confluence/display/TS/Coding+Style
> shouldn't this be
> char *buff = ...;