You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2018/09/03 01:16:21 UTC

[GitHub] spark pull request #22063: [WIP][SPARK-25044][SQL] Address translation of LM...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22063#discussion_r214560313
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/expressions/UserDefinedFunction.scala ---
    @@ -40,7 +41,7 @@ import org.apache.spark.sql.types.DataType
     case class UserDefinedFunction protected[sql] (
         f: AnyRef,
         dataType: DataType,
    -    inputTypes: Option[Seq[DataType]]) {
    +    inputTypes: Option[Seq[ScalaReflection.Schema]]) {
    --- End diff --
    
    This is a stable API. Are we able to make this change in 2.4 instead of 3.0?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org