[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #791: Use PutVarInt instead of PutFixed while encoding stream entry value

[GitBox <gi...@apache.org>]

PragmaTwice commented on PR #791:
URL: https://github.com/apache/incubator-kvrocks/pull/791#issuecomment-1228518603

   > @git-hulk BTW, after reverting snappy version I have Cmake error on Fedora 35
   > 
   > ```
   > CMake Error at /usr/lib64/cmake/GTest/GTestTargets.cmake:37 (message):
   >   Some (but not all) targets in this export set were already defined.
   > 
   >   Targets Defined: GTest::gtest;GTest::gtest_main
   > 
   >   Targets not yet defined: GTest::gmock;GTest::gmock_main
   > 
   > Call Stack (most recent call first):
   >   /usr/lib64/cmake/GTest/GTestConfig.cmake:42 (include)
   >   /usr/share/cmake/Modules/FindGTest.cmake:187 (find_package)
   >   build/_deps/snappy-src/CMakeLists.txt:40 (find_package)
   > ```
   > 
   > However, I see that all builds you have in your CI are successful.
   
   There are some cmake changes from Snappy 1.1.7 to 1.1.9, `find_package(gtest)` always exists in 1.1.7 regardless of `SNAPPY_BUILD_TESTS` being set to `OFF`.
   
   Could you open an issue for this? I will fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org