You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/09/21 15:34:40 UTC

[GitHub] [sling-org-apache-sling-testing-clients] kwin commented on a change in pull request #18: SLING-9750 Fix read string as integer issue

kwin commented on a change in pull request #18:
URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/18#discussion_r492156751



##########
File path: src/main/java/org/apache/sling/testing/clients/osgi/ServiceInfo.java
##########
@@ -41,7 +41,7 @@ public ServiceInfo(JsonNode root) throws ClientException {
      * @return the service identifier
      */
     public int getId() {
-        return service.get("id").getIntValue();

Review comment:
       LGTM but a test would be nice for that.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org