You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/09/03 22:35:44 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8138:
[typing] add typing for superset/connectors and superset/common
codecov-io edited a comment on issue #8138: [typing] add typing for superset/connectors and superset/common
URL: https://github.com/apache/incubator-superset/pull/8138#issuecomment-525919765
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr&el=h1) Report
> Merging [#8138](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/6aa10dc016455728c7da4dfabd849c59dc9f7f66?src=pr&el=desc) will **decrease** coverage by `7.36%`.
> The diff coverage is `93.13%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8138/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8138 +/- ##
==========================================
- Coverage 73.71% 66.34% -7.37%
==========================================
Files 115 479 +364
Lines 12059 23033 +10974
Branches 0 2524 +2524
==========================================
+ Hits 8889 15282 +6393
- Misses 3170 7617 +4447
- Partials 0 134 +134
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/common/query\_object.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `50% <80%> (+22.22%)` | :arrow_up: |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | `25.95% <85%> (+4.35%)` | :arrow_up: |
| [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `86.36% <85.71%> (-1.52%)` | :arrow_down: |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `90.47% <94.87%> (+0.42%)` | :arrow_up: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.31% <96.29%> (+0.65%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `85.08% <98.14%> (+0.7%)` | :arrow_up: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.27% <0%> (ø)` | :arrow_up: |
| [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | `100% <0%> (ø)` | |
| [...ations/deckgl/layers/Polygon/PolygonChartPlugin.js](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy92aXN1YWxpemF0aW9ucy9kZWNrZ2wvbGF5ZXJzL1BvbHlnb24vUG9seWdvbkNoYXJ0UGx1Z2luLmpz) | `0% <0%> (ø)` | |
| [.../assets/src/dashboard/reducers/dashboardFilters.js](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGFzaGJvYXJkRmlsdGVycy5qcw==) | `88.23% <0%> (ø)` | |
| ... and [363 more](https://codecov.io/gh/apache/incubator-superset/pull/8138/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr&el=footer). Last update [6aa10dc...a44502a](https://codecov.io/gh/apache/incubator-superset/pull/8138?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org