You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Nitin Galave <ni...@gmail.com> on 2021/06/07 13:21:13 UTC
Re: Review Request 73406: RANGER-3306 : Allow comma in policy
resource text field.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73406/
-----------------------------------------------------------
(Updated June 7, 2021, 1:21 p.m.)
Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, Jayendra Parab, Kishor Gollapalliwar, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
Bugs: RANGER-3306
https://issues.apache.org/jira/browse/RANGER-3306
Repository: ranger
Description
-------
At policy creation time, When the user enters a comma in the resource field. it creates a separate tag.
it is good if we add a comma in between the string.
Diffs (updated)
-----
security-admin/src/main/webapp/libs/bower/tag-it/js/tag-it.js 04e36b129
security-admin/src/main/webapp/scripts/Init.js aa970be99
security-admin/src/main/webapp/scripts/modules/XAOverrides.js 1c4e457ed
security-admin/src/main/webapp/scripts/utils/XAUtils.js b90f885d8
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js b52579af8
security-admin/src/main/webapp/scripts/views/security_zone/ZoneResourceForm.js f87e7a0c0
security-admin/src/main/webapp/scripts/views/security_zone/zoneResource.js 7634eab02
security-admin/src/main/webapp/scripts/views/service/AuditFilterConfig.js 2032da1f0
security-admin/src/main/webapp/scripts/views/service/ServiceAuditFilterResources.js c08f74574
security-admin/src/main/webapp/styles/xa.css 9762a3b75
Diff: https://reviews.apache.org/r/73406/diff/2/
Changes: https://reviews.apache.org/r/73406/diff/1-2/
Testing
-------
Tested for various input combinations in Resources fields with comma variations. Resources fields from Access Manager, Tag Policy, Audit Filters and Security Zones were tested with these input combinations. The fields were tested in both Old UI as well as new UI.
Thanks,
Nitin Galave
Re: Review Request 73406: RANGER-3306 : Allow comma in policy
resource text field.
Posted by Mehul Parikh <xs...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73406/#review223116
-----------------------------------------------------------
Ship it!
Ship It!
- Mehul Parikh
On June 7, 2021, 1:21 p.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73406/
> -----------------------------------------------------------
>
> (Updated June 7, 2021, 1:21 p.m.)
>
>
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, Jayendra Parab, Kishor Gollapalliwar, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3306
> https://issues.apache.org/jira/browse/RANGER-3306
>
>
> Repository: ranger
>
>
> Description
> -------
>
> At policy creation time, When the user enters a comma in the resource field. it creates a separate tag.
> it is good if we add a comma in between the string.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/libs/bower/tag-it/js/tag-it.js 04e36b129
> security-admin/src/main/webapp/scripts/Init.js aa970be99
> security-admin/src/main/webapp/scripts/modules/XAOverrides.js 1c4e457ed
> security-admin/src/main/webapp/scripts/utils/XAUtils.js b90f885d8
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js b52579af8
> security-admin/src/main/webapp/scripts/views/security_zone/ZoneResourceForm.js f87e7a0c0
> security-admin/src/main/webapp/scripts/views/security_zone/zoneResource.js 7634eab02
> security-admin/src/main/webapp/scripts/views/service/AuditFilterConfig.js 2032da1f0
> security-admin/src/main/webapp/scripts/views/service/ServiceAuditFilterResources.js c08f74574
> security-admin/src/main/webapp/styles/xa.css 9762a3b75
>
>
> Diff: https://reviews.apache.org/r/73406/diff/2/
>
>
> Testing
> -------
>
> Tested for various input combinations in Resources fields with comma variations. Resources fields from Access Manager, Tag Policy, Audit Filters and Security Zones were tested with these input combinations. The fields were tested in both Old UI as well as new UI.
>
>
> Thanks,
>
> Nitin Galave
>
>
Re: Review Request 73406: RANGER-3306 : Allow comma in policy
resource text field.
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73406/#review223117
-----------------------------------------------------------
Ship it!
Ship It!
- Pradeep Agrawal
On June 7, 2021, 1:21 p.m., Nitin Galave wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73406/
> -----------------------------------------------------------
>
> (Updated June 7, 2021, 1:21 p.m.)
>
>
> Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, Jayendra Parab, Kishor Gollapalliwar, Madhan Neethiraj, Mahesh Bandal, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3306
> https://issues.apache.org/jira/browse/RANGER-3306
>
>
> Repository: ranger
>
>
> Description
> -------
>
> At policy creation time, When the user enters a comma in the resource field. it creates a separate tag.
> it is good if we add a comma in between the string.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/libs/bower/tag-it/js/tag-it.js 04e36b129
> security-admin/src/main/webapp/scripts/Init.js aa970be99
> security-admin/src/main/webapp/scripts/modules/XAOverrides.js 1c4e457ed
> security-admin/src/main/webapp/scripts/utils/XAUtils.js b90f885d8
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js b52579af8
> security-admin/src/main/webapp/scripts/views/security_zone/ZoneResourceForm.js f87e7a0c0
> security-admin/src/main/webapp/scripts/views/security_zone/zoneResource.js 7634eab02
> security-admin/src/main/webapp/scripts/views/service/AuditFilterConfig.js 2032da1f0
> security-admin/src/main/webapp/scripts/views/service/ServiceAuditFilterResources.js c08f74574
> security-admin/src/main/webapp/styles/xa.css 9762a3b75
>
>
> Diff: https://reviews.apache.org/r/73406/diff/2/
>
>
> Testing
> -------
>
> Tested for various input combinations in Resources fields with comma variations. Resources fields from Access Manager, Tag Policy, Audit Filters and Security Zones were tested with these input combinations. The fields were tested in both Old UI as well as new UI.
>
>
> Thanks,
>
> Nitin Galave
>
>