You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2016/04/06 13:09:51 UTC
[GitHub] cordova-ios pull request: CB-11019 Handle app name change more acc...
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-ios/pull/213
CB-11019 Handle app name change more accurately
This PR fixes potential bug in 'prepare' functionality, when changing application name (which assumes renaming of some folders inside of platform directory) does not update project's directories locations properly. Also, the `projectFile` cache needs to be invalidated because it could contain instance that refers the old paths.
See [CB-11019](https://issues.apache.org/jira/browse/CB-11019) for more details
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-ios CB-11019
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/213.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #213
----
commit 070ef3b0dd145780d639a16dfca21ce0a503706a
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2016-04-05T14:41:10Z
CB-11019 Handle changes of app name gracefully
commit f71dbc3726b6ddabaa7330e61f56e766d7f5aa22
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2016-04-06T10:28:39Z
CB-11019 Update tests to validate project name updates
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-11019 Handle app name change more acc...
Posted by sgrebnov <gi...@git.apache.org>.
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-ios/pull/213#issuecomment-211430445
:+1: lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-11019 Handle app name change more acc...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov closed the pull request at:
https://github.com/apache/cordova-ios/pull/213
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org