You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2016/04/15 03:17:53 UTC
Review Request 46242: Removed a check in Reserve operation validation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46242/
-----------------------------------------------------------
Review request for mesos, Adam B and Joris Van Remoortere.
Repository: mesos
Description
-------
When a dynamic reservation is made by an operator
or framework with no principal, this patch removes
the check which enforced that the principal in
ReservationInfo must be None() in that case.
Diffs
-----
src/master/validation.cpp 13423436a4e6361fde6fa75133eebf5c02c8381f
src/tests/master_validation_tests.cpp 8a5bf9477596f13b2fb3a1348337ad2fe53a034d
src/tests/reservation_endpoints_tests.cpp f014290ed9f279df4c774aeb7ce7bd38fd1cc854
Diff: https://reviews.apache.org/r/46242/diff/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 46242: Removed a check in Reserve operation
validation.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46242/#review129059
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46242]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 15, 2016, 1:23 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46242/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 1:23 a.m.)
>
>
> Review request for mesos, Adam B and Joris Van Remoortere.
>
>
> Bugs: MESOS-5212
> https://issues.apache.org/jira/browse/MESOS-5212
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When a dynamic reservation is made by an operator
> or framework with no principal, this patch removes
> the check which enforced that the principal in
> ReservationInfo must be None() in that case.
>
>
> Diffs
> -----
>
> src/master/validation.cpp 13423436a4e6361fde6fa75133eebf5c02c8381f
> src/tests/master_validation_tests.cpp 8a5bf9477596f13b2fb3a1348337ad2fe53a034d
> src/tests/reservation_endpoints_tests.cpp f014290ed9f279df4c774aeb7ce7bd38fd1cc854
>
> Diff: https://reviews.apache.org/r/46242/diff/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 46242: Removed a check in Reserve operation
validation.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46242/#review129082
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46242]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 15, 2016, 6:25 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46242/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 6:25 a.m.)
>
>
> Review request for mesos, Adam B and Joris Van Remoortere.
>
>
> Bugs: MESOS-5212
> https://issues.apache.org/jira/browse/MESOS-5212
>
>
> Repository: mesos
>
>
> Description
> -------
>
> When a dynamic reservation is made by an operator
> or framework with no principal, this patch removes
> the check which enforced that the principal in
> ReservationInfo must be None() in that case.
>
>
> Diffs
> -----
>
> src/master/validation.cpp 13423436a4e6361fde6fa75133eebf5c02c8381f
> src/tests/master_validation_tests.cpp 8a5bf9477596f13b2fb3a1348337ad2fe53a034d
> src/tests/reservation_endpoints_tests.cpp f014290ed9f279df4c774aeb7ce7bd38fd1cc854
>
> Diff: https://reviews.apache.org/r/46242/diff/
>
>
> Testing
> -------
>
> `sudo make check`
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 46242: Removed a check in Reserve operation
validation.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46242/
-----------------------------------------------------------
(Updated April 15, 2016, 6:25 a.m.)
Review request for mesos, Adam B and Joris Van Remoortere.
Bugs: MESOS-5212
https://issues.apache.org/jira/browse/MESOS-5212
Repository: mesos
Description
-------
When a dynamic reservation is made by an operator
or framework with no principal, this patch removes
the check which enforced that the principal in
ReservationInfo must be None() in that case.
Diffs (updated)
-----
src/master/validation.cpp 13423436a4e6361fde6fa75133eebf5c02c8381f
src/tests/master_validation_tests.cpp 8a5bf9477596f13b2fb3a1348337ad2fe53a034d
src/tests/reservation_endpoints_tests.cpp f014290ed9f279df4c774aeb7ce7bd38fd1cc854
Diff: https://reviews.apache.org/r/46242/diff/
Testing
-------
`sudo make check`
Thanks,
Greg Mann
Re: Review Request 46242: Removed a check in Reserve operation
validation.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46242/
-----------------------------------------------------------
(Updated April 15, 2016, 1:23 a.m.)
Review request for mesos, Adam B and Joris Van Remoortere.
Bugs: MESOS-5212
https://issues.apache.org/jira/browse/MESOS-5212
Repository: mesos
Description
-------
When a dynamic reservation is made by an operator
or framework with no principal, this patch removes
the check which enforced that the principal in
ReservationInfo must be None() in that case.
Diffs
-----
src/master/validation.cpp 13423436a4e6361fde6fa75133eebf5c02c8381f
src/tests/master_validation_tests.cpp 8a5bf9477596f13b2fb3a1348337ad2fe53a034d
src/tests/reservation_endpoints_tests.cpp f014290ed9f279df4c774aeb7ce7bd38fd1cc854
Diff: https://reviews.apache.org/r/46242/diff/
Testing
-------
`sudo make check`
Thanks,
Greg Mann