You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2021/03/18 12:00:11 UTC

[GitHub] [avro] mitjap opened a new pull request #1145: [AVRO-3087] fix c++ build if snappy is not found

mitjap opened a new pull request #1145:
URL: https://github.com/apache/avro/pull/1145


   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
     - https://issues.apache.org/jira/browse/AVRO-XXX
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   By being able to build is a test
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   I made commit before creating a JIRA issue
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] thiru-mg commented on pull request #1145: [AVRO-3087] fix c++ build if snappy is not found

Posted by GitBox <gi...@apache.org>.
thiru-mg commented on pull request #1145:
URL: https://github.com/apache/avro/pull/1145#issuecomment-803917915


   Merging the PR hoping that the lint issue will go away now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] thiru-mg commented on pull request #1145: [AVRO-3087] fix c++ build if snappy is not found

Posted by GitBox <gi...@apache.org>.
thiru-mg commented on pull request #1145:
URL: https://github.com/apache/avro/pull/1145#issuecomment-803607955


   Looks good to me. Will merge when the C++ lint issue is resolved: [AVRO-3070](https://issues.apache.org/jira/browse/AVRO-3070)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] thiru-mg merged pull request #1145: [AVRO-3087] fix c++ build if snappy is not found

Posted by GitBox <gi...@apache.org>.
thiru-mg merged pull request #1145:
URL: https://github.com/apache/avro/pull/1145


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [avro] mitjap commented on pull request #1145: [AVRO-3087] fix c++ build if snappy is not found

Posted by GitBox <gi...@apache.org>.
mitjap commented on pull request #1145:
URL: https://github.com/apache/avro/pull/1145#issuecomment-802794611


   I changed commit message to adhere to guidelines.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org