You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2013/11/19 01:06:12 UTC

Review Request 15660: [OOZIE-1615] shell action cannot find script file and fails in uber mode

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15660/
-----------------------------------------------------------

Review request for oozie.


Bugs: OOZIE-1615
    https://issues.apache.org/jira/browse/OOZIE-1615


Repository: oozie


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1615

reason is, PATH doesn't include current directory in Uberized launcher. currently shell action simply execute exec file name like "script.sh", hitting 'No such file or directory'
solution is to use absolute path of exec file


Diffs
-----

  trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java 1543216 

Diff: https://reviews.apache.org/r/15660/diff/


Testing
-------

tested sample workflows (including shell action) with uber on/off using Hadoop hadoop-2.2.1 cluster, made sure both work.


Thanks,

Ryota Egashira


Re: Review Request 15660: [OOZIE-1615] shell action cannot find script file and fails in uber mode

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15660/#review29383
-----------------------------------------------------------

Ship it!


Ship It!

- Rohini Palaniswamy


On Nov. 25, 2013, 6:32 p.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15660/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2013, 6:32 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1615
>     https://issues.apache.org/jira/browse/OOZIE-1615
> 
> 
> Repository: oozie
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1615
> 
> reason is, PATH doesn't include current directory in Uberized launcher. 
> root cause is yarn.app.mapreduce.am.env does not include PATH=.:$PATH
> shellAction set mapred.child.env PATH=.:$PATH, but in uber mode, it was not properly copied to yarn.app.mapreduce.am.env
> 
> 
> Diffs
> -----
> 
>   trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1545347 
>   trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1545347 
> 
> Diff: https://reviews.apache.org/r/15660/diff/
> 
> 
> Testing
> -------
> 
> tested sample workflows (including shell action) with uber on/off using Hadoop hadoop-2.2.1 cluster, made sure both work.
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>


Re: Review Request 15660: [OOZIE-1615] shell action cannot find script file and fails in uber mode

Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15660/
-----------------------------------------------------------

(Updated Nov. 25, 2013, 6:32 p.m.)


Review request for oozie.


Bugs: OOZIE-1615
    https://issues.apache.org/jira/browse/OOZIE-1615


Repository: oozie


Description (updated)
-------

https://issues.apache.org/jira/browse/OOZIE-1615

reason is, PATH doesn't include current directory in Uberized launcher. 
root cause is yarn.app.mapreduce.am.env does not include PATH=.:$PATH
shellAction set mapred.child.env PATH=.:$PATH, but in uber mode, it was not properly copied to yarn.app.mapreduce.am.env


Diffs
-----

  trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1545347 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1545347 

Diff: https://reviews.apache.org/r/15660/diff/


Testing
-------

tested sample workflows (including shell action) with uber on/off using Hadoop hadoop-2.2.1 cluster, made sure both work.


Thanks,

Ryota Egashira


Re: Review Request 15660: [OOZIE-1615] shell action cannot find script file and fails in uber mode

Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15660/
-----------------------------------------------------------

(Updated Nov. 25, 2013, 6:29 p.m.)


Review request for oozie.


Changes
-------

root cause is yarn.app.mapreduce.am.env does not include PATH=./$PATH. 
shellAction set mapred.child.env=PATH./$PATH, but in uber mode, it was not properly copied to yarn.app.mapreduce.am.env


Bugs: OOZIE-1615
    https://issues.apache.org/jira/browse/OOZIE-1615


Repository: oozie


Description
-------

https://issues.apache.org/jira/browse/OOZIE-1615

reason is, PATH doesn't include current directory in Uberized launcher. currently shell action simply execute exec file name like "script.sh", hitting 'No such file or directory'
solution is to use absolute path of exec file


Diffs (updated)
-----

  trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1545347 
  trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1545347 

Diff: https://reviews.apache.org/r/15660/diff/


Testing
-------

tested sample workflows (including shell action) with uber on/off using Hadoop hadoop-2.2.1 cluster, made sure both work.


Thanks,

Ryota Egashira


Re: Review Request 15660: [OOZIE-1615] shell action cannot find script file and fails in uber mode

Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15660/#review29120
-----------------------------------------------------------

Ship it!


Ship It!

- Rohini Palaniswamy


On Nov. 19, 2013, 12:06 a.m., Ryota Egashira wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15660/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2013, 12:06 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1615
>     https://issues.apache.org/jira/browse/OOZIE-1615
> 
> 
> Repository: oozie
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/OOZIE-1615
> 
> reason is, PATH doesn't include current directory in Uberized launcher. currently shell action simply execute exec file name like "script.sh", hitting 'No such file or directory'
> solution is to use absolute path of exec file
> 
> 
> Diffs
> -----
> 
>   trunk/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java 1543216 
> 
> Diff: https://reviews.apache.org/r/15660/diff/
> 
> 
> Testing
> -------
> 
> tested sample workflows (including shell action) with uber on/off using Hadoop hadoop-2.2.1 cluster, made sure both work.
> 
> 
> Thanks,
> 
> Ryota Egashira
> 
>