You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by "Shanedell (via GitHub)" <gi...@apache.org> on 2023/05/02 15:45:37 UTC
[GitHub] [daffodil-vscode] Shanedell opened a new pull request, #611: Update LICENSE, NONOTICE, and NOTICE files.
Shanedell opened a new pull request, #611:
URL: https://github.com/apache/daffodil-vscode/pull/611
Update LICENSE, NONOTICE, and NOTICE files.
- Move build/extension.webpack.config.js from build LICENSE to root LICENSE.
- Remove non production dependencies.
- Add missing production dependencies.
- Update references to omega-edit-grpc-server-*.zip to be node_modules/@omega-edit/server/lib.
- Remove akka references and add references to Apache Pekko
Closes #600
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on pull request #611: Update LICENSE, NONOTICE, and NOTICE files.
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on PR #611:
URL: https://github.com/apache/daffodil-vscode/pull/611#issuecomment-1533370423
> Update LICENSE, NONOTICE, and NOTICE files.
>
> * Move build/extension.webpack.config.js from build LICENSE to root LICENSE.
> * Remove non production dependencies.
> * Add missing production dependencies.
> * Update references to omega-edit-grpc-server-*.zip to be node_modules/@omega-edit/server/lib.
> * Remove akka references and add references to Apache Pekko
>
> Closes #600
@Shanedell, when you say "production" dependencies, do you mean _runtime_ dependencies (these are distinct from _development_ dependencies like compilers, packers, linters, formatters, transpilers, etc.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on pull request #611: Update LICENSE, NONOTICE, and NOTICE files.
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on PR #611:
URL: https://github.com/apache/daffodil-vscode/pull/611#issuecomment-1533086712
Thanks for doing this, I know how much of a pain it can be. Found a handful of minor things when looking through the changes:
**fsevents@2.3.2** - listed as a production dependency, but not listed in LICENSE, NONOTICE, or NOTICE
**long@4.0.0** - listed in NONOTICE, but is MIT so should be in LICENSE
**yargs@16.2.0** - listed as a production dependency, but not listed in LICENSE, NONOTICE, or NOTICE
**org.typelevel.simulacrum-scalafix-annotations** - listed in LICENSE, but jar is not in the .vsix file
**com.github.jnr.jnr-x86asm** - listed in LICENSE and NONOTICE, but it is MIT so should not be in NONOTICE
**com.google.code.gson.gson-2.9.0.jar** - listed in NONOTICE only for daffodil-debugger but not omega-edit
**com.monovore.decline_2.13-2.4.1.jar** - listed in NONOTICE only for daffodil-debugger but not omega-edit
**com.typesafe.config-1.4.2.jar** - listed in NONOTICE only for daffodil-debugger but not omega-edit
**org.slf4j.slf4j-api-2.0.4.jar** - listed in LICENSE only for daffodil-debugger but not omega-edit
**io.grpc.grpc-protobuf-1.48.1.jar** - not listed in LICENSE, NONOTICE, or NOTICE
**io.grpc.grpc-protobuf-lite-1.48.1.jar** - not listed in LICENSE, NONOTICE, or NOTICE
Note that I don't mind if we only list things once if they are in both daffodil-debugger and omega-edit, but we should be consistent. In some places we list it twice and mention both daffodil-debugger and omega-edit, some places we only list it for daffodil-debugger.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #611: Update LICENSE, NONOTICE, and NOTICE files.
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on code in PR #611:
URL: https://github.com/apache/daffodil-vscode/pull/611#discussion_r1183844747
##########
build/package/LICENSE:
##########
@@ -473,6 +453,108 @@ conditions of the following licenses.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+- 'event-target-shim' in extension/dist/ext/extension.js
+ This product bundles 'event-target-shim' from the above files.
+ This package is available under the MIT License:
+ The MIT License (MIT)
+
+ Copyright (c) 2015 Toru Nagashima
+
+ Permission is hereby granted, free of charge, to any person obtaining a copy
+ of this software and associated documentation files (the "Software"), to deal
+ in the Software without restriction, including without limitation the rights
+ to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ copies of the Software, and to permit persons to whom the Software is
+ furnished to do so, subject to the following conditions:
+
+ The above copyright notice and this permission notice shall be included in all
+ copies or substantial portions of the Software.
+
+ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ SOFTWARE.
+
+- 'events' in extension/dist/ext/extension.js
+ This product bundles 'events' from the above files.
+ This package is available under the MIT License:
+ MIT
+
+ Copyright Joyent, Inc. and other Node contributors.
+
+ Permission is hereby granted, free of charge, to any person obtaining a
+ copy of this software and associated documentation files (the
+ "Software"), to deal in the Software without restriction, including
+ without limitation the rights to use, copy, modify, merge, publish,
+ distribute, sublicense, and/or sell copies of the Software, and to permit
+ persons to whom the Software is furnished to do so, subject to the
+ following conditions:
+
+ The above copyright notice and this permission notice shall be included
+ in all copies or substantial portions of the Software.
+
+ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+ OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+ MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
+ NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+ DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+ OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
+ USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+- 'fast-redact' n extension/dist/ext/extension.js
Review Comment:
Typo should be `in`
##########
build/package/LICENSE:
##########
@@ -473,6 +453,108 @@ conditions of the following licenses.
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+- 'event-target-shim' in extension/dist/ext/extension.js
+ This product bundles 'event-target-shim' from the above files.
+ This package is available under the MIT License:
+ The MIT License (MIT)
+
+ Copyright (c) 2015 Toru Nagashima
+
+ Permission is hereby granted, free of charge, to any person obtaining a copy
+ of this software and associated documentation files (the "Software"), to deal
+ in the Software without restriction, including without limitation the rights
+ to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ copies of the Software, and to permit persons to whom the Software is
+ furnished to do so, subject to the following conditions:
+
+ The above copyright notice and this permission notice shall be included in all
+ copies or substantial portions of the Software.
+
+ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ SOFTWARE.
+
+- 'events' in extension/dist/ext/extension.js
+ This product bundles 'events' from the above files.
+ This package is available under the MIT License:
+ MIT
+
+ Copyright Joyent, Inc. and other Node contributors.
+
+ Permission is hereby granted, free of charge, to any person obtaining a
+ copy of this software and associated documentation files (the
+ "Software"), to deal in the Software without restriction, including
+ without limitation the rights to use, copy, modify, merge, publish,
+ distribute, sublicense, and/or sell copies of the Software, and to permit
+ persons to whom the Software is furnished to do so, subject to the
+ following conditions:
+
+ The above copyright notice and this permission notice shall be included
+ in all copies or substantial portions of the Software.
+
+ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
+ OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+ MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
+ NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
+ DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
+ OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
+ USE OR OTHER DEALINGS IN THE SOFTWARE.
+
+- 'fast-redact' n extension/dist/ext/extension.js
+ This product bundles 'fast-redact' from the above files.
+ This package is available under the MIT License:
+ The MIT License (MIT)
+
+ Copyright (c) 2019-2020 David Mark Clements
+
+ Permission is hereby granted, free of charge, to any person obtaining a copy
+ of this software and associated documentation files (the "Software"), to deal
+ in the Software without restriction, including without limitation the rights
+ to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ copies of the Software, and to permit persons to whom the Software is
+ furnished to do so, subject to the following conditions:
+
+ The above copyright notice and this permission notice shall be included in all
+ copies or substantial portions of the Software.
+
+ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ SOFTWARE.
+
+- 'fsevents' n extension/dist/ext/extension.js
Review Comment:
Typo should be `in`
##########
build/package/LICENSE:
##########
@@ -1192,6 +1456,31 @@ conditions of the following licenses.
FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
OTHER DEALINGS IN THE SOFTWARE.
+- 'yargs' n extension/dist/ext/extension.js
Review Comment:
Typo should be `in`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #611: Update LICENSE, NONOTICE, and NOTICE files.
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on PR #611:
URL: https://github.com/apache/daffodil-vscode/pull/611#issuecomment-1533371938
They are production dependencies because they are bundled into the release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on pull request #611: Update LICENSE, NONOTICE, and NOTICE files.
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on PR #611:
URL: https://github.com/apache/daffodil-vscode/pull/611#issuecomment-1533189095
Ah yeah, I think I confused that with `@types/long`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #611: Update LICENSE, NONOTICE, and NOTICE files.
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on PR #611:
URL: https://github.com/apache/daffodil-vscode/pull/611#issuecomment-1533200059
@stevedlawrence No worries, can you take another look everything you mentioned should be fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell merged pull request #611: Update LICENSE, NONOTICE, and NOTICE files.
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell merged PR #611:
URL: https://github.com/apache/daffodil-vscode/pull/611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #611: Update LICENSE, NONOTICE, and NOTICE files.
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on PR #611:
URL: https://github.com/apache/daffodil-vscode/pull/611#issuecomment-1533180372
@stevedlawrence I agree with these other than **long**. Inside of the node module local it has an ALv2 license, its repo also does https://github.com/dcodeIO/long.js
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] Shanedell commented on pull request #611: Update LICENSE, NONOTICE, and NOTICE files.
Posted by "Shanedell (via GitHub)" <gi...@apache.org>.
Shanedell commented on PR #611:
URL: https://github.com/apache/daffodil-vscode/pull/611#issuecomment-1533380953
Its possible, @stevedlawrence would that be something that would be okay to look into? Still that would in a future item not this PR, could be for next release if approved to be use an automated tool for doing this but it seems to be standard to manually keep a list like we have been.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on pull request #611: Update LICENSE, NONOTICE, and NOTICE files.
Posted by "stevedlawrence (via GitHub)" <gi...@apache.org>.
stevedlawrence commented on PR #611:
URL: https://github.com/apache/daffodil-vscode/pull/611#issuecomment-1533390892
Yeah, automated tooling to generate licenses is fine as long as the results meet ASF requirements. Though in my experience, they generally don't since so many projects are inconsistent about where/how there specify their license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on pull request #611: Update LICENSE, NONOTICE, and NOTICE files.
Posted by "scholarsmate (via GitHub)" <gi...@apache.org>.
scholarsmate commented on PR #611:
URL: https://github.com/apache/daffodil-vscode/pull/611#issuecomment-1533377846
In the past I used a gradle license plugin that would traverse my runtime dependency tree and produce a document with the necessary license disclosures that got included in the shipped package. Can this be similarly (semi)automated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org