You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/02 11:35:48 UTC
[GitHub] [incubator-superset] dpgaspar opened a new pull request #9964: feat(api): bump marshmallow and FAB to version 3
dpgaspar opened a new pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964
### SUMMARY
Bump Flask-AppBuilder to version 3 that implies marshmallow version 3 that is a major (breaking) release
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `4.96%`.
> The diff coverage is `85.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
==========================================
- Coverage 71.35% 66.39% -4.97%
==========================================
Files 585 585
Lines 30913 30809 -104
Branches 3246 3246
==========================================
- Hits 22059 20456 -1603
- Misses 8744 10174 +1430
- Partials 110 179 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <ø> (ø)` | |
| #python | `71.34% <85.50%> (-0.20%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <42.85%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.12% <69.23%> (-1.44%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.89% <86.66%> (-0.28%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `82.77% <100.00%> (+0.85%)` | :arrow_up: |
| [superset/charts/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `87.50% <100.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `90.69% <100.00%> (ø)` | |
| [superset/dashboards/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9jcmVhdGUucHk=) | `92.30% <100.00%> (ø)` | |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `98.50% <100.00%> (+1.53%)` | :arrow_up: |
| ... and [168 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...7a05ed9](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar merged pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#discussion_r450075253
##########
File path: tests/charts/schema_tests.py
##########
@@ -39,27 +40,27 @@ def test_query_context_limit_and_offset(self):
# Use defaults
payload["queries"][0].pop("row_limit", None)
payload["queries"][0].pop("row_offset", None)
- query_context, errors = load_query_context(payload)
- self.assertEqual(errors, {})
+ query_context = load_query_context(payload)
query_object = query_context.queries[0]
self.assertEqual(query_object.row_limit, app.config["ROW_LIMIT"])
self.assertEqual(query_object.row_offset, 0)
# Valid limit and offset
payload["queries"][0]["row_limit"] = 100
payload["queries"][0]["row_offset"] = 200
- query_context, errors = ChartDataQueryContextSchema().load(payload)
- self.assertEqual(errors, {})
+ query_context = ChartDataQueryContextSchema().load(payload)
query_object = query_context.queries[0]
self.assertEqual(query_object.row_limit, 100)
self.assertEqual(query_object.row_offset, 200)
# too low limit and offset
payload["queries"][0]["row_limit"] = 0
payload["queries"][0]["row_offset"] = -1
- query_context, errors = ChartDataQueryContextSchema().load(payload)
- self.assertIn("row_limit", errors["queries"][0])
- self.assertIn("row_offset", errors["queries"][0])
+ try:
+ _ = ChartDataQueryContextSchema().load(payload)
+ except ValidationError as errors:
+ self.assertIn("row_limit", errors.messages["queries"][0])
+ self.assertIn("row_offset", errors.messages["queries"][0])
Review comment:
good catch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `5.07%`.
> The diff coverage is `83.87%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
==========================================
- Coverage 71.35% 66.28% -5.08%
==========================================
Files 585 585
Lines 30913 30809 -104
Branches 3246 3246
==========================================
- Hits 22059 20422 -1637
- Misses 8744 10208 +1464
- Partials 110 179 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <ø> (ø)` | |
| #python | `71.16% <83.87%> (-0.39%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <42.85%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.12% <69.23%> (-1.44%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.89% <86.66%> (-0.28%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `82.77% <100.00%> (+0.85%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `90.69% <100.00%> (ø)` | |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `98.50% <100.00%> (+1.53%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [173 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...377cd26](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `11.96%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
===========================================
- Coverage 71.35% 59.39% -11.97%
===========================================
Files 585 401 -184
Lines 30913 12761 -18152
Branches 3246 3246
===========================================
- Hits 22059 7579 -14480
+ Misses 8744 5003 -3741
- Partials 110 179 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [309 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...7a05ed9](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `85.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
==========================================
+ Coverage 71.35% 71.37% +0.01%
==========================================
Files 585 585
Lines 30913 30923 +10
Branches 3246 3246
==========================================
+ Hits 22059 22071 +12
+ Misses 8744 8743 -1
+ Partials 110 109 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.05% <ø> (+0.02%)` | :arrow_up: |
| #javascript | `59.39% <ø> (ø)` | |
| #python | `71.55% <85.50%> (+0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <42.85%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.12% <69.23%> (-1.44%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.89% <86.66%> (-0.28%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `82.77% <100.00%> (+0.85%)` | :arrow_up: |
| [superset/charts/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `87.50% <100.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `90.69% <100.00%> (ø)` | |
| [superset/dashboards/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9jcmVhdGUucHk=) | `92.30% <100.00%> (ø)` | |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `98.50% <100.00%> (+1.53%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...7a05ed9](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `83.87%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
==========================================
+ Coverage 71.35% 71.37% +0.01%
==========================================
Files 585 585
Lines 30913 30923 +10
Branches 3246 3246
==========================================
+ Hits 22059 22072 +13
+ Misses 8744 8742 -2
+ Partials 110 109 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.06% <ø> (+0.03%)` | :arrow_up: |
| #javascript | `59.39% <ø> (ø)` | |
| #python | `71.55% <83.87%> (+0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <42.85%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.12% <69.23%> (-1.44%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.89% <86.66%> (-0.28%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `82.77% <100.00%> (+0.85%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `90.69% <100.00%> (ø)` | |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `98.50% <100.00%> (+1.53%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `66.81% <0.00%> (+0.65%)` | :arrow_up: |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `89.88% <0.00%> (+1.12%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...377cd26](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `0.19%`.
> The diff coverage is `83.87%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
==========================================
- Coverage 71.35% 71.16% -0.20%
==========================================
Files 585 585
Lines 30913 30923 +10
Branches 3246 3246
==========================================
- Hits 22059 22007 -52
- Misses 8744 8801 +57
- Partials 110 115 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.21% <ø> (-0.82%)` | :arrow_down: |
| #javascript | `59.39% <ø> (ø)` | |
| #python | `71.55% <83.87%> (+0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <42.85%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.12% <69.23%> (-1.44%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.89% <86.66%> (-0.28%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `82.77% <100.00%> (+0.85%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `90.69% <100.00%> (ø)` | |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `98.50% <100.00%> (+1.53%)` | :arrow_up: |
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...377cd26](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `11.96%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
===========================================
- Coverage 71.35% 59.39% -11.97%
===========================================
Files 585 401 -184
Lines 30913 12761 -18152
Branches 3246 3246
===========================================
- Hits 22059 7579 -14480
+ Misses 8744 5003 -3741
- Partials 110 179 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [309 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...ce7cab5](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fdd28c1a5ed6727b12bc30632dcf901db87f0d0a&el=desc) will **increase** coverage by `0.38%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
==========================================
+ Coverage 70.31% 70.69% +0.38%
==========================================
Files 594 404 -190
Lines 31608 13108 -18500
Branches 3221 3221
==========================================
- Hits 22225 9267 -12958
+ Misses 9275 3732 -5543
- Partials 108 109 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `52.97% <ø> (-0.42%)` | :arrow_down: |
| #javascript | `59.44% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `77.27% <0.00%> (-3.90%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.75% <0.00%> (-1.66%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `52.12% <0.00%> (-1.22%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `55.91% <0.00%> (-1.08%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.25% <0.00%> (-0.43%)` | :arrow_down: |
| [superset/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhjZXB0aW9ucy5weQ==) | | |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | | |
| ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [fdd28c1...7e046a8](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `0.02%`.
> The diff coverage is `85.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
==========================================
- Coverage 71.35% 71.33% -0.03%
==========================================
Files 585 585
Lines 30913 30923 +10
Branches 3246 3246
==========================================
Hits 22059 22059
- Misses 8744 8755 +11
+ Partials 110 109 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.05% <ø> (+0.02%)` | :arrow_up: |
| #javascript | `59.39% <ø> (ø)` | |
| #python | `71.48% <85.50%> (-0.06%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <42.85%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.12% <69.23%> (-1.44%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.89% <86.66%> (-0.28%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `82.77% <100.00%> (+0.85%)` | :arrow_up: |
| [superset/charts/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `87.50% <100.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `90.69% <100.00%> (ø)` | |
| [superset/dashboards/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9jcmVhdGUucHk=) | `92.30% <100.00%> (ø)` | |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `98.50% <100.00%> (+1.53%)` | :arrow_up: |
| ... and [7 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...7a05ed9](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-653588654
Tagging this as 0.37 due to bugs it fixes in master + to make it easier to cherry pick for patch releases on 0.37 version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#discussion_r450109482
##########
File path: requirements.txt
##########
@@ -58,7 +58,7 @@ markdown==3.2.2 # via apache-superset (setup.py)
markupsafe==1.1.1 # via jinja2, mako, wtforms
marshmallow-enum==1.5.1 # via flask-appbuilder
marshmallow-sqlalchemy==0.23.0 # via flask-appbuilder
-marshmallow==2.21.0 # via flask-appbuilder, marshmallow-enum, marshmallow-sqlalchemy
+marshmallow==3.6.0 # via flask-appbuilder, marshmallow-enum, marshmallow-sqlalchemy
Review comment:
This caught my eye, `3.6.1` is now out: https://pypi.org/project/marshmallow/3.6.1/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `0.19%`.
> The diff coverage is `83.87%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
==========================================
- Coverage 71.35% 71.16% -0.20%
==========================================
Files 585 184 -401
Lines 30913 18048 -12865
Branches 3246 0 -3246
==========================================
- Hits 22059 12843 -9216
+ Misses 8744 5205 -3539
+ Partials 110 0 -110
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `71.16% <83.87%> (-0.39%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <42.85%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.12% <69.23%> (-1.44%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.89% <86.66%> (-0.28%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `82.77% <100.00%> (+0.85%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `90.69% <100.00%> (ø)` | |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `98.50% <100.00%> (+1.53%)` | :arrow_up: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `59.64% <0.00%> (-21.06%)` | :arrow_down: |
| [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `48.00% <0.00%> (-20.00%)` | :arrow_down: |
| ... and [426 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...377cd26](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#discussion_r450068858
##########
File path: superset/charts/api.py
##########
@@ -446,13 +451,13 @@ def data(self) -> Response:
else:
return self.response_400(message="Request is not JSON")
try:
- query_context, errors = ChartDataQueryContextSchema().load(json_body)
- if errors:
- return self.response_400(
- message=_("Request is incorrect: %(error)s", error=errors)
- )
+ query_context = ChartDataQueryContextSchema().load(json_body)
except KeyError:
return self.response_400(message="Request is incorrect")
+ except ValidationError as err:
+ return self.response_400(
+ _("Request is incorrect: %(error)s", error=err.messages)
+ )
Review comment:
Yes it seems weird, this may possible come from our custom `post_load` https://github.com/apache/incubator-superset/blob/master/superset/charts/schemas.py#L736 and then from https://github.com/apache/incubator-superset/blob/master/superset/common/query_context.py#L57
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#discussion_r450078174
##########
File path: superset/charts/schemas.py
##########
@@ -664,6 +663,10 @@ class ChartDataQueryObjectSchema(Schema):
timeseries_limit = fields.Integer(
description="Maximum row count for timeseries queries. Default: `0`",
)
+ timeseries_limit_metric = fields.Integer(
+ description="Maximum row count for timeseries queries. Default: `0`",
Review comment:
changed
##########
File path: tests/charts/schema_tests.py
##########
@@ -39,27 +40,27 @@ def test_query_context_limit_and_offset(self):
# Use defaults
payload["queries"][0].pop("row_limit", None)
payload["queries"][0].pop("row_offset", None)
- query_context, errors = load_query_context(payload)
- self.assertEqual(errors, {})
+ query_context = load_query_context(payload)
query_object = query_context.queries[0]
self.assertEqual(query_object.row_limit, app.config["ROW_LIMIT"])
self.assertEqual(query_object.row_offset, 0)
# Valid limit and offset
payload["queries"][0]["row_limit"] = 100
payload["queries"][0]["row_offset"] = 200
- query_context, errors = ChartDataQueryContextSchema().load(payload)
- self.assertEqual(errors, {})
+ query_context = ChartDataQueryContextSchema().load(payload)
query_object = query_context.queries[0]
self.assertEqual(query_object.row_limit, 100)
self.assertEqual(query_object.row_offset, 200)
# too low limit and offset
payload["queries"][0]["row_limit"] = 0
payload["queries"][0]["row_offset"] = -1
- query_context, errors = ChartDataQueryContextSchema().load(payload)
- self.assertIn("row_limit", errors["queries"][0])
- self.assertIn("row_offset", errors["queries"][0])
+ try:
+ _ = ChartDataQueryContextSchema().load(payload)
+ except ValidationError as errors:
+ self.assertIn("row_limit", errors.messages["queries"][0])
+ self.assertIn("row_offset", errors.messages["queries"][0])
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `0.25%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
==========================================
- Coverage 71.35% 71.09% -0.26%
==========================================
Files 585 401 -184
Lines 30913 12761 -18152
Branches 3246 3246
==========================================
- Hits 22059 9073 -12986
+ Misses 8744 3578 -5166
Partials 110 110
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.03% <ø> (ø)` | |
| #javascript | `59.39% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/druid/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9fX2luaXRfXy5weQ==) | | |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | | |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | | |
| [superset/result\_set.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | | |
| [superset/translations/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHJhbnNsYXRpb25zL3V0aWxzLnB5) | | |
| [superset/db\_engine\_specs/vertica.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ZlcnRpY2EucHk=) | | |
| [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | | |
| [superset/db\_engine\_specs/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL19faW5pdF9fLnB5) | | |
| [superset/examples/country\_map.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyeV9tYXAucHk=) | | |
| [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | | |
| ... and [166 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...46c681f](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dpgaspar commented on a change in pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
dpgaspar commented on a change in pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#discussion_r450124241
##########
File path: requirements.txt
##########
@@ -58,7 +58,7 @@ markdown==3.2.2 # via apache-superset (setup.py)
markupsafe==1.1.1 # via jinja2, mako, wtforms
marshmallow-enum==1.5.1 # via flask-appbuilder
marshmallow-sqlalchemy==0.23.0 # via flask-appbuilder
-marshmallow==2.21.0 # via flask-appbuilder, marshmallow-enum, marshmallow-sqlalchemy
+marshmallow==3.6.0 # via flask-appbuilder, marshmallow-enum, marshmallow-sqlalchemy
Review comment:
Good point, checked the changelog and it's just docs, safe bump ;)
https://github.com/marshmallow-code/marshmallow/blob/dev/CHANGELOG.rst#361-2020-06-02
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `0.71%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
==========================================
- Coverage 71.35% 70.64% -0.72%
==========================================
Files 585 401 -184
Lines 30913 12761 -18152
Branches 3246 3246
==========================================
- Hits 22059 9015 -13044
+ Misses 8744 3631 -5113
- Partials 110 115 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.28% <ø> (-0.75%)` | :arrow_down: |
| #javascript | `59.39% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.03%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.44% <0.00%> (-3.30%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `53.84% <0.00%> (-1.29%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `55.91% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | | |
| ... and [171 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...18522ce](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **increase** coverage by `0.00%`.
> The diff coverage is `85.07%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
=======================================
Coverage 71.35% 71.36%
=======================================
Files 585 585
Lines 30913 30923 +10
Branches 3246 3246
=======================================
+ Hits 22059 22069 +10
Misses 8744 8744
Partials 110 110
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.04% <ø> (+<0.01%)` | :arrow_up: |
| #javascript | `59.39% <ø> (ø)` | |
| #python | `71.55% <85.07%> (+0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <42.85%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.12% <69.23%> (-1.44%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.89% <86.66%> (-0.28%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `82.77% <100.00%> (+0.85%)` | :arrow_up: |
| [superset/charts/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `87.50% <100.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `90.69% <100.00%> (ø)` | |
| [superset/dashboards/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9jcmVhdGUucHk=) | `92.30% <100.00%> (ø)` | |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `98.50% <100.00%> (+1.53%)` | :arrow_up: |
| ... and [4 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...18522ce](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `4.82%`.
> The diff coverage is `85.07%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
==========================================
- Coverage 71.35% 66.53% -4.83%
==========================================
Files 585 585
Lines 30913 30923 +10
Branches 3246 3246
==========================================
- Hits 22059 20574 -1485
- Misses 8744 10170 +1426
- Partials 110 179 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <ø> (ø)` | |
| #python | `71.55% <85.07%> (+0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <42.85%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.12% <69.23%> (-1.44%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.89% <86.66%> (-0.28%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `82.77% <100.00%> (+0.85%)` | :arrow_up: |
| [superset/charts/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `87.50% <100.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `90.69% <100.00%> (ø)` | |
| [superset/dashboards/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9jcmVhdGUucHk=) | `92.30% <100.00%> (ø)` | |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `98.50% <100.00%> (+1.53%)` | :arrow_up: |
| ... and [151 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...18522ce](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `0.30%`.
> The diff coverage is `85.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
==========================================
- Coverage 71.35% 71.05% -0.31%
==========================================
Files 585 585
Lines 30913 30809 -104
Branches 3246 3246
==========================================
- Hits 22059 21891 -168
- Misses 8744 8803 +59
- Partials 110 115 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.27% <ø> (-0.76%)` | :arrow_down: |
| #javascript | `59.39% <ø> (ø)` | |
| #python | `71.34% <85.50%> (-0.20%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <42.85%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.12% <69.23%> (-1.44%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.89% <86.66%> (-0.28%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `82.77% <100.00%> (+0.85%)` | :arrow_up: |
| [superset/charts/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `87.50% <100.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `90.69% <100.00%> (ø)` | |
| [superset/dashboards/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9jcmVhdGUucHk=) | `92.30% <100.00%> (ø)` | |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `98.50% <100.00%> (+1.53%)` | :arrow_up: |
| ... and [29 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...7a05ed9](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `4.86%`.
> The diff coverage is `85.07%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
==========================================
- Coverage 71.35% 66.49% -4.87%
==========================================
Files 585 585
Lines 30913 30923 +10
Branches 3246 3246
==========================================
- Hits 22059 20562 -1497
- Misses 8744 10182 +1438
- Partials 110 179 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <ø> (ø)` | |
| #python | `71.48% <85.07%> (-0.06%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <42.85%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.12% <69.23%> (-1.44%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.89% <86.66%> (-0.28%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `82.77% <100.00%> (+0.85%)` | :arrow_up: |
| [superset/charts/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `87.50% <100.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `90.69% <100.00%> (ø)` | |
| [superset/dashboards/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9jcmVhdGUucHk=) | `92.30% <100.00%> (ø)` | |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `98.50% <100.00%> (+1.53%)` | :arrow_up: |
| ... and [154 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...18522ce](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `0.22%`.
> The diff coverage is `85.50%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
==========================================
- Coverage 71.35% 71.13% -0.23%
==========================================
Files 585 585
Lines 30913 30923 +10
Branches 3246 3246
==========================================
- Hits 22059 21997 -62
- Misses 8744 8811 +67
- Partials 110 115 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.27% <ø> (-0.76%)` | :arrow_down: |
| #javascript | `59.39% <ø> (ø)` | |
| #python | `71.48% <85.50%> (-0.06%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <42.85%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.12% <69.23%> (-1.44%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.89% <86.66%> (-0.28%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `82.77% <100.00%> (+0.85%)` | :arrow_up: |
| [superset/charts/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `87.50% <100.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `90.69% <100.00%> (ø)` | |
| [superset/dashboards/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9jcmVhdGUucHk=) | `92.30% <100.00%> (ø)` | |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `98.50% <100.00%> (+1.53%)` | :arrow_up: |
| ... and [15 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...7a05ed9](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#discussion_r449918739
##########
File path: superset/charts/schemas.py
##########
@@ -664,6 +663,10 @@ class ChartDataQueryObjectSchema(Schema):
timeseries_limit = fields.Integer(
description="Maximum row count for timeseries queries. Default: `0`",
)
+ timeseries_limit_metric = fields.Integer(
+ description="Maximum row count for timeseries queries. Default: `0`",
Review comment:
Good catch 👍 The description should probably be updated to read `Metric used to limit timeseries queries by`.
##########
File path: superset/dashboards/api.py
##########
@@ -196,13 +198,14 @@ def post(self) -> Response:
"""
if not request.is_json:
return self.response_400(message="Request is not JSON")
- item = self.add_model_schema.load(request.json)
+ try:
+ item = self.add_model_schema.load(request.json)
# This validates custom Schema with custom validations
- if item.errors:
- return self.response_400(message=item.errors)
+ except ValidationError as err:
+ return self.response_400(message=err.messages)
Review comment:
Being picky, but is it more pythonic to assign `error` as opposed to `err`? (Applies to other places, too)
##########
File path: superset/charts/api.py
##########
@@ -446,13 +451,13 @@ def data(self) -> Response:
else:
return self.response_400(message="Request is not JSON")
try:
- query_context, errors = ChartDataQueryContextSchema().load(json_body)
- if errors:
- return self.response_400(
- message=_("Request is incorrect: %(error)s", error=errors)
- )
+ query_context = ChartDataQueryContextSchema().load(json_body)
except KeyError:
return self.response_400(message="Request is incorrect")
+ except ValidationError as err:
+ return self.response_400(
+ _("Request is incorrect: %(error)s", error=err.messages)
+ )
Review comment:
Is `except KeyError` still needed here? Based on the docs, `load` only raises `ValidationError` in 3.0+: https://marshmallow.readthedocs.io/en/stable/_modules/marshmallow/schema.html#Schema.load
##########
File path: tests/charts/schema_tests.py
##########
@@ -39,27 +40,27 @@ def test_query_context_limit_and_offset(self):
# Use defaults
payload["queries"][0].pop("row_limit", None)
payload["queries"][0].pop("row_offset", None)
- query_context, errors = load_query_context(payload)
- self.assertEqual(errors, {})
+ query_context = load_query_context(payload)
query_object = query_context.queries[0]
self.assertEqual(query_object.row_limit, app.config["ROW_LIMIT"])
self.assertEqual(query_object.row_offset, 0)
# Valid limit and offset
payload["queries"][0]["row_limit"] = 100
payload["queries"][0]["row_offset"] = 200
- query_context, errors = ChartDataQueryContextSchema().load(payload)
- self.assertEqual(errors, {})
+ query_context = ChartDataQueryContextSchema().load(payload)
query_object = query_context.queries[0]
self.assertEqual(query_object.row_limit, 100)
self.assertEqual(query_object.row_offset, 200)
# too low limit and offset
payload["queries"][0]["row_limit"] = 0
payload["queries"][0]["row_offset"] = -1
- query_context, errors = ChartDataQueryContextSchema().load(payload)
- self.assertIn("row_limit", errors["queries"][0])
- self.assertIn("row_offset", errors["queries"][0])
+ try:
+ _ = ChartDataQueryContextSchema().load(payload)
+ except ValidationError as errors:
+ self.assertIn("row_limit", errors.messages["queries"][0])
+ self.assertIn("row_offset", errors.messages["queries"][0])
Review comment:
If this doesn't raise, won't the assertions just be skipped?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#discussion_r450090804
##########
File path: superset/charts/schemas.py
##########
@@ -725,20 +727,20 @@ class ChartDataQueryContextSchema(Schema):
)
result_type = fields.String(
description="Type of results to return",
- validate=validate.OneOf(choices=("full", "query", "results", "samples")),
+ validate=validate.OneOf(choices=("query", "results", "samples")),
Review comment:
`full` should be a valid choice here, see for instance https://github.com/apache/incubator-superset/blob/master/superset-frontend/src/chart/chartAction.js#L343-L350
##########
File path: tests/datasets/api_tests.py
##########
@@ -404,6 +411,12 @@ def test_update_dataset_update_column(self):
# Get current cols and alter one
rv = self.get_assert_metric(uri, "get")
resp_columns = json.loads(rv.data.decode("utf-8"))["result"]["columns"]
+ for column in resp_columns:
+ column.pop("changed_on", None)
+ column.pop("created_on", None)
+ column.pop("changed_on", None)
+ column.pop("changed_on", None)
Review comment:
Same here
##########
File path: tests/datasets/api_tests.py
##########
@@ -371,6 +371,13 @@ def test_update_dataset_create_column(self):
self.login(username="admin")
rv = self.get_assert_metric(uri, "get")
data = json.loads(rv.data.decode("utf-8"))
+
+ for column in data["result"]["columns"]:
+ column.pop("changed_on", None)
+ column.pop("created_on", None)
+ column.pop("changed_on", None)
+ column.pop("changed_on", None)
Review comment:
aren't these redundant?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `11.96%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
===========================================
- Coverage 71.35% 59.39% -11.97%
===========================================
Files 585 401 -184
Lines 30913 12761 -18152
Branches 3246 3246
===========================================
- Hits 22059 7579 -14480
+ Misses 8744 5003 -3741
- Partials 110 179 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [314 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...46c681f](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fdd28c1a5ed6727b12bc30632dcf901db87f0d0a&el=desc) will **increase** coverage by `0.58%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
==========================================
+ Coverage 70.31% 70.90% +0.58%
==========================================
Files 594 404 -190
Lines 31608 13108 -18500
Branches 3221 3221
==========================================
- Hits 22225 9294 -12931
+ Misses 9275 3706 -5569
Partials 108 108
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.45% <ø> (+0.07%)` | :arrow_up: |
| #javascript | `59.44% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/kylin.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2t5bGluLnB5) | | |
| [superset/connectors/druid/\_\_init\_\_.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9fX2luaXRfXy5weQ==) | | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | | |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | | |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | | |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | | |
| [superset/views/chart/mixin.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvbWl4aW4ucHk=) | | |
| [superset/examples/countries.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvY291bnRyaWVzLnB5) | | |
| [superset/models/datasource\_access\_request.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2RhdGFzb3VyY2VfYWNjZXNzX3JlcXVlc3QucHk=) | | |
| [superset/examples/world\_bank.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvd29ybGRfYmFuay5weQ==) | | |
| ... and [168 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [fdd28c1...7e046a8](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `4.86%`.
> The diff coverage is `83.87%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
==========================================
- Coverage 71.35% 66.49% -4.87%
==========================================
Files 585 585
Lines 30913 30923 +10
Branches 3246 3246
==========================================
- Hits 22059 20562 -1497
- Misses 8744 10182 +1438
- Partials 110 179 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <ø> (ø)` | |
| #python | `71.48% <83.87%> (-0.06%)` | :arrow_down: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <42.85%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.12% <69.23%> (-1.44%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.89% <86.66%> (-0.28%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `82.77% <100.00%> (+0.85%)` | :arrow_up: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `90.69% <100.00%> (ø)` | |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `98.50% <100.00%> (+1.53%)` | :arrow_up: |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [149 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...377cd26](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `11.96%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
===========================================
- Coverage 71.35% 59.39% -11.97%
===========================================
Files 585 401 -184
Lines 30913 12761 -18152
Branches 3246 3246
===========================================
- Hits 22059 7579 -14480
+ Misses 8744 5003 -3741
- Partials 110 179 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `59.39% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupColors.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwQ29sb3JzLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/setup/setupFormatters.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRm9ybWF0dGVycy5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [309 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...18522ce](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `0.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
==========================================
- Coverage 71.35% 71.13% -0.23%
==========================================
Files 585 401 -184
Lines 30913 12761 -18152
Branches 3246 3246
==========================================
- Hits 22059 9077 -12982
+ Misses 8744 3575 -5169
+ Partials 110 109 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.06% <ø> (+0.03%)` | :arrow_up: |
| #javascript | `59.39% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/utils/dashboard\_import\_export.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGFzaGJvYXJkX2ltcG9ydF9leHBvcnQucHk=) | | |
| [superset/views/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvdXRpbHMucHk=) | | |
| [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | | |
| [superset/models/schedules.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NjaGVkdWxlcy5weQ==) | | |
| [superset/constants.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | | |
| [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5) | | |
| [superset/queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9hcGkucHk=) | | |
| [superset/examples/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvaGVscGVycy5weQ==) | | |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | | |
| [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==) | | |
| ... and [163 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...18522ce](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `0.18%`.
> The diff coverage is `85.07%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
==========================================
- Coverage 71.35% 71.17% -0.19%
==========================================
Files 585 585
Lines 30913 30923 +10
Branches 3246 3246
==========================================
- Hits 22059 22008 -51
- Misses 8744 8800 +56
- Partials 110 115 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.22% <ø> (-0.82%)` | :arrow_down: |
| #javascript | `59.39% <ø> (ø)` | |
| #python | `71.55% <85.07%> (+0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/datasets/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `92.15% <42.85%> (ø)` | |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `91.12% <69.23%> (-1.44%)` | :arrow_down: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `80.89% <86.66%> (-0.28%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `82.77% <100.00%> (+0.85%)` | :arrow_up: |
| [superset/charts/commands/update.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL3VwZGF0ZS5weQ==) | `87.50% <100.00%> (ø)` | |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <100.00%> (ø)` | |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | `90.69% <100.00%> (ø)` | |
| [superset/dashboards/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9jcmVhdGUucHk=) | `92.30% <100.00%> (ø)` | |
| [superset/dashboards/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
| [superset/dashboards/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zY2hlbWFzLnB5) | `98.50% <100.00%> (+1.53%)` | :arrow_up: |
| ... and [14 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...18522ce](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9964: feat(api): bump marshmallow and FAB to version 3
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9964:
URL: https://github.com/apache/incubator-superset/pull/9964#issuecomment-637484113
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=h1) Report
> Merging [#9964](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/38a6bd79da2be8c13a89a5f67f77faeb55c4e08b&el=desc) will **decrease** coverage by `0.72%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9964 +/- ##
==========================================
- Coverage 71.35% 70.63% -0.73%
==========================================
Files 585 401 -184
Lines 30913 12761 -18152
Branches 3246 3246
==========================================
- Hits 22059 9014 -13045
+ Misses 8744 3632 -5112
- Partials 110 115 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.27% <ø> (-0.76%)` | :arrow_down: |
| #javascript | `59.39% <ø> (ø)` | |
| #python | `?` | |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [superset-frontend/src/reduxUtils.ts](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3JlZHV4VXRpbHMudHM=) | `70.88% <0.00%> (-8.87%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `75.52% <0.00%> (-6.30%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.13% <0.00%> (-5.03%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.44% <0.00%> (-3.30%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `53.84% <0.00%> (-1.29%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `55.91% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/db\_engine\_specs/vertica.py](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ZlcnRpY2EucHk=) | | |
| ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/9964/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=footer). Last update [38a6bd7...46c681f](https://codecov.io/gh/apache/incubator-superset/pull/9964?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org