DO NOT REPLY [Bug 8934] New: - GetServerVariable returns wrong lpdwSizeofBuffer

[bu...@apache.org]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8934>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=8934

GetServerVariable returns wrong lpdwSizeofBuffer

           Summary: GetServerVariable returns wrong lpdwSizeofBuffer
           Product: Apache httpd-2.0
           Version: 2.0.36
          Platform: PC
        OS/Version: Windows NT/2K
            Status: NEW
          Severity: Normal
          Priority: Other
         Component: mod_isapi
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: sebastian.hantsch@gmx.de


According to the MSDN at

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/iisref/html/psdk/asp/isre504l.asp

the parameter "lpdwSizeofBuffer" should be set to "the size of bytes transferred
into the buffer, including the null-terminating byte" on successful completion.

Currently in mod_isapi.c, line 629, the null-terminating byte is not taken into
account, so the value of "lpdwSizeofBuffer" is too small by one.

This breaks ISAPI-dlls based on Borland Delphi 6.0, as these dlls use the value
of "lpdwSizeofBuffer" to determinate the length of the server variable.

Suggested fix:
Replace line 629: 
*lpdwSizeofBuffer = len;
with
*lpdwSizeofBuffer = len + 1;

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org