You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "Omega359 (via GitHub)" <gi...@apache.org> on 2025/12/05 16:35:53 UTC
[I] Update to_timestamp udf functions to have a consistent set of supported argument types [datafusion]
Omega359 opened a new issue, #19117:
URL: https://github.com/apache/datafusion/issues/19117
### Is your feature request related to a problem or challenge?
Currently the to_timestamp set of functions do not have a consistent set of arguments among them. As an example the to_timestamp function supports Float64 and Decimal128(_._) however not all the other functions do. It's questionable whether supporting Float64 and Decimal128 is even appropriate for these functions but I'll leave that to another time.
The docs for these functions say: "Supports strings, integer, unsigned integer, and double types as input." however unsigned integers are not supported in any code directly. I do not believe type coercion would be invoked by DF before calling this function as the signature is `Signature::variadic_any(Volatility::Immutable)`
Given the above, I believe all the to_timestamp functions should be consistent and support:
- all the int* types
- all the uint* types
- all the utf8* types
- all the float types
- I'm on the fence for Decimal128 but there was a reason for it - #15486
### Describe the solution you'd like
Updated code, tests to cover every single allowed type.
### Describe alternatives you've considered
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update to_timestamp udf functions to have a consistent set of argument types [datafusion]
Posted by "kumarUjjawal (via GitHub)" <gi...@apache.org>.
kumarUjjawal commented on issue #19117:
URL: https://github.com/apache/datafusion/issues/19117#issuecomment-3685345110
@gokselk are working on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update to_timestamp udf functions to have a consistent set of supported argument types [datafusion]
Posted by "Omega359 (via GitHub)" <gi...@apache.org>.
Omega359 commented on issue #19117:
URL: https://github.com/apache/datafusion/issues/19117#issuecomment-3617646058
Ideally this would be based on the code in PR #19078
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update to_timestamp udf functions to have a consistent set of argument types [datafusion]
Posted by "gokselk (via GitHub)" <gi...@apache.org>.
gokselk commented on issue #19117:
URL: https://github.com/apache/datafusion/issues/19117#issuecomment-3648490914
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update to_timestamp udf functions to have a consistent set of argument types [datafusion]
Posted by "kumarUjjawal (via GitHub)" <gi...@apache.org>.
kumarUjjawal commented on issue #19117:
URL: https://github.com/apache/datafusion/issues/19117#issuecomment-3685512277
> > [@gokselk](https://github.com/gokselk) are working on this?
>
> Done on my end. I have the changes locally, just waiting for [#19078](https://github.com/apache/datafusion/pull/19078) to be finalized and merged. I'll rebase and open the PR after that.
Great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update to_timestamp udf functions to have a consistent set of argument types [datafusion]
Posted by "gokselk (via GitHub)" <gi...@apache.org>.
gokselk commented on issue #19117:
URL: https://github.com/apache/datafusion/issues/19117#issuecomment-3685419351
> [@gokselk](https://github.com/gokselk) are working on this?
Done on my end. I have the changes locally, just waiting for #19078 to be finalized and merged. I'll rebase and open the PR after that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Update to_timestamp udf functions to have a consistent set of argument types [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey closed issue #19117: Update to_timestamp udf functions to have a consistent set of argument types
URL: https://github.com/apache/datafusion/issues/19117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org