You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/10/24 09:33:55 UTC
[GitHub] [lucene-solr] mocobeta opened a new pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
mocobeta opened a new pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023
"sandbox" module shares package names o.a.l.codecs, o.a.l.document, and o.a.l.search. We have two choices to clean up this conflicts:
- Move them under `o.a.l.sandbox` and relax classes/methods visibility to public/protected to allow classes in sandbox module access those (currently package-private) classes/methods.
- Move them to core module to keep package-private visibility in core module as is.
Here, I took the first option for all classes for the first step to resolve the conflicts. But that may be a rather wild approach; some classes probably should be moved to core (option 2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511365628
##########
File path: lucene/core/src/java/org/apache/lucene/document/RangeFieldQuery.java
##########
@@ -57,7 +57,7 @@
final int bytesPerDim;
/** Used by {@code RangeFieldQuery} to check how each internal or leaf node relates to the query. */
- enum QueryType {
+ public enum QueryType {
Review comment:
This is used in o.a.l.sandbox.document.LatLonBoundingBox.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511373874
##########
File path: lucene/core/src/java/org/apache/lucene/search/TopDocsCollector.java
##########
@@ -35,7 +35,7 @@
/** This is used in case topDocs() is called with illegal parameters, or there
* simply aren't (enough) results. */
- protected static final TopDocs EMPTY_TOPDOCS = new TopDocs(new TotalHits(0, TotalHits.Relation.EQUAL_TO), new ScoreDoc[0]);
+ public static final TopDocs EMPTY_TOPDOCS = new TopDocs(new TotalHits(0, TotalHits.Relation.EQUAL_TO), new ScoreDoc[0]);
Review comment:
This is used in o.a.l.sandbox.search.LargeNumHitsTopDocsCollector.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511372816
##########
File path: lucene/core/src/java/org/apache/lucene/search/TermScorer.java
##########
@@ -25,7 +25,7 @@
/** Expert: A <code>Scorer</code> for documents matching a <code>Term</code>.
*/
-final class TermScorer extends Scorer {
+public final class TermScorer extends Scorer {
Review comment:
This is used in o.a.l.sandbox.search.BM25FQuery.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511368688
##########
File path: lucene/core/src/java/org/apache/lucene/search/HitQueue.java
##########
@@ -59,7 +60,7 @@
* @param prePopulate
* specifies whether to pre-populate the queue with sentinel values.
*/
- HitQueue(int size, boolean prePopulate) {
+ public HitQueue(int size, boolean prePopulate) {
Review comment:
Same above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511371777
##########
File path: lucene/core/src/java/org/apache/lucene/search/PhraseWeight.java
##########
@@ -23,13 +23,15 @@
import org.apache.lucene.search.similarities.Similarity;
import org.apache.lucene.search.similarities.Similarity.SimScorer;
-abstract class PhraseWeight extends Weight {
+/** Expert: Weight class for phrase matching */
+public abstract class PhraseWeight extends Weight {
Review comment:
This is used in o.a.l.sandbox.search.PhraseWildcardQuery.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511364893
##########
File path: lucene/core/src/java/org/apache/lucene/document/RangeFieldQuery.java
##########
@@ -41,7 +41,7 @@
/**
* Query class for searching {@code RangeField} types by a defined {@link Relation}.
*/
-abstract class RangeFieldQuery extends Query {
+public abstract class RangeFieldQuery extends Query {
Review comment:
This is used in o.a.l.sandbox.document.LatLonBoundingBox.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511370707
##########
File path: lucene/core/src/java/org/apache/lucene/search/PhraseMatcher.java
##########
@@ -26,7 +26,7 @@
* relevant document, then call {@link #reset()}. Clients can then call
* {@link #nextMatch()} to iterate over the matches
*/
-abstract class PhraseMatcher {
+public abstract class PhraseMatcher {
Review comment:
This is used in o.a.l.sandbox.search.PhraseWildcardQuery.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511369392
##########
File path: lucene/core/src/java/org/apache/lucene/search/MultiPhraseQuery.java
##########
@@ -410,7 +410,7 @@ private boolean termArraysEquals(Term[][] termArrays1, Term[][] termArrays2) {
* <p>
* Note: positions are merged during freq()
*/
- static class UnionPostingsEnum extends PostingsEnum {
+ public static class UnionPostingsEnum extends PostingsEnum {
Review comment:
This is used in o.a.l.sandbox.search.PhraseWildcardQuery.
##########
File path: lucene/core/src/java/org/apache/lucene/search/MultiPhraseQuery.java
##########
@@ -423,7 +423,7 @@ private boolean termArraysEquals(Term[][] termArrays1, Term[][] termArrays2) {
/** list of subs (unordered) */
final PostingsEnum[] subs;
- UnionPostingsEnum(Collection<PostingsEnum> subs) {
+ public UnionPostingsEnum(Collection<PostingsEnum> subs) {
Review comment:
Same avobe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511372160
##########
File path: lucene/core/src/java/org/apache/lucene/search/SloppyPhraseMatcher.java
##########
@@ -53,7 +53,7 @@
* would get same score as "g f"~2, although "c b"~2 could be matched twice.
* We may want to fix this in the future (currently not, for performance reasons).
*/
-final class SloppyPhraseMatcher extends PhraseMatcher {
+public final class SloppyPhraseMatcher extends PhraseMatcher {
Review comment:
This is used in o.a.l.sandbox.search.PhraseWildcardQuery.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#issuecomment-718018031
@dweiss thanks for taking a look at this.
@nknize @bruno-roustant @atris @jpountz @jimczi
I'm trying to clean up shared packages between sandbox and lucene-core. But for now I have little knowledge about those classes that were moved in this pull request; I think you're the ones of first authors of the experimental classes, I'd like to ask your thoughts.
If you think some classes should be moved to lucene-core (instead of opening the classes/methods in core module to public), or have any concerns about changes I made here, would you leave comments?
I'll wait one more week, then if there is no objection, merge it into master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511373161
##########
File path: lucene/core/src/java/org/apache/lucene/search/TermScorer.java
##########
@@ -35,7 +35,7 @@
/**
* Construct a {@link TermScorer} that will iterate all documents.
*/
- TermScorer(Weight weight, PostingsEnum postingsEnum, LeafSimScorer docScorer) {
+ public TermScorer(Weight weight, PostingsEnum postingsEnum, LeafSimScorer docScorer) {
Review comment:
Same above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511371410
##########
File path: lucene/core/src/java/org/apache/lucene/search/PhraseQuery.java
##########
@@ -413,7 +415,7 @@ public boolean equals(Object obj) {
* This is for use by {@link TwoPhaseIterator#matchCost} implementations.
* @param termsEnum The term is the term at which this TermsEnum is positioned.
*/
- static float termPositionsCost(TermsEnum termsEnum) throws IOException {
+ public static float termPositionsCost(TermsEnum termsEnum) throws IOException {
Review comment:
This is used in o.a.l.sandbox.search.PhraseWildcardQuery.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511369770
##########
File path: lucene/core/src/java/org/apache/lucene/search/MultiPhraseQuery.java
##########
@@ -575,17 +575,17 @@ private void growArray() {
}
}
- // Slower version of UnionPostingsEnum that delegates offsets and positions, for
- // use by MatchesIterator
- static class UnionFullPostingsEnum extends UnionPostingsEnum {
+ /** Slower version of UnionPostingsEnum that delegates offsets and positions, for
+ use by MatchesIterator */
+ public static class UnionFullPostingsEnum extends UnionPostingsEnum {
Review comment:
This is used in o.a.l.sandbox.search.PhraseWildcardQuery.
##########
File path: lucene/core/src/java/org/apache/lucene/search/MultiPhraseQuery.java
##########
@@ -575,17 +575,17 @@ private void growArray() {
}
}
- // Slower version of UnionPostingsEnum that delegates offsets and positions, for
- // use by MatchesIterator
- static class UnionFullPostingsEnum extends UnionPostingsEnum {
+ /** Slower version of UnionPostingsEnum that delegates offsets and positions, for
+ use by MatchesIterator */
+ public static class UnionFullPostingsEnum extends UnionPostingsEnum {
int freq = -1;
boolean started = false;
final PriorityQueue<PostingsAndPosition> posQueue;
final Collection<PostingsAndPosition> subs;
- UnionFullPostingsEnum(List<PostingsEnum> subs) {
+ public UnionFullPostingsEnum(List<PostingsEnum> subs) {
Review comment:
Same above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511373437
##########
File path: lucene/core/src/java/org/apache/lucene/search/TermScorer.java
##########
@@ -60,7 +60,8 @@ public int docID() {
return postingsEnum.docID();
}
- final int freq() throws IOException {
+ /** Returns term frequency in the current document. */
+ public final int freq() throws IOException {
Review comment:
Same above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511370101
##########
File path: lucene/core/src/java/org/apache/lucene/search/Multiset.java
##########
@@ -29,13 +29,13 @@
* Iteration order is not specified.
* @lucene.internal
*/
-final class Multiset<T> extends AbstractCollection<T> {
+public final class Multiset<T> extends AbstractCollection<T> {
Review comment:
This is used in o.a.l.sandbox.search.CoveringQuery.
##########
File path: lucene/core/src/java/org/apache/lucene/search/Multiset.java
##########
@@ -29,13 +29,13 @@
* Iteration order is not specified.
* @lucene.internal
*/
-final class Multiset<T> extends AbstractCollection<T> {
+public final class Multiset<T> extends AbstractCollection<T> {
private final Map<T, Integer> map = new HashMap<>();
private int size;
/** Create an empty {@link Multiset}. */
- Multiset() {
+ public Multiset() {
Review comment:
Same above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511374261
##########
File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##########
@@ -38,9 +38,10 @@
*/
public abstract class TopScoreDocCollector extends TopDocsCollector<ScoreDoc> {
- abstract static class ScorerLeafCollector implements LeafCollector {
+ /** Scorable leaf collector */
+ public abstract static class ScorerLeafCollector implements LeafCollector {
Review comment:
This is used in o.a.l.sandbox.search.LargeNumHitsTopDocsCollector.
##########
File path: lucene/core/src/java/org/apache/lucene/search/TopScoreDocCollector.java
##########
@@ -38,9 +38,10 @@
*/
public abstract class TopScoreDocCollector extends TopDocsCollector<ScoreDoc> {
- abstract static class ScorerLeafCollector implements LeafCollector {
+ /** Scorable leaf collector */
+ public abstract static class ScorerLeafCollector implements LeafCollector {
- Scorable scorer;
+ protected Scorable scorer;
Review comment:
Same above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511368151
##########
File path: lucene/core/src/java/org/apache/lucene/search/ExactPhraseMatcher.java
##########
@@ -50,7 +51,8 @@ public PostingsAndPosition(PostingsEnum postings, int offset) {
private final DocIdSetIterator approximation;
private final ImpactsDISI impactsApproximation;
- ExactPhraseMatcher(PhraseQuery.PostingsAndFreq[] postings, ScoreMode scoreMode, SimScorer scorer, float matchCost) {
+ /** Expert: Creates ExactPhraseMatcher instance */
+ public ExactPhraseMatcher(PhraseQuery.PostingsAndFreq[] postings, ScoreMode scoreMode, SimScorer scorer, float matchCost) {
Review comment:
Same avobe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta merged pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta merged pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511367381
##########
File path: lucene/core/src/java/org/apache/lucene/document/RangeFieldQuery.java
##########
@@ -228,7 +228,7 @@ boolean matches(byte[] queryPackedValue, byte[] packedValue, int numDims, int by
* @param ranges encoded range values; this is done by the {@code RangeField} implementation
* @param queryType the query relation
*/
- RangeFieldQuery(String field, final byte[] ranges, final int numDims, final QueryType queryType) {
+ protected RangeFieldQuery(String field, final byte[] ranges, final int numDims, final QueryType queryType) {
Review comment:
This is used in o.a.l.sandbox.document.LatLonBoundingBox.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511367972
##########
File path: lucene/core/src/java/org/apache/lucene/search/ExactPhraseMatcher.java
##########
@@ -33,7 +33,8 @@
import org.apache.lucene.search.similarities.Similarity.SimScorer;
import org.apache.lucene.util.PriorityQueue;
-final class ExactPhraseMatcher extends PhraseMatcher {
+/** Expert: Find exact phrases */
+public final class ExactPhraseMatcher extends PhraseMatcher {
Review comment:
This is used in o.a.l.sandbox.search.PhraseWildcardQuery.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511371028
##########
File path: lucene/core/src/java/org/apache/lucene/search/PhraseQuery.java
##########
@@ -304,13 +304,15 @@ public void visit(QueryVisitor visitor) {
v.consumeTerms(this, terms);
}
- static class PostingsAndFreq implements Comparable<PostingsAndFreq> {
+ /** Term postings and position information for phrase matching */
+ public static class PostingsAndFreq implements Comparable<PostingsAndFreq> {
Review comment:
This is used in o.a.l.sandbox.search.PhraseWildcardQuery.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511372528
##########
File path: lucene/core/src/java/org/apache/lucene/search/SloppyPhraseMatcher.java
##########
@@ -81,7 +81,7 @@
private boolean positioned;
private int matchLength;
- SloppyPhraseMatcher(PhraseQuery.PostingsAndFreq[] postings, int slop, ScoreMode scoreMode, SimScorer scorer, float matchCost, boolean captureLeadMatch) {
+ public SloppyPhraseMatcher(PhraseQuery.PostingsAndFreq[] postings, int slop, ScoreMode scoreMode, SimScorer scorer, float matchCost, boolean captureLeadMatch) {
Review comment:
Same above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] mocobeta commented on a change in pull request #2023: LUCENE-9319: Clean up package name conflicts for sandbox module
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #2023:
URL: https://github.com/apache/lucene-solr/pull/2023#discussion_r511368625
##########
File path: lucene/core/src/java/org/apache/lucene/search/HitQueue.java
##########
@@ -19,7 +19,8 @@
import org.apache.lucene.util.PriorityQueue;
-final class HitQueue extends PriorityQueue<ScoreDoc> {
+/** Expert: Priority queue containing hit docs */
+public final class HitQueue extends PriorityQueue<ScoreDoc> {
Review comment:
This is used in o.a.l.sandbox.search.LargeNumHitsTopDocsCollector.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org