You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Kenneth Knowles (Jira)" <ji...@apache.org> on 2019/10/23 18:14:00 UTC
[jira] [Comment Edited] (BEAM-5878) Support DoFns with Keyword-only
arguments in Python 3.
[ https://issues.apache.org/jira/browse/BEAM-5878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16958118#comment-16958118 ]
Kenneth Knowles edited comment on BEAM-5878 at 10/23/19 6:13 PM:
-----------------------------------------------------------------
This got pushed from 2.16.0 to 2.17.0. That makes it seem that it is not a release blocker so it does not need Fix Version set. Correct?
It also seems like a large and uncertain work with many PRs, so also not suitable for release blocking unless it is a major defect.
was (Author: kenn):
This got pushed from 2.16.0 to 2.17.0. That makes it seem that it is not a release blocker so it does not need Fix Version set. Correct?
> Support DoFns with Keyword-only arguments in Python 3.
> ------------------------------------------------------
>
> Key: BEAM-5878
> URL: https://issues.apache.org/jira/browse/BEAM-5878
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Assignee: yoshiki obata
> Priority: Minor
> Fix For: 2.17.0
>
> Time Spent: 15h
> Remaining Estimate: 0h
>
> Python 3.0 [adds a possibility|https://www.python.org/dev/peps/pep-3102/] to define functions with keyword-only arguments.
> Currently Beam does not handle them correctly. [~ruoyu] pointed out [one place|https://github.com/apache/beam/blob/a56ce43109c97c739fa08adca45528c41e3c925c/sdks/python/apache_beam/typehints/decorators.py#L118] in our codebase that we should fix: in Python in 3.0 inspect.getargspec() will fail on functions with keyword-only arguments, but a new method [inspect.getfullargspec()|https://docs.python.org/3/library/inspect.html#inspect.getfullargspec] supports them.
> There may be implications for our (best-effort) type-hints machinery.
> We should also add a Py3-only unit tests that covers DoFn's with keyword-only arguments once Beam Python 3 tests are in a good shape.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)