You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2022/10/10 09:50:07 UTC
[GitHub] [hive] ayushtkn commented on a diff in pull request #3652: HIVE-26614: Fix adding custom jars in Job Classpath.
ayushtkn commented on code in PR #3652:
URL: https://github.com/apache/hive/pull/3652#discussion_r991105608
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java:
##########
@@ -4158,7 +4158,7 @@ public static void addDependencyJars(Configuration conf, Class<?>... classes)
if (!localFs.exists(new Path(path))) {
throw new RuntimeException("Could not validate jar file " + path + " for class " + clazz);
}
- jars.add(path);
+ jars.add(localFs.makeQualified(new Path(path)).toString());
Review Comment:
No, I don't think that will work. It will make it qualified with respect to the FileSystem specified in `Fs.defaultFs` and will lead to the same problem. We need to make it qualified with respect to the `LocalFileSystem`
From the Javadoc
```
* @return path qualified relative to default file system
*/
public static Path makeQualified(Path path, Configuration conf) throws IOException {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org