You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/06 14:35:01 UTC

[GitHub] [flink] wangxlong edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource

wangxlong edited a comment on issue #10769: [FLINK-15479]Override explainSource method for JDBCTableSource
URL: https://github.com/apache/flink/pull/10769#issuecomment-571039643
 
 
   > Hi @wangxlong , What I mean:
   > 
   > 1. If we fix it in `JDBCTableSource`, it should be in 1.10 and 1.9.
   > 2. If we fix it in `TableSource`, it should be in 1.11.
   > 
   > Option 1 and Option 2 can be two things to finish. (We can do option 1 in 1.10 and 1.9, do option 2 in master)
   
   @JingsongLi I am sorry. It is my misunderstanding. I have added a test.
   
   Should I close this, and then open two pull request against release-1.9 and release-1.10? Or we can also do option1 on master, This maybe not conflict with option2?
   
   BTW, Should I open a JIRA to discuss  option2?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services