You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2018/03/21 19:39:02 UTC
[kudu-CR] pprof: fix /pprof/contention to work with the go version of pprof
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9741
to review the following change.
Change subject: pprof: fix /pprof/contention to work with the go version of pprof
......................................................................
pprof: fix /pprof/contention to work with the go version of pprof
The old perl version of pprof that ships with gperftools is no longer
maintained. It's been replaced by github.com/google/pprof which is
written in go.
The go version is slightly pickier about the output than the old perl
version. This patch updates a few things so that the new version works
with the /pprof/contention profile:
- the expected first line format is slightly different
- hex addresses must be prefixed with '0x'
- memory maps needs a section header ahead of it
- cycles/second needs to be formatted as an integer, not float
I verified that with this patch I was able to run the following:
pprof -seconds=1 http://localhost:8050/pprof/contention
... and got a reasonable looking profile when running under load
Change-Id: Ie25b2332688575c57be10b437566adb3f0c156e3
---
M src/kudu/server/pprof_path_handlers.cc
M src/kudu/util/debug-util.cc
M src/kudu/util/debug-util.h
M src/kudu/util/spinlock_profiling.cc
4 files changed, 27 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/9741/1
--
To view, visit http://gerrit.cloudera.org:8080/9741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie25b2332688575c57be10b437566adb3f0c156e3
Gerrit-Change-Number: 9741
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] pprof: fix /pprof/contention to work with the go version of pprof
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9741
to look at the new patch set (#2).
Change subject: pprof: fix /pprof/contention to work with the go version of pprof
......................................................................
pprof: fix /pprof/contention to work with the go version of pprof
The old perl version of pprof that ships with gperftools is no longer
maintained. It's been replaced by github.com/google/pprof which is
written in go.
The go version is slightly pickier about the output than the old perl
version. This patch updates a few things so that the new version works
with the /pprof/contention profile:
- the expected first line format is slightly different
- hex addresses must be prefixed with '0x', no tab characters expected
- memory maps needs a section header ahead of it
- cycles/second needs to be formatted as an integer, not float
I verified that with this patch I was able to run the following:
pprof -seconds=1 http://localhost:8050/pprof/contention
... and got a reasonable looking profile when running under load.
It also appears that the old perl pprof is still forgiving enough to
handle this new format.
Change-Id: Ie25b2332688575c57be10b437566adb3f0c156e3
---
M src/kudu/server/pprof_path_handlers.cc
M src/kudu/util/debug-util.cc
M src/kudu/util/debug-util.h
M src/kudu/util/spinlock_profiling-test.cc
M src/kudu/util/spinlock_profiling.cc
5 files changed, 28 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/9741/2
--
To view, visit http://gerrit.cloudera.org:8080/9741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie25b2332688575c57be10b437566adb3f0c156e3
Gerrit-Change-Number: 9741
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] pprof: fix /pprof/contention to work with the go version of pprof
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9741 )
Change subject: pprof: fix /pprof/contention to work with the go version of pprof
......................................................................
pprof: fix /pprof/contention to work with the go version of pprof
The old perl version of pprof that ships with gperftools is no longer
maintained. It's been replaced by github.com/google/pprof which is
written in go.
The go version is slightly pickier about the output than the old perl
version. This patch updates a few things so that the new version works
with the /pprof/contention profile:
- the expected first line format is slightly different
- hex addresses must be prefixed with '0x', no tab characters expected
- memory maps needs a section header ahead of it
- cycles/second needs to be formatted as an integer, not float
I verified that with this patch I was able to run the following:
pprof -seconds=1 http://localhost:8050/pprof/contention
... and got a reasonable looking profile when running under load.
It also appears that the old perl pprof is still forgiving enough to
handle this new format.
Change-Id: Ie25b2332688575c57be10b437566adb3f0c156e3
Reviewed-on: http://gerrit.cloudera.org:8080/9741
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <as...@cloudera.com>
---
M src/kudu/server/pprof_path_handlers.cc
M src/kudu/util/debug-util.cc
M src/kudu/util/debug-util.h
M src/kudu/util/spinlock_profiling-test.cc
M src/kudu/util/spinlock_profiling.cc
5 files changed, 28 insertions(+), 11 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie25b2332688575c57be10b437566adb3f0c156e3
Gerrit-Change-Number: 9741
Gerrit-PatchSet: 3
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] pprof: fix /pprof/contention to work with the go version of pprof
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9741 )
Change subject: pprof: fix /pprof/contention to work with the go version of pprof
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9741
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie25b2332688575c57be10b437566adb3f0c156e3
Gerrit-Change-Number: 9741
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 22 Mar 2018 18:03:00 +0000
Gerrit-HasComments: No