[GitHub] [hbase] joshelser commented on a change in pull request #1761: HBASE-21406 "status 'replication'" should not show SINK if the cluste…

[GitBox <gi...@apache.org>]

joshelser commented on a change in pull request #1761:
URL: https://github.com/apache/hbase/pull/1761#discussion_r432173382



##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -835,12 +835,16 @@ def status(format, type)
           r_source_string = '       SOURCE:'
           r_load_sink = sl.getReplicationLoadSink
           next if r_load_sink.nil?
+          if (r_load_sink.getTimestampsOfLastAppliedOp() == r_load_sink.getTimeStampStarted())

Review comment:
       A comment here would also be very appreciated (e.g "If we have applied no operations since we've started replication, assume that we're not acting as a sink and don't print the normal information")

##########
File path: hbase-shell/src/main/ruby/hbase/admin.rb
##########
@@ -835,12 +835,16 @@ def status(format, type)
           r_source_string = '       SOURCE:'
           r_load_sink = sl.getReplicationLoadSink
           next if r_load_sink.nil?
+          if (r_load_sink.getTimestampsOfLastAppliedOp() == r_load_sink.getTimeStampStarted())

Review comment:
       nit: Can drop the wrapping parens




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org