You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/06/18 09:22:14 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request, #36906: [SPARK-39508][CORE][PYTHON] Use IPv6 between JVM and Python Daemon in PySpark
dongjoon-hyun opened a new pull request, #36906:
URL: https://github.com/apache/spark/pull/36906
### What changes were proposed in this pull request?
This PR aims to use `IPv6` between Spark and Python Daemon in IPv6-only system.
### Why are the changes needed?
Currently, PySpark uses `127.0.0.1` for inter-communication between Python Daemon and JVM.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass the CIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #36906: [SPARK-39508][CORE][PYTHON] Support IPv6 between JVM and Python Daemon in PySpark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36906:
URL: https://github.com/apache/spark/pull/36906#issuecomment-1159829468
Will review this today or tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #36906: [SPARK-39508][CORE][PYTHON] Support IPv6 between JVM and Python Daemon in PySpark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #36906: [SPARK-39508][CORE][PYTHON] Support IPv6 between JVM and Python Daemon in PySpark
URL: https://github.com/apache/spark/pull/36906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #36906: [SPARK-39508][CORE][PYTHON] Use IPv6 between JVM and Python Daemon in PySpark
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #36906:
URL: https://github.com/apache/spark/pull/36906#discussion_r900767919
##########
core/src/main/scala/org/apache/spark/security/SocketAuthServer.scala:
##########
@@ -49,7 +49,7 @@ private[spark] abstract class SocketAuthServer[T](
private def startServer(): (Int, String) = {
logTrace("Creating listening socket")
- val serverSocket = new ServerSocket(0, 1, InetAddress.getByAddress(Array(127, 0, 0, 1)))
+ val serverSocket = new ServerSocket(0, 1, InetAddress.getLoopbackAddress())
Review Comment:
This is #36905 and I'll rebase this PR after merging #36905.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #36906: [SPARK-39508][CORE][PYTHON] Support IPv6 between JVM and Python Daemon in PySpark
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #36906:
URL: https://github.com/apache/spark/pull/36906#issuecomment-1159919439
Thank you so much, @HyukjinKwon !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #36906: [SPARK-39508][CORE][PYTHON] Support IPv6 between JVM and Python Daemon in PySpark
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #36906:
URL: https://github.com/apache/spark/pull/36906#issuecomment-1159640627
Hi, @HyukjinKwon . How do you think about this PR? This is a preparation for PySpark UTs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #36906: [SPARK-39508][CORE][PYTHON] Support IPv6 between JVM and Python Daemon in PySpark
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #36906:
URL: https://github.com/apache/spark/pull/36906#issuecomment-1159589857
Rebased to the master in order to bring #36905 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #36906: [SPARK-39508][CORE][PYTHON] Support IPv6 between JVM and Python Daemon in PySpark
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #36906:
URL: https://github.com/apache/spark/pull/36906#issuecomment-1159848661
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org