[jira] [Commented] (BIGTOP-2856) [sandbox] Add a condition in detect_repo()

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16118408#comment-16118408 ] 

ASF GitHub Bot commented on BIGTOP-2856:
----------------------------------------

Github user evans-ye commented on a diff in the pull request:

    https://github.com/apache/bigtop/pull/259#discussion_r131934559
  
    --- Diff: docker/sandbox/build.sh ---
    @@ -65,7 +65,11 @@ generate_tag() {
     
     detect_repo() {
         OS_SEP_BY_SLASH=${OS/-//}
    -    REPO=${REPO:-"http://bigtop-repos.s3.amazonaws.com/releases/${BIGTOP_VERSION}/${OS_SEP_BY_SLASH}/x86_64"}
    +    if [ $HOSTTYPE = "aarch64" ] ; then
    +       REPO=${REPO:-"http://bigtop-repos.s3.amazonaws.com/releases/${BIGTOP_VERSION}/${OS_SEP_BY_SLASH}/aarch64"}
    +    else
    +       REPO=${REPO:-"http://bigtop-repos.s3.amazonaws.com/releases/${BIGTOP_VERSION}/${OS_SEP_BY_SLASH}/x86_64"}
    +    fi
    --- End diff --
    
    It seems we can put HOSTTYPE in the REPO variable directly since I got exactly "x86_64" on x86_64 systems.
    
    REPO=${REPO:-"http://bigtop-repos.s3.amazonaws.com/releases/${BIGTOP_VERSION}/${OS_SEP_BY_SLASH}/$HOSTTYPE"}
    
    How do you think?


> [sandbox] Add a condition in detect_repo()
> ------------------------------------------
>
>                 Key: BIGTOP-2856
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-2856
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: build, sandbox
>    Affects Versions: 1.2.0
>         Environment: AArch64 machine installed with Debian 8 AArch64 OS
>            Reporter: Naresh Bhat
>            Assignee: Naresh Bhat
>             Fix For: 1.3.0
>
>
> In  detect_repo() it is required to add a condition to detect the repository.  Without a condition, on AArch64 REPO is being directed to x86_64.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)