You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by Carsten Ziegeler <cz...@apache.org> on 2015/09/08 17:25:23 UTC
SCR 2.0.2 release?
Hi,
I'm planning to cut a SCR 2.0.2 release. It seems FELIX-4984 is still
under discussion. Should I wait for that one?
Regards
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org
Re: SCR 2.0.2 release?
Posted by Pierre De Rop <pi...@gmail.com>.
Hello Carsten,
Please take a look at FELIX-5028 before releasing, I just added a small
comment.
thank you;
/Pierre
On Tue, Sep 15, 2015 at 11:10 PM, Carsten Ziegeler <cz...@apache.org>
wrote:
> Am 15.09.15 um 19:09 schrieb David Jencks:
> > Well, I think there’s still the issue Peter seems to have reproduced on
> the bnd list. I didn’t have enough time to look at it last weekend and
> won’t next weekend. I _think_ the solution is going to be to use the
> abstract tracker framework to write a configuration tracker.
> >
> > I opened https://issues.apache.org/jira/browse/FELIX-5036 <
> https://issues.apache.org/jira/browse/FELIX-5036> to help make this more
> visible. I would rather this got fixed in the next release but if no one
> has time to look right now we could have a 2.0.4 soon if you are impatient
> for another rebase :-)
>
> I would love to have a release in the next two weeks, so I think I'll go
> for a 2.0.2 with what we have.
>
> >
> > I still have some more work I’d like to do on circular references, but
> since these should be avoided anyway I wouldn’t hold up the release for it.
>
> Ok, should we marked FELIX-4984 then for the release after 2.0.2 ?
>
> >
> > Are you OK with my formatting changes to SCRInfo?
>
> Yes, I'm ok with it - as you say it has all the relevant info and that's
> the important bit
>
> >
> > I haven’t been able to figure out how to get help to appear for the scr
> gogo command. I think that the only way to get it to work properly is to
> put the actual gogo command into a separate bundle that requires the gogo
> package and of course sdrInfo. I think we should do this….
> >
>
> Yepp, sounds logical to me, we can easily cut a 2.1.0 of the scr bundle
> with all these changes soon.
>
> Carsten
>
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziegeler@apache.org
>
Re: SCR 2.0.2 release?
Posted by Carsten Ziegeler <cz...@apache.org>.
Am 15.09.15 um 19:09 schrieb David Jencks:
> Well, I think there’s still the issue Peter seems to have reproduced on the bnd list. I didn’t have enough time to look at it last weekend and won’t next weekend. I _think_ the solution is going to be to use the abstract tracker framework to write a configuration tracker.
>
> I opened https://issues.apache.org/jira/browse/FELIX-5036 <https://issues.apache.org/jira/browse/FELIX-5036> to help make this more visible. I would rather this got fixed in the next release but if no one has time to look right now we could have a 2.0.4 soon if you are impatient for another rebase :-)
I would love to have a release in the next two weeks, so I think I'll go
for a 2.0.2 with what we have.
>
> I still have some more work I’d like to do on circular references, but since these should be avoided anyway I wouldn’t hold up the release for it.
Ok, should we marked FELIX-4984 then for the release after 2.0.2 ?
>
> Are you OK with my formatting changes to SCRInfo?
Yes, I'm ok with it - as you say it has all the relevant info and that's
the important bit
>
> I haven’t been able to figure out how to get help to appear for the scr gogo command. I think that the only way to get it to work properly is to put the actual gogo command into a separate bundle that requires the gogo package and of course sdrInfo. I think we should do this….
>
Yepp, sounds logical to me, we can easily cut a 2.1.0 of the scr bundle
with all these changes soon.
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org
Re: SCR 2.0.2 release?
Posted by David Jencks <da...@yahoo.com.INVALID>.
Well, I think there’s still the issue Peter seems to have reproduced on the bnd list. I didn’t have enough time to look at it last weekend and won’t next weekend. I _think_ the solution is going to be to use the abstract tracker framework to write a configuration tracker.
I opened https://issues.apache.org/jira/browse/FELIX-5036 <https://issues.apache.org/jira/browse/FELIX-5036> to help make this more visible. I would rather this got fixed in the next release but if no one has time to look right now we could have a 2.0.4 soon if you are impatient for another rebase :-)
I still have some more work I’d like to do on circular references, but since these should be avoided anyway I wouldn’t hold up the release for it.
Are you OK with my formatting changes to SCRInfo?
I haven’t been able to figure out how to get help to appear for the scr gogo command. I think that the only way to get it to work properly is to put the actual gogo command into a separate bundle that requires the gogo package and of course sdrInfo. I think we should do this….
thanks
david jencks
> On Sep 15, 2015, at 9:56 AM, Carsten Ziegeler <cz...@apache.org> wrote:
>
> It seems we have now fixed the most serious issues which we should get
> out asap.
>
> Is anything really preventing us from a release? (I think we can do all
> kinds of improvements in another release)
>
> Regards
> Carsten
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziegeler@apache.org
Re: SCR 2.0.2 release?
Posted by Carsten Ziegeler <cz...@apache.org>.
It seems we have now fixed the most serious issues which we should get
out asap.
Is anything really preventing us from a release? (I think we can do all
kinds of improvements in another release)
Regards
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org
Re: SCR 2.0.2 release?
Posted by Carsten Ziegeler <cz...@apache.org>.
I've updated the output now - but I personally do not like it that much.
Feel free to make it nicer whenever you have time :)
Regards
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org
Re: SCR 2.0.2 release?
Posted by David Jencks <da...@yahoo.com.INVALID>.
> On Sep 9, 2015, at 10:14 AM, Carsten Ziegeler <cz...@apache.org> wrote:
>
> Am 09.09.15 um 16:00 schrieb David Jencks:
>> I think that is still too confusing. I want to see both the description and the configuration in the summary listing What I wanted was more like
>>
>> <bundle id> <component name or maybe class> <enabled state>
>> [indent] <component id> <status> <configuration pid>
>
> Ok, pid can be an array - do you pick the one from the properties or the
> one from the component description?
This would be the one from the component configuration so you can see which (singleton) pids are used and what the factory pid is. The point is to make it easy to trace back to the actual config admin configuration(s) used.
>
>>
>> I work with mostly factory configurations that have multiple instances, so this will produce a neat list of all the instances of a component under its description and make it easy to skip to the next component. I don’t care that much about which fields, order, etc but I really want this 2-level display.
>>
> I did this first :) and it looked somehow ugly to me, but maybe that's
> personal taste.
>
>> I’m happy to do it, but probably not today :-)
>>
>
> I can give it another try today and see if I like it more :)
ok :-)
thanks
david jencks
>
> Carsten
>
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziegeler@apache.org
Re: SCR 2.0.2 release?
Posted by Carsten Ziegeler <cz...@apache.org>.
Am 09.09.15 um 16:00 schrieb David Jencks:
> I think that is still too confusing. I want to see both the description and the configuration in the summary listing What I wanted was more like
>
> <bundle id> <component name or maybe class> <enabled state>
> [indent] <component id> <status> <configuration pid>
Ok, pid can be an array - do you pick the one from the properties or the
one from the component description?
>
> I work with mostly factory configurations that have multiple instances, so this will produce a neat list of all the instances of a component under its description and make it easy to skip to the next component. I don’t care that much about which fields, order, etc but I really want this 2-level display.
>
I did this first :) and it looked somehow ugly to me, but maybe that's
personal taste.
> I’m happy to do it, but probably not today :-)
>
I can give it another try today and see if I like it more :)
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org
Re: SCR 2.0.2 release?
Posted by David Jencks <da...@yahoo.com.INVALID>.
I think that is still too confusing. I want to see both the description and the configuration in the summary listing What I wanted was more like
<bundle id> <component name or maybe class> <enabled state>
[indent] <component id> <status> <configuration pid>
I work with mostly factory configurations that have multiple instances, so this will produce a neat list of all the instances of a component under its description and make it easy to skip to the next component. I don’t care that much about which fields, order, etc but I really want this 2-level display.
I’m happy to do it, but probably not today :-)
thanks
david jencks
> On Sep 9, 2015, at 3:47 AM, Carsten Ziegeler <cz...@apache.org> wrote:
>
> I've changed the scr:list command now to make an output like this ( I
> abbreviated the package names just for this mail):
>
> BundleId Component Name Id State
> [ 235] o.a.s.get.DefaultGetServlet [ 541] [active ]
> [ 235] o.a.s.get.impl.DefaultHeadServlet [ 540] [active ]
> [ 235] o.a.s.get.impl.RedirectServlet [ 538] [active ]
> [ 235] o.a.s.get.info.SlingInfoServlet [ 539] [active ]
> [ 235] o.a.s.get.impl.version.VersionInfoServlet -- --
>
> So, if a component description has no configuration, it's
> [ 235] o.a.s.get.impl.version.VersionInfoServlet -- --
>
> Otherwise for each component configuration it outputs the id and name.
>
> I played with different output formats like first outputting the
> description and then the configurations (if any), but decided to go with
> a single list as this looks much nicer.
>
> WDYT?
>
> Carsten
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziegeler@apache.org
Re: SCR 2.0.2 release?
Posted by Carsten Ziegeler <cz...@apache.org>.
I've changed the scr:list command now to make an output like this ( I
abbreviated the package names just for this mail):
BundleId Component Name Id State
[ 235] o.a.s.get.DefaultGetServlet [ 541] [active ]
[ 235] o.a.s.get.impl.DefaultHeadServlet [ 540] [active ]
[ 235] o.a.s.get.impl.RedirectServlet [ 538] [active ]
[ 235] o.a.s.get.info.SlingInfoServlet [ 539] [active ]
[ 235] o.a.s.get.impl.version.VersionInfoServlet -- --
So, if a component description has no configuration, it's
[ 235] o.a.s.get.impl.version.VersionInfoServlet -- --
Otherwise for each component configuration it outputs the id and name.
I played with different output formats like first outputting the
description and then the configurations (if any), but decided to go with
a single list as this looks much nicer.
WDYT?
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org
Re: SCR 2.0.2 release?
Posted by Carsten Ziegeler <cz...@apache.org>.
Am 08.09.15 um 21:43 schrieb David Jencks:
>
>>
>> Hmm, maybe, I just brought it back to a more compact from which is close
>> to the old form.
>
> The old form is completely bogus as it relies on the old introspection framework conflating description and configuration and creating a “configuration” to represent a description if there isn’t an actual one. We can’t do this any more :-)
>
Right, I've reopened FELIX-5001 and will come up with a better output
fitting the model
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org
Re: SCR 2.0.2 release?
Posted by David Jencks <da...@yahoo.com.INVALID>.
> On Sep 8, 2015, at 2:45 PM, Carsten Ziegeler <cz...@apache.org> wrote:
>
> Am 08.09.15 um 17:49 schrieb David Jencks:
>> There are several things I’d like to fix before the next release
>> - ScrIInfo formatting (affecting gogo and non-gogo console commands)
>> - possible issue with existing configurations mentioned on bnd[tools] list
>> - circular reference problem.
>>
> Ok, fair enough - do you have any rough timeline for this? :)
> If there are descriptions/issue on what to do I can probably help.
Well, hope springs eternal, maybe this weekend.
I don’t think the bndtools discussion resulted in a felix issue, but I think Peter has some way of reproducing the problem. I can never find him. Pursuing that would be helpful. From the area the problem is in my guess is that we should solve it by writing a ConfigurationTracker using the base tracker framework. I think the problem is of the kind trackers solve, where there are two sources of information, one push and one pull, and you need to reconcile them.
IIUC Pierre is going to commit a test for the circular dependency problem and maybe we can figure out exactly what to do beyond my proposal so far.
>
>> Also, I hadn’t realized you had modified SCRInfo. If I understand it,I don’t like your change :-) I would like the list command to show both the description and the configurations, but in highly abbreviated form:
>>
>> description
>> configuration1
>> configuration2
>>
>> etc.
>>
>> I believe your code has the problem that if a description is e.g. configuration required nothing will show up for it.
>
> Hmm, maybe, I just brought it back to a more compact from which is close
> to the old form.
The old form is completely bogus as it relies on the old introspection framework conflating description and configuration and creating a “configuration” to represent a description if there isn’t an actual one. We can’t do this any more :-)
thanks
david jencks
>
> Carsten
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziegeler@apache.org
Re: SCR 2.0.2 release?
Posted by Carsten Ziegeler <cz...@apache.org>.
Am 08.09.15 um 17:49 schrieb David Jencks:
> There are several things I’d like to fix before the next release
> - ScrIInfo formatting (affecting gogo and non-gogo console commands)
> - possible issue with existing configurations mentioned on bnd[tools] list
> - circular reference problem.
>
Ok, fair enough - do you have any rough timeline for this? :)
If there are descriptions/issue on what to do I can probably help.
> Also, I hadn’t realized you had modified SCRInfo. If I understand it,I don’t like your change :-) I would like the list command to show both the description and the configurations, but in highly abbreviated form:
>
> description
> configuration1
> configuration2
>
> etc.
>
> I believe your code has the problem that if a description is e.g. configuration required nothing will show up for it.
Hmm, maybe, I just brought it back to a more compact from which is close
to the old form.
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org
Re: SCR 2.0.2 release?
Posted by David Jencks <da...@gmail.com>.
There are several things I’d like to fix before the next release
- ScrIInfo formatting (affecting gogo and non-gogo console commands)
- possible issue with existing configurations mentioned on bnd[tools] list
- circular reference problem.
Also, I hadn’t realized you had modified SCRInfo. If I understand it,I don’t like your change :-) I would like the list command to show both the description and the configurations, but in highly abbreviated form:
description
configuration1
configuration2
etc.
I believe your code has the problem that if a description is e.g. configuration required nothing will show up for it.
thanks
david jencks
> On Sep 8, 2015, at 11:25 AM, Carsten Ziegeler <cz...@apache.org> wrote:
>
> Hi,
>
> I'm planning to cut a SCR 2.0.2 release. It seems FELIX-4984 is still
> under discussion. Should I wait for that one?
>
> Regards
> Carsten
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziegeler@apache.org