[GitHub] markusthoemmes commented on a change in pull request #3156: move PureConfig strings to PureConfigKeys singleton

[GitBox <gi...@apache.org>]

markusthoemmes commented on a change in pull request #3156: move PureConfig strings to PureConfigKeys singleton
URL: https://github.com/apache/incubator-openwhisk/pull/3156#discussion_r160188348
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/WhiskConfig.scala
 ##########
 @@ -244,4 +244,7 @@ object PureConfigKeys {
   val whiskKafkaTopics = "whisk.kafka.topics"
 
   val whiskDB = "whisk.db"
+
+  val whiskDockerTimeouts = "whisk.docker.timeouts"
+  val whiskRuncTimeouts = "whisk.runc.timeouts"
 
 Review comment:
   I feel like we should drop `Pure` since it's an implementation detail and `whisk` from all the names, forming:
   
   ```scala
   object ConfigKeys {
     val loadbalancer = "whisk.loadbalancer"
   
     val kafka = "whisk.kafka"
     val kafkaTopics = s"$kafka.topics"
   
     val db = "whisk.db"
   
     val docker = "whisk.docker"
     val dockerTimeouts = s"$docker.timeouts"
     val runc = "whisk.runc"
     val runcTimeouts = s"$runc.timeouts"
   }
   ```
   
   WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services