[GitHub] [bookkeeper] wenbingshen commented on a diff in pull request #3654: Fix numLedgersReplicated metric

[GitBox <gi...@apache.org>]

wenbingshen commented on code in PR #3654:
URL: https://github.com/apache/bookkeeper/pull/3654#discussion_r1068024524


##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/replication/TestReplicationWorker.java:
##########
@@ -1156,11 +1160,49 @@ public void testRWShutDownInTheCaseOfZKOperationFailures() throws Exception {
 
     @Test
     public void testRepairedNotAdheringPlacementPolicyLedgerFragmentsOnRack() throws Exception {
-        testRepairedNotAdheringPlacementPolicyLedgerFragments(RackawareEnsemblePlacementPolicy.class);
+        testRepairedNotAdheringPlacementPolicyLedgerFragments(RackawareEnsemblePlacementPolicy.class, null);
+    }
+
+    @Test
+    public void testReplicationStats() throws Exception {
+        BiConsumer<Boolean, ReplicationWorker> checkReplicationStats = (first, rw) -> {
+            try {
+                final Method rereplicate = rw.getClass().getDeclaredMethod("rereplicate");
+                rereplicate.setAccessible(true);
+                final Object[] objects = new Object[0];
+                final Object result = rereplicate.invoke(rw, objects);

Review Comment:
   @horizonzy Thanks. I have addressed it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org