You are viewing a plain text version of this content. The canonical link for it is here.

Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:30:07 UTC

[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #3568: ARTEMIS-3200 - remove braces from the belt and braces fix in ARTEMIS-…

clebertsuconic commented on a change in pull request #3568:
URL: https://github.com/apache/activemq-artemis/pull/3568#discussion_r649960211



##########
File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonAbstractReceiver.java
##########
@@ -285,13 +282,13 @@ protected void initializeCurrentLargeMessage(Delivery delivery, Receiver receive
    @Override
    public void close(boolean remoteLinkClose) throws ActiveMQAMQPException {
       protonSession.removeReceiver(receiver);
+      clearLargeMessage();

Review comment:
       @gtully can you change the whole method to removeReceiver and clear message upon remoteLinkClose=true?
   
   false here means it was a detach and not a remote close.
   I don't remember what a local detach would mean here.. but I guess it's better to be safe on this case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org