You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/24 04:51:56 UTC
[GitHub] [incubator-superset] mistercrunch opened a new issue #10418: [DRAFT!][SIP] Proposal for using eCharts as our main charting library
mistercrunch opened a new issue #10418:
URL: https://github.com/apache/incubator-superset/issues/10418
## [SIP] Proposal for using eCharts as our main charting library
### Motivation
When Superset was started back in 2015, the `d3` library was the clear choice for building data visualizations, and `nvd3` offered a nice set of reusable charts built on top of `d3` that allowed hooks and callbacks that integrated nicely with `d3` primitives. Over the past few years, the library has not been maintained actively and we've had to fork the project recently to ensure we could fix some bugs and to put it on life support. We got a lot of mileage out of the library and we're grateful for that, but it's beyond time to move on.
Looking at the vast array of choice in the visualization libraries space here are some selection criteria:
* a vast library that offers a wide array of visualization types, but are consistent from a visual and an API standpoint
* a thriving, active and growing community
* a good governance model where we can get involved and have a path to contribute and influence direction
* a rich set of visualization primitives that enable extensibility
* performance: support for canvas rendering or alike
* "themeable"
* i18n support
### Proposed Change
eCharts!
<img width="1743" alt="Screen Shot 2020-07-23 at 9 32 21 PM" src="https://user-images.githubusercontent.com/487433/88360869-05ee9b80-cd2c-11ea-9ef9-5c605abf1462.png">
This library checks all the boxes stated above and more:
* one of the most vast library out there
* governance: eCharts is also incubating at the Apache Software Foundation
### New or Changed Public Interfaces
We'll be leveraging the plugin interface that has recently settled.
### New dependencies
The echarts library is surprisingly nimble and only depends on its rendering engine `zrender` which is managed and maintained by the same group of people. In the longer run, this could really help simplify our dependency tree and the risks that come with that, and perhaps help reduce our bundle sizes.
### Migration Plan and Compatibility
The idea is to create new visualizations plugin that use eCharts and to progressively replace the existing visualizations with eCharts-powered visualizations. We may use one or many feature flag or other mechanisms to let administrator decide which set of charts they want to use in their environments while eCharts visualizations are maturing. We should also offer a migration path (through a database migration) to help our users migrate to the new core charts as they become core.
### Rejected Alternatives
The hundreds of other amazing chart libraries out there. These can still be developed as plugins or plugins pack and shared as part of our growing plugin ecosystem. While we welcome for different plugins and plugin packs to be developed and shared by the community, this SIP is about setting the vision for the future of the core libraries that ship with Superset.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] x670 commented on issue #10418: [SIP-50] Proposal for using ECharts as our main charting library
Posted by GitBox <gi...@apache.org>.
x670 commented on issue #10418:
URL: https://github.com/apache/incubator-superset/issues/10418#issuecomment-690077181
Will this library solve **epic** problem with non temporal line charts?
If it is, I am for it!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on issue #10418: [SIP-50] Proposal for using ECharts as our main charting library
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #10418:
URL: https://github.com/apache/incubator-superset/issues/10418#issuecomment-694703114
@isunix we have already implemented a [new ECharts based chart](https://github.com/apache/incubator-superset/pull/10752) that can do line, area, bar and scatterplot for timeseries data. This is currently only available on `master` branch, but will be available on the forthcoming `0.38` release. In the next few days we also expect to replace the current pie chart with an [ECharts based Pie Chart](https://github.com/apache-superset/superset-ui/pull/772) replacement. Stay tuned for more charts to follow! Also, if you want to help speed up the migration process by collaborating on new charts, don't hesitate to be in touch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on issue #10418: [SIP-50] Proposal for using ECharts as our main charting library
Posted by GitBox <gi...@apache.org>.
ktmud commented on issue #10418:
URL: https://github.com/apache/incubator-superset/issues/10418#issuecomment-665369726
@amitNielsen while the React API is nice, I don't think Recharts is particularly more customizable than ECharts. What you can do with Recharts is also limited by what API is provided by the **React components**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] rusackas commented on issue #10418: [SIP-50] Proposal for using ECharts as our main charting library
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #10418:
URL: https://github.com/apache/incubator-superset/issues/10418#issuecomment-665446027
FWIW, I haven't found a need to use the react wrapper for eCharts thus far. A `useEffect` hook with a `ref` seems to work just great for Superset's purposes.
It's worth re-mentioning, this SIP is to use ECharts as the _main_ charting library, particularly for the core plugins, but not necessarily the _only_ one on the table for use in Superset. As mentioned in the SIP, this decisoun should not preclude people from creating plugins using alternate libraries. In fact, I'm hyped up about it! We just need to figure out how/where to support those plugins, which is another discussion taking shape on Slack.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud edited a comment on issue #10418: [SIP-50] Proposal for using ECharts as our main charting library
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on issue #10418:
URL: https://github.com/apache/incubator-superset/issues/10418#issuecomment-664547858
> a) echarts does not seem to offer any dedicated visualizations for tables / pivot- tables ; is there a plan to leverage other libraries to improve this kind of data display (especially in terms of conditional formatting etc.)
We just had [a big refactor on table chart](https://github.com/apache/incubator-superset/pull/10113) and plan to do the same for pivot tables. You may not notice the difference but it paved ways for advanced features such as conditional formatting. No library provides conditional formatting out of the box, the majority of the work lies within Superset itself, so it doesn't really matter which library we use for this specific feature.
> b) will the move enable non temporal x-axis on line/bar charts, or is this an underlying issue not related to the charting library itself? #4185
We didn't prioritize non temporal x-axis because we didn't want to keep building new stuff based on nvd3, which we know will soon be deprecated. Once we start migrating line chart to Echarts (or any other better maintained libraries we eventually decide on), we'll be sure to add this to the TODO-list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #10418: [SIP-50] Proposal for using ECharts as our main charting library
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #10418:
URL: https://github.com/apache/incubator-superset/issues/10418#issuecomment-668120313
VOTING HAS STARTED - see the `dev@` mailing list!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] dingsheng999888 commented on issue #10418: [DRAFT!][SIP-50] Proposal for using ECharts as our main charting library
Posted by GitBox <gi...@apache.org>.
dingsheng999888 commented on issue #10418:
URL: https://github.com/apache/incubator-superset/issues/10418#issuecomment-663798012
Very good!This is what I want.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro edited a comment on issue #10418: [SIP-50] Proposal for using ECharts as our main charting library
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on issue #10418:
URL: https://github.com/apache/incubator-superset/issues/10418#issuecomment-694703114
@isunix we have already implemented a [new ECharts based Timeseries Chart](https://github.com/apache/incubator-superset/pull/10752) that can do line, area, bar and scatterplot. This is currently only available on `master` branch, but will be available on the forthcoming `0.38` release. In the next few days we also expect to replace the current pie chart with an [ECharts based Pie Chart](https://github.com/apache-superset/superset-ui/pull/772) replacement. Stay tuned for more charts to follow! Also, if you want to help speed up the migration process by collaborating on new charts, don't hesitate to be in touch!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] isunix commented on issue #10418: [SIP-50] Proposal for using ECharts as our main charting library
Posted by GitBox <gi...@apache.org>.
isunix commented on issue #10418:
URL: https://github.com/apache/incubator-superset/issues/10418#issuecomment-694699291
When we can use echarts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] carstenkolve commented on issue #10418: [SIP-50] Proposal for using ECharts as our main charting library
Posted by GitBox <gi...@apache.org>.
carstenkolve commented on issue #10418:
URL: https://github.com/apache/incubator-superset/issues/10418#issuecomment-664612542
Thanks for the heads up - I appreciate the transparency and quick feedback!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #10418: [DRAFT!][SIP] Proposal for using eCharts as our main charting library
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #10418:
URL: https://github.com/apache/incubator-superset/issues/10418#issuecomment-663345531
Issue-Label Bot is automatically applying the label `#enhancement` to this issue, with a confidence of 0.86. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] isunix commented on issue #10418: [SIP-50] Proposal for using ECharts as our main charting library
Posted by GitBox <gi...@apache.org>.
isunix commented on issue #10418:
URL: https://github.com/apache/incubator-superset/issues/10418#issuecomment-685224010
Hope we can use ECharts in Superset very soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] isunix commented on issue #10418: [SIP-50] Proposal for using ECharts as our main charting library
Posted by GitBox <gi...@apache.org>.
isunix commented on issue #10418:
URL: https://github.com/apache/incubator-superset/issues/10418#issuecomment-701105889
@villebro Thank you for replying to me. Yes we need ECharts very much. May I ask when will the 0.38 be available to us?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro edited a comment on issue #10418: [SIP-50] Proposal for using ECharts as our main charting library
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on issue #10418:
URL: https://github.com/apache/incubator-superset/issues/10418#issuecomment-664575519
> b) will the move enable non temporal x-axis on line/bar charts, or is this an underlying issue not related to the chartiung library itself? #4185
No formal decisions have yet been made on what features the new charts will have. But I think we'll be moving in the direction of introducing an ECharts based time series chart, that incorporates the main features of the current line, bar and area chart, also adding some new functionality that doesn't exist in the current charts, like forecasting capabilities. To complement that I think it makes sense to introduce a similar one with a non-temporal x-axis that makes it possible to use categorical or numeric values. However, I stress that we are still in early stages, so this plan might change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] amitNielsen commented on issue #10418: [SIP-50] Proposal for using ECharts as our main charting library
Posted by GitBox <gi...@apache.org>.
amitNielsen commented on issue #10418:
URL: https://github.com/apache/incubator-superset/issues/10418#issuecomment-664968485
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] johnoscott commented on issue #10418: [SIP-50] Proposal for using ECharts as our main charting library
Posted by GitBox <gi...@apache.org>.
johnoscott commented on issue #10418:
URL: https://github.com/apache/incubator-superset/issues/10418#issuecomment-685244215
If this move means accelerating chart progress then I am for it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] zcfrank1st commented on issue #10418: [DRAFT!][SIP-50] Proposal for using ECharts as our main charting library
Posted by GitBox <gi...@apache.org>.
zcfrank1st commented on issue #10418:
URL: https://github.com/apache/incubator-superset/issues/10418#issuecomment-663976364
I just developped myself using echarts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org