You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "erisu (via GitHub)" <gi...@apache.org> on 2026/06/24 13:16:05 UTC
[PR] fix(addBuildPhase): adding of PBXBuildFile entries to lookup table [cordova-node-xcode]
erisu opened a new pull request, #174:
URL: https://github.com/apache/cordova-node-xcode/pull/174
- Add `PBXBuildFile` entry to `filePathToBuildFile` lookup table when a valid identifier is present.
- Valid identifier is determined when the `fileReference` has either a `path` or `name` property value.
- The `path` property takes priority when both `path` and `name` are defined.
- When the `path` and `name` properties are not defined the entry is not added to the lookup table.
---
Additionally, this PR
- Added some in-code documentation.
- Using JSDocs
- Added a basic example
---
The main purpose of this PR is to resolve and close PR #140.
PR #140 was attempting to resolve a failure that occurred when looping through build files to create the `filePathToBuildFile` lookup table, where a file reference did not have `path` defined. The PR attempted to resolve this by skipping when the `path` property of the file reference was missing.
There are cases where `name` can be used instead of `path`. In those cases, `name` appears to serve as the file path, with path resolution determined by the file reference's `sourceTree`. But generally, `name` often matches the file name.
Same issue was reported here: https://github.com/apache/cordova-ios/issues/1357
This PR takes a different approach and check if either `path` or `name` is defined before it skipped the build file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix(addBuildPhase): adding of PBXBuildFile entries to lookup table [cordova-node-xcode]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #174:
URL: https://github.com/apache/cordova-node-xcode/pull/174#issuecomment-4789690562
## [Codecov](https://app.codecov.io/gh/apache/cordova-node-xcode/pull/174?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 97.34%. Comparing base ([`04fc2dd`](https://app.codecov.io/gh/apache/cordova-node-xcode/commit/04fc2ddac090a695b5ff2a3352236df25a70bc0a?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`1a38327`](https://app.codecov.io/gh/apache/cordova-node-xcode/commit/1a38327c3807cd07d838c2a2bfaec51bf454fb46?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #174 +/- ##
==========================================
+ Coverage 97.31% 97.34% +0.02%
==========================================
Files 51 51
Lines 10968 11058 +90
==========================================
+ Hits 10674 10764 +90
Misses 294 294
```
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/cordova-node-xcode/pull/174?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] fix(addBuildPhase): adding of PBXBuildFile entries to lookup table [cordova-node-xcode]
Posted by "erisu (via GitHub)" <gi...@apache.org>.
erisu merged PR #174:
URL: https://github.com/apache/cordova-node-xcode/pull/174
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org