You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "GOODBOY008 (via GitHub)" <gi...@apache.org> on 2024/04/20 14:16:18 UTC
[PR] [FLINK-35182] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.1 for Flink Pulsar connector [flink-connector-pulsar]
GOODBOY008 opened a new pull request, #90:
URL: https://github.com/apache/flink-connector-pulsar/pull/90
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35182] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.1 for Flink Pulsar connector [flink-connector-pulsar]
Posted by "syhily (via GitHub)" <gi...@apache.org>.
syhily commented on PR #90:
URL: https://github.com/apache/flink-connector-pulsar/pull/90#issuecomment-2081289722
@tisonkun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35182] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.1 for Flink Pulsar connector [flink-connector-pulsar]
Posted by "syhily (via GitHub)" <gi...@apache.org>.
syhily commented on code in PR #90:
URL: https://github.com/apache/flink-connector-pulsar/pull/90#discussion_r1581009843
##########
flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/testutils/SampleData.java:
##########
@@ -49,7 +49,7 @@ public Foo() {}
@Override
public String toString() {
- return "" + i + "," + f + "," + (bar == null ? "null" : bar.toString());
+ return i + "," + f + "," + (bar == null ? "null" : bar.toString());
Review Comment:
I prefer to do only one thing in one PR. This refactor shouldn't be included in the version bump.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35182] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.1 for Flink Pulsar connector [flink-connector-pulsar]
Posted by "GOODBOY008 (via GitHub)" <gi...@apache.org>.
GOODBOY008 commented on code in PR #90:
URL: https://github.com/apache/flink-connector-pulsar/pull/90#discussion_r1581286005
##########
flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/testutils/SampleData.java:
##########
@@ -49,7 +49,7 @@ public Foo() {}
@Override
public String toString() {
- return "" + i + "," + f + "," + (bar == null ? "null" : bar.toString());
+ return i + "," + f + "," + (bar == null ? "null" : bar.toString());
Review Comment:
Because ci failed ,I just modify code to trigger ci. Now,This code had been reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35182] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.1 for Flink Pulsar connector [flink-connector-pulsar]
Posted by "syhily (via GitHub)" <gi...@apache.org>.
syhily commented on code in PR #90:
URL: https://github.com/apache/flink-connector-pulsar/pull/90#discussion_r1574953259
##########
pom.xml:
##########
@@ -397,6 +397,20 @@ under the License.
<version>${commons-compress.version}</version>
</dependency>
+ <!-- For dependency convergence -->
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ <version>3.14.0</version>
+ </dependency>
+
+ <!-- For dependency convergence -->
+ <dependency>
+ <groupId>commons-io</groupId>
+ <artifactId>commons-io</artifactId>
+ <version>2.15.1</version>
Review Comment:
Move the version to the properties.
##########
pom.xml:
##########
@@ -397,6 +397,20 @@ under the License.
<version>${commons-compress.version}</version>
</dependency>
+ <!-- For dependency convergence -->
+ <dependency>
+ <groupId>org.apache.commons</groupId>
+ <artifactId>commons-lang3</artifactId>
+ <version>3.14.0</version>
Review Comment:
Move the version to the properties.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35182] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.1 for Flink Pulsar connector [flink-connector-pulsar]
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun merged PR #90:
URL: https://github.com/apache/flink-connector-pulsar/pull/90
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35182] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.1 for Flink Pulsar connector [flink-connector-pulsar]
Posted by "syhily (via GitHub)" <gi...@apache.org>.
syhily commented on PR #90:
URL: https://github.com/apache/flink-connector-pulsar/pull/90#issuecomment-2080596125
OK, LGTM. We need to get the CI pass, finally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-35182] Bump org.apache.commons:commons-compress from 1.24.0 to 1.26.1 for Flink Pulsar connector [flink-connector-pulsar]
Posted by "GOODBOY008 (via GitHub)" <gi...@apache.org>.
GOODBOY008 commented on PR #90:
URL: https://github.com/apache/flink-connector-pulsar/pull/90#issuecomment-2080904045
@syhily CI passed~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org