You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "faner11 (via GitHub)" <gi...@apache.org> on 2023/06/02 10:17:13 UTC

[GitHub] [echarts] faner11 opened a new issue, #18707: [Feature] Can we freely decide between thousandSeparator and decimalSeparator?

faner11 opened a new issue, #18707:
URL: https://github.com/apache/echarts/issues/18707

   ### What problem does this feature solve?
   
   I am a developer serving the Brazilian market, where thousandSeparator is '.' , decimalSeparator is ',', now it is possible to use formatter to reach the target, but it is not possible to configure it globally, which is a pain
   
   https://github.com/apache/echarts/blob/master/src/util/format.ts#L32
   
   ### What does the proposed API look like?
   
   const opts = {
     formatterConfig: {
       thousandSeparator: ',',
       decimalSeparator: '.',
     },
   }


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] faner11 commented on issue #18707: [Feature] Can we freely decide between thousandSeparator and decimalSeparator?

Posted by "faner11 (via GitHub)" <gi...@apache.org>.
faner11 commented on issue #18707:
URL: https://github.com/apache/echarts/issues/18707#issuecomment-1575546025

   > How about this [Demo Code](https://echarts.apache.org/examples/en/editor.html?c=line-simple&code=GYIwTgBAvBAUAOBKaA-CBvAUBCYCmALgK5gB2E8AdAG4CGANkXpQQPYAyrAxg3gMoEwAS1IBzWAHJ4BALQAhAEoSANBggBbWgA8h6ouoBiYWlwJDWpACJDRQggGcAXBABMEAL6IA3Jnc_W0ubkMFg4WgCCOk4Y2DgQACa0BLTOANoSALIWKhASACpMORIA6njxRXkAFkRFRkJFfEkNRKQSALqx7sqxAJ6RQtGhcfY89HjOgkzdcRDaA-y0IHj0zkMzwKxgmgQEeGDOCMhQaGszuIQk5FRsnKP8giLiUrKKOegac3qGxqZB1rYOZwARg83liM3c4I8nWmEDYrHoZngqwgGy2SV2-1R4A8sPseyEeGiqShpxwiWSaSBAFYAAy0ygADkZqiBLgAzAyACxc1kuFxcygATiFfKBLIgQKB7OpqhFQuFoslUqBbVhMwIPXg41y9BEeBUUJw9h66hACL4QgAXjqXLT1XF6Itlij7JVWAB3CZgKaozbbTHOUCQSEQ2IdPxAA) ? ![image](https://user-images.githubusercontent.com/13038071/243132078-bbae95aa-207a-4087-8ec1-42a06ebc0318.png)
   
   Yes, but this requires specifying the formatter in each place where it is used, which is painful to maintain when there are many charts, so I hope there is a global configuration place


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] helgasoft commented on issue #18707: [Feature] Can we freely decide between thousandSeparator and decimalSeparator?

Posted by "helgasoft (via GitHub)" <gi...@apache.org>.
helgasoft commented on issue #18707:
URL: https://github.com/apache/echarts/issues/18707#issuecomment-1574338541

   Try [registerLocale](https://echarts.apache.org/en/api.html#echarts.registerLocale) with [/src/i18n/langPT-br.ts](https://github.com/apache/echarts/blob/release/src/i18n/langPT-br.ts) ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] helgasoft commented on issue #18707: [Feature] Can we freely decide between thousandSeparator and decimalSeparator?

Posted by "helgasoft (via GitHub)" <gi...@apache.org>.
helgasoft commented on issue #18707:
URL: https://github.com/apache/echarts/issues/18707#issuecomment-1575187976

   How about this [Demo Code](https://echarts.apache.org/examples/en/editor.html?c=line-simple&code=GYIwTgBAvBAUAOBKaA-CBvAUBCYCmALgK5gB2E8AdAG4CGANkXpQQPYAyrAxg3gMoEwAS1IBzWAHJ4BALQAhAEoSANBggBbWgA8h6ouoBiYWlwJDWpACJDRQggGcAXBABMEAL6IA3Jnc_W0ubkMFg4WgCCOk4Y2DgQACa0BLTOANoSALIWKhASACpMORIA6njxRXkAFkRFRkJFfEkNRKQSALqx7sqxAJ6RQtGhcfY89HjOgkzdcRDaA-y0IHj0zkMzwKxgmgQEeGDOCMhQaGszuIQk5FRsnKP8giLiUrKKOegac3qGxqZB1rYOZwARg83liM3c4I8nWmEDYrHoZngqwgGy2SV2-1R4A8sPseyEeGiqShpxwiWSaSBAFYAAy0ygADkZqiBLgAzAyACxc1kuFxcygATiFfKBLIgQKB7OpqhFQuFoslUqBbVhMwIPXg41y9BEeBUUJw9h66hACL4QgAXjqXLT1XF6Itlij7JVWAB3CZgKaozbbTHOUCQSEQ2IdPxAA) ?
   ![image](https://github.com/apache/echarts/assets/13038071/bbae95aa-207a-4087-8ec1-42a06ebc0318)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] faner11 commented on issue #18707: [Feature] Can we freely decide between thousandSeparator and decimalSeparator?

Posted by "faner11 (via GitHub)" <gi...@apache.org>.
faner11 commented on issue #18707:
URL: https://github.com/apache/echarts/issues/18707#issuecomment-1574839230

   > Try [registerLocale](https://echarts.apache.org/en/api.html#echarts.registerLocale) with [/src/i18n/langPT-br.ts](https://github.com/apache/echarts/blob/release/src/i18n/langPT-br.ts) ?
   
   Yes, langPT-br.ts is just a copywriting change, but the actual number display is still the standard in English, for example the number "1,000.99", in Brazil would be written as '1.000,99', I hope to achieve this effect


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org