You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by clarkyzl <gi...@git.apache.org> on 2017/02/10 07:57:29 UTC
[GitHub] flink pull request #3292: [FLINK-5739] [client] fix NullPointerException in ...
GitHub user clarkyzl opened a pull request:
https://github.com/apache/flink/pull/3292
[FLINK-5739] [client] fix NullPointerException in CliFrontend
Type: Bug
Priority: Major
Problem Definition: CliFrontEnd throws a NullPointerException
Design:
see https://issues.apache.org/jira/browse/FLINK-5739
Client will throw a NullPointerException if use forgot to call method "execute()".
User may be confused by this NullPointerException. This patch adds a message here, and makes the NullPointerException meaningful.
Impact Analysis:
Only the client and messages are affected.
Test:
mvn clean verify has been done.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/clarkyzl/flink master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3292.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3292
----
commit 2921e4170502f54e1c2fb11e22cb2169deebe78e
Author: Zhuoluo Yang <zh...@alibaba-inc.com>
Date: 2017-02-10T07:22:50Z
[FLINK-5739] [client] fix NullPointerException in CliFrontend
commit db035643c782fb65c26efd10c8bf36d4173103f0
Author: Zhuoluo Yang <zh...@alibaba-inc.com>
Date: 2017-02-10T07:33:35Z
[FLINK-5739] [client] fix code style
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3292: [FLINK-5739] [client] fix NullPointerException in CliFron...
Posted by wuchong <gi...@git.apache.org>.
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3292
Thank you for fixing this. This issue is only occurred when submitting remotely.
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3292: [FLINK-5739] [client] fix NullPointerException in CliFron...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3292
Change looks good, thank you!
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3292: [FLINK-5739] [client] fix NullPointerException in CliFron...
Posted by wuchong <gi...@git.apache.org>.
Github user wuchong commented on the issue:
https://github.com/apache/flink/pull/3292
It seems that you introduced some commits not belong to this PR. You can try rebase your branch onto master (not merge).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3292: [FLINK-5739] [client] fix NullPointerException in ...
Posted by clarkyzl <gi...@git.apache.org>.
Github user clarkyzl commented on a diff in the pull request:
https://github.com/apache/flink/pull/3292#discussion_r100945289
--- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -842,6 +842,12 @@ protected int executeProgram(PackagedProgram program, ClusterClient client, int
program.deleteExtractedLibraries();
}
+ if (null == result) {
+ logAndSysout("No JobSubmissionResult returned, please make sure you called " +
--- End diff --
Added a space here and try again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3292: [FLINK-5739] [client] fix NullPointerException in ...
Posted by wuchong <gi...@git.apache.org>.
Github user wuchong commented on a diff in the pull request:
https://github.com/apache/flink/pull/3292#discussion_r100719358
--- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
@@ -842,6 +842,12 @@ protected int executeProgram(PackagedProgram program, ClusterClient client, int
program.deleteExtractedLibraries();
}
+ if (null == result) {
+ logAndSysout("No JobSubmissionResult returned, please make sure you called" +
--- End diff --
Please add a space at the end
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3292: [FLINK-5739] [client] fix NullPointerException in ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3292
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3292: [FLINK-5739] [client] fix NullPointerException in CliFron...
Posted by clarkyzl <gi...@git.apache.org>.
Github user clarkyzl commented on the issue:
https://github.com/apache/flink/pull/3292
Thanks a lot
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---