You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/03/07 07:04:18 UTC
Review Request 70150: Added a constructor for `ResourceQuantities`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70150/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
The constructor constructs `ResourceQuantities`
from `google::protobuf::Map<std::string, Value::Scalar>`.
It replaces one of the current constructors that takes
in `OfferFilters::ResourceQuantities`.
Diffs
-----
src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae
src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7
src/master/allocator/mesos/hierarchical.cpp 7085c23eeb163854712391e24d902902b8aaf162
Diff: https://reviews.apache.org/r/70150/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 70150: Replaced a constructor in
`ResourceQuantities`.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70150/
-----------------------------------------------------------
(Updated March 14, 2019, 4:57 p.m.)
Review request for mesos and Benjamin Mahler.
Changes
-------
Rebased.
Repository: mesos
Description
-------
The constructor constructs `ResourceQuantities`
from `google::protobuf::Map<std::string, Value::Scalar>`.
It replaces one of the current constructors that takes
in `OfferFilters::ResourceQuantities`.
Diffs (updated)
-----
src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae
src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7
src/master/allocator/mesos/hierarchical.cpp 7085c23eeb163854712391e24d902902b8aaf162
Diff: https://reviews.apache.org/r/70150/diff/3/
Changes: https://reviews.apache.org/r/70150/diff/2-3/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 70150: Added a constructor for
`ResourceQuantities`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70150/#review213513
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70061, 70062, 70069, 70063, 70148, 70149, 70150]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 6, 2019, 11:04 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70150/
> -----------------------------------------------------------
>
> (Updated March 6, 2019, 11:04 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The constructor constructs `ResourceQuantities`
> from `google::protobuf::Map<std::string, Value::Scalar>`.
> It replaces one of the current constructors that takes
> in `OfferFilters::ResourceQuantities`.
>
>
> Diffs
> -----
>
> src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae
> src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7
> src/master/allocator/mesos/hierarchical.cpp 7085c23eeb163854712391e24d902902b8aaf162
>
>
> Diff: https://reviews.apache.org/r/70150/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>
Re: Review Request 70150: Added a constructor for
`ResourceQuantities`.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70150/#review213606
-----------------------------------------------------------
Ship it!
Should probably clarify that we're replacing the constructor in the summary?
- Benjamin Mahler
On March 7, 2019, 7:04 a.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70150/
> -----------------------------------------------------------
>
> (Updated March 7, 2019, 7:04 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The constructor constructs `ResourceQuantities`
> from `google::protobuf::Map<std::string, Value::Scalar>`.
> It replaces one of the current constructors that takes
> in `OfferFilters::ResourceQuantities`.
>
>
> Diffs
> -----
>
> src/common/resource_quantities.hpp 31ce7b98a8256173d6ad26e2f095373a01d7baae
> src/common/resource_quantities.cpp 1c8eec03580abf86df4ce947c517a74b0a8e09a7
> src/master/allocator/mesos/hierarchical.cpp 7085c23eeb163854712391e24d902902b8aaf162
>
>
> Diff: https://reviews.apache.org/r/70150/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>