You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/01/12 14:08:34 UTC
[GitHub] [skywalking-data-collect-protocol] wu-sheng opened a new pull request #60: Fix GCPhrase to GCPhase
wu-sheng opened a new pull request #60:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/60
Legacy grammar error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] wu-sheng merged pull request #60: Fix GCPhrase to GCPhase
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #60:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/60
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] wu-sheng commented on pull request #60: Fix GCPhrase to GCPhase
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #60:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/60#issuecomment-1011085511
> Does this PR need to be merged before updating it everywhere like here: https://github.com/apache/skywalking/blob/0d5a289c207478cc3f43a95054bde81b1ed7a1e2/oap-server/server-starter/src/main/resources/oal/java-agent.oal#L25?
Don't have to do now. When the submodule is updated, the codes need to change with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] BFergerson commented on pull request #60: Fix GCPhrase to GCPhase
Posted by GitBox <gi...@apache.org>.
BFergerson commented on pull request #60:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/60#issuecomment-1011084263
Does this PR need to be merged before updating it everywhere like here: https://github.com/apache/skywalking/blob/0d5a289c207478cc3f43a95054bde81b1ed7a1e2/oap-server/server-starter/src/main/resources/oal/java-agent.oal#L25?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-data-collect-protocol] BFergerson commented on a change in pull request #60: Fix GCPhrase to GCPhase
Posted by GitBox <gi...@apache.org>.
BFergerson commented on a change in pull request #60:
URL: https://github.com/apache/skywalking-data-collect-protocol/pull/60#discussion_r783109491
##########
File path: language-agent/JVMMetric.proto
##########
@@ -75,15 +75,15 @@ enum PoolType {
}
message GC {
- GCPhrase phrase = 1;
+ GCPhase phrase = 1;
Review comment:
```suggestion
GCPhase phase = 1;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org