You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Vivek Padmanabhan (JIRA)" <ji...@apache.org> on 2011/07/20 13:35:58 UTC

[jira] [Created] (PIG-2181) Improvement : for error message when describe misses alias

Improvement : for error message when describe misses alias
----------------------------------------------------------

                 Key: PIG-2181
                 URL: https://issues.apache.org/jira/browse/PIG-2181
             Project: Pig
          Issue Type: Bug
    Affects Versions: 0.9.0
            Reporter: Vivek Padmanabhan
            Priority: Minor


In Pig 0.9, if I have a describe without an alias, it throws a NullPointerException like below.

ERROR 2999: Unexpected internal error. null

java.lang.NullPointerException
        at org.apache.pig.tools.grunt.GruntParser.processDescribe(GruntParser.java:270)
        at org.apache.pig.tools.pigscript.parser.PigScriptParser.parse(PigScriptParser.java:317)
        at org.apache.pig.tools.grunt.GruntParser.parseStopOnError(GruntParser.java:188)
        at org.apache.pig.tools.grunt.GruntParser.parseStopOnError(GruntParser.java:164)
        at org.apache.pig.tools.grunt.Grunt.exec(Grunt.java:81)
        at org.apache.pig.Main.run(Main.java:553)
        at org.apache.pig.Main.main(Main.java:108)


For example;
describe;

This message is of no use from a users perspective. Especially when my script becomes large and I have added couple of describe statements. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2181) Improvement : for error message when describe misses alias

Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olga Natkovich updated PIG-2181:
--------------------------------

    Fix Version/s: 0.10

> Improvement : for error message when describe misses alias
> ----------------------------------------------------------
>
>                 Key: PIG-2181
>                 URL: https://issues.apache.org/jira/browse/PIG-2181
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.9.0
>            Reporter: Vivek Padmanabhan
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.10
>
>         Attachments: PIG-2181_1.patch
>
>
> In Pig 0.9, if I have a describe without an alias, it throws a NullPointerException like below.
> ERROR 2999: Unexpected internal error. null
> java.lang.NullPointerException
>         at org.apache.pig.tools.grunt.GruntParser.processDescribe(GruntParser.java:270)
>         at org.apache.pig.tools.pigscript.parser.PigScriptParser.parse(PigScriptParser.java:317)
>         at org.apache.pig.tools.grunt.GruntParser.parseStopOnError(GruntParser.java:188)
>         at org.apache.pig.tools.grunt.GruntParser.parseStopOnError(GruntParser.java:164)
>         at org.apache.pig.tools.grunt.Grunt.exec(Grunt.java:81)
>         at org.apache.pig.Main.run(Main.java:553)
>         at org.apache.pig.Main.main(Main.java:108)
> For example;
> describe;
> This message is of no use from a users perspective. Especially when my script becomes large and I have added couple of describe statements. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2181) Improvement : for error message when describe misses alias

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-2181:
----------------------------

      Resolution: Fixed
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

Unit tests pass. Test-patch:
     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.

Patch committed to trunk. 

Thanks Vivek!

> Improvement : for error message when describe misses alias
> ----------------------------------------------------------
>
>                 Key: PIG-2181
>                 URL: https://issues.apache.org/jira/browse/PIG-2181
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.9.0
>            Reporter: Vivek Padmanabhan
>            Assignee: Vivek Padmanabhan
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.10
>
>         Attachments: PIG-2181_1.patch
>
>
> In Pig 0.9, if I have a describe without an alias, it throws a NullPointerException like below.
> ERROR 2999: Unexpected internal error. null
> java.lang.NullPointerException
>         at org.apache.pig.tools.grunt.GruntParser.processDescribe(GruntParser.java:270)
>         at org.apache.pig.tools.pigscript.parser.PigScriptParser.parse(PigScriptParser.java:317)
>         at org.apache.pig.tools.grunt.GruntParser.parseStopOnError(GruntParser.java:188)
>         at org.apache.pig.tools.grunt.GruntParser.parseStopOnError(GruntParser.java:164)
>         at org.apache.pig.tools.grunt.Grunt.exec(Grunt.java:81)
>         at org.apache.pig.Main.run(Main.java:553)
>         at org.apache.pig.Main.main(Main.java:108)
> For example;
> describe;
> This message is of no use from a users perspective. Especially when my script becomes large and I have added couple of describe statements. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2181) Improvement : for error message when describe misses alias

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Dai updated PIG-2181:
----------------------------

    Labels: newbie  (was: )

> Improvement : for error message when describe misses alias
> ----------------------------------------------------------
>
>                 Key: PIG-2181
>                 URL: https://issues.apache.org/jira/browse/PIG-2181
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.9.0
>            Reporter: Vivek Padmanabhan
>            Priority: Minor
>              Labels: newbie
>
> In Pig 0.9, if I have a describe without an alias, it throws a NullPointerException like below.
> ERROR 2999: Unexpected internal error. null
> java.lang.NullPointerException
>         at org.apache.pig.tools.grunt.GruntParser.processDescribe(GruntParser.java:270)
>         at org.apache.pig.tools.pigscript.parser.PigScriptParser.parse(PigScriptParser.java:317)
>         at org.apache.pig.tools.grunt.GruntParser.parseStopOnError(GruntParser.java:188)
>         at org.apache.pig.tools.grunt.GruntParser.parseStopOnError(GruntParser.java:164)
>         at org.apache.pig.tools.grunt.Grunt.exec(Grunt.java:81)
>         at org.apache.pig.Main.run(Main.java:553)
>         at org.apache.pig.Main.main(Main.java:108)
> For example;
> describe;
> This message is of no use from a users perspective. Especially when my script becomes large and I have added couple of describe statements. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2181) Improvement : for error message when describe misses alias

Posted by "Vivek Padmanabhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vivek Padmanabhan updated PIG-2181:
-----------------------------------

    Attachment: PIG-2181_1.patch

This looks like a change in behaviour introduced due to the parser changes. In Pig 0.8 , "describe ; " would show the describe of the last alias
rather than NullPointerException. This is done through;
 alias = mPigServer.getPigContext().getLastAlias(); , but in 0.9, the last alias is not captured in Pig Context.


Attaching an initial patch.

> Improvement : for error message when describe misses alias
> ----------------------------------------------------------
>
>                 Key: PIG-2181
>                 URL: https://issues.apache.org/jira/browse/PIG-2181
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.9.0
>            Reporter: Vivek Padmanabhan
>            Priority: Minor
>              Labels: newbie
>         Attachments: PIG-2181_1.patch
>
>
> In Pig 0.9, if I have a describe without an alias, it throws a NullPointerException like below.
> ERROR 2999: Unexpected internal error. null
> java.lang.NullPointerException
>         at org.apache.pig.tools.grunt.GruntParser.processDescribe(GruntParser.java:270)
>         at org.apache.pig.tools.pigscript.parser.PigScriptParser.parse(PigScriptParser.java:317)
>         at org.apache.pig.tools.grunt.GruntParser.parseStopOnError(GruntParser.java:188)
>         at org.apache.pig.tools.grunt.GruntParser.parseStopOnError(GruntParser.java:164)
>         at org.apache.pig.tools.grunt.Grunt.exec(Grunt.java:81)
>         at org.apache.pig.Main.run(Main.java:553)
>         at org.apache.pig.Main.main(Main.java:108)
> For example;
> describe;
> This message is of no use from a users perspective. Especially when my script becomes large and I have added couple of describe statements. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (PIG-2181) Improvement : for error message when describe misses alias

Posted by "Daniel Dai (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/PIG-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069650#comment-13069650 ] 

Daniel Dai commented on PIG-2181:
---------------------------------

Good catch. +1 for patch. I will commit it if tests pass.

> Improvement : for error message when describe misses alias
> ----------------------------------------------------------
>
>                 Key: PIG-2181
>                 URL: https://issues.apache.org/jira/browse/PIG-2181
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.9.0
>            Reporter: Vivek Padmanabhan
>            Assignee: Vivek Padmanabhan
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.10
>
>         Attachments: PIG-2181_1.patch
>
>
> In Pig 0.9, if I have a describe without an alias, it throws a NullPointerException like below.
> ERROR 2999: Unexpected internal error. null
> java.lang.NullPointerException
>         at org.apache.pig.tools.grunt.GruntParser.processDescribe(GruntParser.java:270)
>         at org.apache.pig.tools.pigscript.parser.PigScriptParser.parse(PigScriptParser.java:317)
>         at org.apache.pig.tools.grunt.GruntParser.parseStopOnError(GruntParser.java:188)
>         at org.apache.pig.tools.grunt.GruntParser.parseStopOnError(GruntParser.java:164)
>         at org.apache.pig.tools.grunt.Grunt.exec(Grunt.java:81)
>         at org.apache.pig.Main.run(Main.java:553)
>         at org.apache.pig.Main.main(Main.java:108)
> For example;
> describe;
> This message is of no use from a users perspective. Especially when my script becomes large and I have added couple of describe statements. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (PIG-2181) Improvement : for error message when describe misses alias

Posted by "Vivek Padmanabhan (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PIG-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vivek Padmanabhan updated PIG-2181:
-----------------------------------

    Assignee: Vivek Padmanabhan
      Status: Patch Available  (was: Open)

> Improvement : for error message when describe misses alias
> ----------------------------------------------------------
>
>                 Key: PIG-2181
>                 URL: https://issues.apache.org/jira/browse/PIG-2181
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.9.0
>            Reporter: Vivek Padmanabhan
>            Assignee: Vivek Padmanabhan
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.10
>
>         Attachments: PIG-2181_1.patch
>
>
> In Pig 0.9, if I have a describe without an alias, it throws a NullPointerException like below.
> ERROR 2999: Unexpected internal error. null
> java.lang.NullPointerException
>         at org.apache.pig.tools.grunt.GruntParser.processDescribe(GruntParser.java:270)
>         at org.apache.pig.tools.pigscript.parser.PigScriptParser.parse(PigScriptParser.java:317)
>         at org.apache.pig.tools.grunt.GruntParser.parseStopOnError(GruntParser.java:188)
>         at org.apache.pig.tools.grunt.GruntParser.parseStopOnError(GruntParser.java:164)
>         at org.apache.pig.tools.grunt.Grunt.exec(Grunt.java:81)
>         at org.apache.pig.Main.run(Main.java:553)
>         at org.apache.pig.Main.main(Main.java:108)
> For example;
> describe;
> This message is of no use from a users perspective. Especially when my script becomes large and I have added couple of describe statements. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira