[jira] [Commented] (HBASE-23095) Reuse FileStatus in StoreFileInfo

["Hudson (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-23095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16946931#comment-16946931 ] 

Hudson commented on HBASE-23095:
--------------------------------

Results for branch master
	[build #1497 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1497/]: (x) *{color:red}-1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/master/1497//General_Nightly_Build_Report/]




(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1497//JDK8_Nightly_Build_Report_(Hadoop2)/]


(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/master/1497//JDK8_Nightly_Build_Report_(Hadoop3)/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Reuse FileStatus in StoreFileInfo
> ---------------------------------
>
>                 Key: HBASE-23095
>                 URL: https://issues.apache.org/jira/browse/HBASE-23095
>             Project: HBase
>          Issue Type: Improvement
>          Components: mob, snapshots
>    Affects Versions: 1.1.2, 1.2.1, 2.0.0, 2.2.1
>            Reporter: Karthik Palanisamy
>            Assignee: Karthik Palanisamy
>            Priority: Major
>              Labels: performance
>             Fix For: 3.0.0, 2.3.0, 2.2.2, 2.1.8
>
>         Attachments: PerformanceComparision.pdf
>
>
> The performance of create snapshot on large MOB table reasonably slow because there are two unnecessary calls to namenode on each Hfile, this while we create snapshot manifest. The first namenode call for getting StoreFile modification time [link|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java#L139]] which used for metrics and another namenode call for getting StoreFile size [link|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/SnapshotManifestV2.java#L132]] which used in snapshot manifest. Both calls can be avoided and this info can be fetched from existing FileStatus [link|[https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java#L155]].
>  
> PFA. 2x performance is seen after reusing existing FileStatus.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)