[GitHub] [shardingsphere] GLBB commented on a change in pull request #9583: #9527 make exception message more detail

[GitBox <gi...@apache.org>]

GLBB commented on a change in pull request #9583:
URL: https://github.com/apache/shardingsphere/pull/9583#discussion_r587539361



##########
File path: shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/config/exception/ShardingSphereConfigurationException.java
##########
@@ -42,4 +42,14 @@ public ShardingSphereConfigurationException(final String errorMessage, final Obj
     public ShardingSphereConfigurationException(final Exception cause) {
         super(cause);
     }
+
+    /**
+     * Constructs an exception with cause exception and error message. 
+     * 
+     * @param cause cause exception
+     * @param errorMessage error message
+     */
+    public ShardingSphereConfigurationException(final Exception cause, final String errorMessage) {

Review comment:
       yes, can replace. in the first place, I thought origin exception stack can see datasource which setter method error, but after try, it can't see which method error




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org