You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/19 15:41:06 UTC
[GitHub] StefanRRichter commented on a change in pull request #6875:
[FLINK-9808] [state backends] Migrate state when necessary in state backends
StefanRRichter commented on a change in pull request #6875: [FLINK-9808] [state backends] Migrate state when necessary in state backends
URL: https://github.com/apache/flink/pull/6875#discussion_r226666394
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBKeyedStateBackend.java
##########
@@ -1389,6 +1388,149 @@ private void copyStateDataHandleData(
return Tuple2.of(stateInfo.f0, newMetaInfo);
}
+ private <N, S extends State, SV> RegisteredKeyValueStateBackendMetaInfo<N, SV> migrateStateIfNecessary(
+ StateDescriptor<S, SV> stateDesc,
+ TypeSerializer<N> namespaceSerializer,
+ Tuple2<ColumnFamilyHandle, RegisteredStateMetaInfoBase> stateInfo,
+ @Nullable StateSnapshotTransformer<SV> snapshotTransformer) throws Exception {
+
+ StateMetaInfoSnapshot restoredMetaInfoSnapshot = restoredKvStateMetaInfos.get(stateDesc.getName());
+
+ Preconditions.checkState(
+ restoredMetaInfoSnapshot != null,
+ "Requested to check compatibility of a restored RegisteredKeyedBackendStateMetaInfo," +
+ " but its corresponding restored snapshot cannot be found.");
+
+ Preconditions.checkState(restoredMetaInfoSnapshot.getBackendStateType()
+ == StateMetaInfoSnapshot.BackendStateType.KEY_VALUE,
+ "Incompatible state types. " +
+ "Was [" + restoredMetaInfoSnapshot.getBackendStateType() + "], " +
+ "registered as [" + StateMetaInfoSnapshot.BackendStateType.KEY_VALUE + "].");
+
+ Preconditions.checkState(
+ Objects.equals(stateDesc.getName(), restoredMetaInfoSnapshot.getName()),
+ "Incompatible state names. " +
+ "Was [" + restoredMetaInfoSnapshot.getName() + "], " +
+ "registered with [" + stateDesc.getName() + "].");
+
+ final StateDescriptor.Type restoredType =
+ StateDescriptor.Type.valueOf(
+ restoredMetaInfoSnapshot.getOption(
+ StateMetaInfoSnapshot.CommonOptionsKeys.KEYED_STATE_TYPE));
+
+ if (!Objects.equals(stateDesc.getType(), StateDescriptor.Type.UNKNOWN)
Review comment:
I suggest to compare enums with `!=` instead of `!Objects.equals`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services